https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030 --- Comment #27 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 53450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53450 Bug 15030: Fix the uninitialized warnings in ClassSortRoutine::_get_class_sort_key Review of attachment 53450: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15030&attachment=53450) ----------------------------------------------------------------- ::: C4/ClassSortRoutine.pm @@ +112,5 @@

=cut

sub _get_class_sort_key { + my $cn_class = shift || ''; + my $cn_item = shift || '';

@_ is the better way to assign. Shift on a missing parameter will trigger a warning. $cn_class //= q{}; $cn_item //= q{}; Then you could do two assigns like the above to handle if they aren't assigned values. -- You are receiving this mail because: You are watching all bug changes.