[Bug 23656] New: Add search box to top of page on cataloguing/editor.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Bug ID: 23656 Summary: Add search box to top of page on cataloguing/editor.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.johnson@bedfordtx.gov QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In the Advanced Cataloging editor, both addbooks.pl and additem.pl have a cataloging search box at the top of the page. It would be great to add one to cataloguing/editor.pl so that users don’t have to click away from the page if they need to perform a new search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think this is the case now - when I go to cataloguing we have the normal tabbed search options showing on top. Marking RESOLVED - please reopen if I misunderstood. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WORKSFORME |--- Status|RESOLVED |REOPENED --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actually, I was mistaken: cataloguing/addbiblio.pl? doesn't always have the searches. Once you actually open a record for editing the searches are gone. I think this was done to save up on space, as the cataloguing form is usually quite long. Do we want to sacrifice the space here for the full search options on top? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 121421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121421&action=edit Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Hakam Almotlak <hakam.almotlak@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121421|0 |1 is obsolete| | --- Comment #4 from Hakam Almotlak <hakam.almotlak@inLibro.com> --- Created attachment 122336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122336&action=edit Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected Signed-off-by: hakam <hakam@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Hakam Almotlak <hakam.almotlak@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122336|0 |1 is obsolete| | --- Comment #5 from Hakam Almotlak <hakam.almotlak@inLibro.com> --- Created attachment 122337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122337&action=edit Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Hakam Almotlak <hakam.almotlak@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hakam.almotlak@inLibro.com --- Comment #6 from Hakam Almotlak <hakam.almotlak@inLibro.com> --- the button works and everything but when i try to search something or click on anything in the search bar, the search bar disappear even if i press on the options in the search bar like check in and check out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122337|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122340&action=edit Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|hakam.almotlak@inLibro.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kelly@bywatersolutions.com --- Comment #8 from Kelly McElligott <kelly@bywatersolutions.com> --- This is fantastic, I love it. But,...it would be nice to see this on the Advanced Editor Cataloging module as well! Thank you for all you do !!!! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122340|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123707&action=edit Bug 23656: Add hidden search bar to addbiblio and allow toggling This patch adds the search header to the cataloging editor page, defaulted as hidden A new link is added to show the bar, or hide the bar To test: 1 - Apply patch 2 - Load the basic cataloging editor for a book 3 - Note new link near top 'Show search box' 4 - Click it 5 - Search box appears 6 - Click now visible 'Hide search box' 7 - Search box hides 8 - Confirm search box works as expected 9 - Repeat for the advanced cataloging editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Kelly McElligott <kelly@bywatersolutions.com> --- This is fantastic- quick work! I signed off on this: Kelly McElligott kelly@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |oleonard@myacpl.org --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can see that this is something that has come up more than once. I am totally ok with us adding this feature, but I feel that it doesn't look quite right yet. 1) Styling If you look at the visible search, it's not "seamless" with the background color. The "Hide/Show" link is stuck to the very left end of the screen without any margin/padding and looks a little out of place. 2) I wonder if it would be more in line with how this page works, to stick the option into the "Settings" section and also make it stick with a cookie as the other options do? At the moment it resets to "hidden" with every page load. Bonus points for thinking about a way to make sure the "Hide/Show" link is translatable :) Could you please have a look and let me know what you think and if we might be able to fix 1) at least? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 --- Comment #12 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Yes, the blue gradient on the visible box does not extend across the full screen making it look odd. The position of the link looks like it needs about a 10px top and bottom margin and a 20px left margin to make it look nicer. But the link still looks a little odd and lost on the page to me. I wonder if it should be more of a toggle button? (see attachment) I really like the idea of putting the option into the "Settings" section and making it stick with a cookie. I think this would create a better workflow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 --- Comment #13 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Created attachment 131127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131127&action=edit Seachbox toggle example -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123707|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 146743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146743&action=edit Bug 23656: Add cataloguing search bar to addbiblio This patch adds the search header to the cataloging editor page. With the staff redesign, this takes up very little space, so I think can be added and visible by default To test: 1 - Apply patch 2 - Load the basic cataloging editor for a bib 3 - Note lack of search bar 4 - Apply patch 5 - Reload the page 6 - You have a search bar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- I think the new staff design makes some of the older comments here irrelevant, this works/looks good in the new design. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146743|0 |1 is obsolete| | --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146850&action=edit Bug 23656: Add cataloguing search bar to addbiblio This patch adds the search header to the cataloging editor page. With the staff redesign, this takes up very little space, so I think can be added and visible by default To test: 1 - Apply patch 2 - Load the basic cataloging editor for a bib 3 - Note lack of search bar 4 - Apply patch 5 - Reload the page 6 - You have a search bar Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #15)
I think the new staff design makes some of the older comments here irrelevant, this works/looks good in the new design.
I agree that the new staff design makes this work well and now the search bar adds some nice consistency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146850|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147356&action=edit Bug 23656: Add cataloguing search bar to addbiblio This patch adds the search header to the cataloging editor page. With the staff redesign, this takes up very little space, so I think can be added and visible by default To test: 1 - Apply patch 2 - Load the basic cataloging editor for a bib 3 - Note lack of search bar 4 - Apply patch 5 - Reload the page 6 - You have a search bar Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add search box to top of |Add search box at the top |page on |of the cataloging editor |cataloguing/editor.pl |page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds the search header release notes| |to the cataloging editor | |page. With the recent staff | |interface redesign, this | |takes up very little space. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23656 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36472 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org