[Bug 10419] New: There is no cronjob script for deleting patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Bug ID: 10419 Summary: There is no cronjob script for deleting patrons Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5636 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18677&action=edit Bug 10419: Script for deleting patrons This patch provides a cronjob script for deleting patrons. It takes 3 options: -not_borrowered_since -expired_date -category_code See the perldoc misc/cronjobs/delete_patrons.pl use the -v flag for a verbose mode. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Not nit picking, but would be nicer to write eval {}; if ($@) { say "Failed ... $@"; next; } eval {}; if ($@) { say "Failed ... $@"; next; } say OK; Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Srdjan, yep, you are right! I don't know at all why I wrote that this way, not really readable... :) Thanks for the catch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18677|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18725&action=edit Bug 10419: Script for deleting patrons This patch provides a cronjob script for deleting patrons. It takes 3 options: -not_borrowered_since -expired_date -category_code See the perldoc misc/cronjobs/delete_patrons.pl use the -v flag for a verbose mode. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18725|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18743&action=edit Bug 10419: Script for deleting patrons This patch provides a cronjob script for deleting patrons. It takes 3 options: -not_borrowered_since -expired_date -category_code See the perldoc misc/cronjobs/delete_patrons.pl use the -v flag for a verbose mode. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #6 from Kyle M Hall <kyle.m.hall@gmail.com> --- Looks good, but I've a few suggestions: 1) I'd switch from --dry-run to --confirm. This seems to be a more standard way to do things ( in so far as a number of scripts have --confirm and none have --dry-run ). 2) The script has "first person" style output, whereas no other Koha cli scripts do. It might be better to remove the "I"s from the script output 3) The use of the "date" program in the example output, while clever and a great idea, makes the help a bit confusing and hard to read. It would be better to juse put hard dates in the example usage, and a short explanation on how to use `date` to autogenerate the dates. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18754&action=edit Bug 10419: Followup - Script for deleting patrons This followup adds: - execute flag (+x) for the cronjob script. - replaces --dry-run with --confirm (according with existing scripts). - changes output text (remove 'first person' style). - updates the doc and simplifies the dates parameters. - changes flags PrintError and RaiseError for the dbh in order to catch something if an error occurs... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Thanks for testing Kyle. I provide a new patch in order to apply your suggestions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18754|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18990&action=edit Bug 10419: Followup - Script for deleting patrons This followup adds: - execute flag (+x) for the cronjob script. - replaces --dry-run with --confirm (according with existing scripts). - changes output text (remove 'first person' style). - updates the doc and simplifies the dates parameters. - changes flags PrintError and RaiseError for the dbh in order to catch something if an error occurs... Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Everything looks great! Thanks for following up on my suggestions! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This still needs testing, but I didn't spot problems while reviewing the code. Only wondering if we should offer the branchcode as another option in the script. GetBorrowersToExpunge would allow it already: 2025 =head2 GetBorrowersToExpunge 2026 2027 $borrowers = &GetBorrowersToExpunge( 2028 not_borrowered_since => $not_borrowered_since, 2029 expired_before => $expired_before, 2030 category_code => $category_code, 2031 branchcode => $branchcode 2032 ); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19635&action=edit Bug 10419: Add the branchcode parameter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19635|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19651&action=edit Bug 10419: Add the branchcode parameter. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18743|0 |1 is obsolete| | --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20112&action=edit Bug 10419: Script for deleting patrons This patch provides a cronjob script for deleting patrons. It takes 3 options: -not_borrowered_since -expired_date -category_code See the perldoc misc/cronjobs/delete_patrons.pl use the -v flag for a verbose mode. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18990|0 |1 is obsolete| | --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20113&action=edit Bug 10419: Followup - Script for deleting patrons This followup adds: - execute flag (+x) for the cronjob script. - replaces --dry-run with --confirm (according with existing scripts). - changes output text (remove 'first person' style). - updates the doc and simplifies the dates parameters. - changes flags PrintError and RaiseError for the dbh in order to catch something if an error occurs... Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19651|0 |1 is obsolete| | --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20114&action=edit Bug 10419: Add the branchcode parameter. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20115&action=edit Bug 10419 : Fixing license number -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20112|0 |1 is obsolete| | Attachment #20113|0 |1 is obsolete| | Attachment #20114|0 |1 is obsolete| | Attachment #20115|0 |1 is obsolete| | --- Comment #18 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20133&action=edit Bug 10419: new cronjob for deleting patrons This patch provides a cronjob script for deleting patrons. It takes 3 options: --not_borrowed_since --expired_date --category_code See the perldoc misc/cronjobs/delete_patrons.pl. Use the -v flag for a verbose mode. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #19 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20134&action=edit Bug 10419: (followup) - tidy up cronjob for deleting patrons This followup adds: - execute flag (+x) for the cronjob script. - replaces --dry-run with --confirm (according with existing scripts). - changes output text (remove 'first person' style). - updates the doc and simplifies the dates parameters. - changes flags PrintError and RaiseError for the dbh in order to catch something if an error occurs... Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #20 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20135&action=edit Bug 10419: add branchcode parameter to patron deletion script Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #21 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20136&action=edit Bug 10419: (followup) fix license statement Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #22 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20137&action=edit Bug 10419: (follow-up) tidy names of command-line switches [1] Use --library instead of --branchcode to be consistent with other scripts and user-facing Koha terminology. [2] Use --not_borrowed_since instead of --not_borrowered_since; no need to expose typos in the API to the user. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #23 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20138&action=edit Bug 10419: (follow-up) functional improvements [1] Patron deletion now happens atomically; if one part of the process fails, the record isn't left in a partially deleted state. [2] The routine for handling lists properly during patron deletion is now invoked. [3] The script now prints an indication if it's run without --confirm; otherwise, one might think that patron records were actually being deleted. [4] --verbose now actually does something. Without --verbose, the script will print the dry-run warning (if applicable), the number of patrons to be deleted, and error messages. With --verbose, the script will also print a line with the borrowernumber of each patron to be deleted. To test: [1] Run the script with and without --verbose and compare the, well, verbosity. [2] Run the script without --confirm and note that the script prints a message saying that it's running in dry-run mode. [3] Use the script to try to delete one or more patrons that have loans. Confirm that error messages are printed reporting foreign constraints preventing the deletion. Also confirm that no new rows are added to deletedborrowers for those patrons that could not be completely deleted. [4] Use the script to delete a patron that has a public list. Verify that after the deletion, the public list still exists but now has a null owner. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #24 from Galen Charlton <gmcharlt@gmail.com> --- I ended up making two follow-ups that add two major and several minor improvements. Setting to 'Signed Off' and requesting QA of the follow-ups. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20136|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20294&action=edit Bug 10419: (followup) fix license statement Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20137|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20295&action=edit Bug 10419: (follow-up) tidy names of command-line switches [1] Use --library instead of --branchcode to be consistent with other scripts and user-facing Koha terminology. [2] Use --not_borrowed_since instead of --not_borrowered_since; no need to expose typos in the API to the user. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20138|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20296&action=edit Bug 10419: (follow-up) functional improvements [1] Patron deletion now happens atomically; if one part of the process fails, the record isn't left in a partially deleted state. [2] The routine for handling lists properly during patron deletion is now invoked. [3] The script now prints an indication if it's run without --confirm; otherwise, one might think that patron records were actually being deleted. [4] --verbose now actually does something. Without --verbose, the script will print the dry-run warning (if applicable), the number of patrons to be deleted, and error messages. With --verbose, the script will also print a line with the borrowernumber of each patron to be deleted. To test: [1] Run the script with and without --verbose and compare the, well, verbosity. [2] Run the script without --confirm and note that the script prints a message saying that it's running in dry-run mode. [3] Use the script to try to delete one or more patrons that have loans. Confirm that error messages are printed reporting foreign constraints preventing the deletion. Also confirm that no new rows are added to deletedborrowers for those patrons that could not be completely deleted. [4] Use the script to delete a patron that has a public list. Verify that after the deletion, the public list still exists but now has a null owner. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20297&action=edit Bug 10419: FIX hardcoded records and pod Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Started to look at this, all tests pass and nothing found in code review so far :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Back to this, sorry it took me so long. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have started testing this, but ran into something that doesn't seem right: Testing notes: ./delete_patrons.pl Gives a helpful message about the use of the script. ./delete_patrons.pl -h Outputs useful information about the use of the script and its various options. ./delete_patrons.pl --category_code ST --library CPL Gives the correct results in numbers and deletion was done properly. Testing various conditions where a delete should not occur: - Patron has checkouts Patron is not in list of patrons to delete (x patrons to delete) - Patron has fines Patron is still in list of patrons to delete (x patrons to delete) Patron is deleted, script gives no success message. ./delete_patrons.pl --category_code ST --library CPL -c 1 patrons to delete When you check the database, the patron has been deleted (including the move to deletedborrowers), although he owed money to the library. (I used a MANUAL_INV of copier fees here). I verified that deleting patrons with fines is not possible in the interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Also, I think there should be feedback about when the script is done? Even if it was just: x patrons deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21658&action=edit Bug 10419: Patrons with fines should not be deleted Test plan: - add a fine for a patron - verify the script does not delete this patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-10-02 last check this| | --- Comment #34 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20297|0 |1 is obsolete| | --- Comment #35 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21765&action=edit [SIGNED-OFF] Bug 10419: FIX hardcoded records and pod Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Missing a sign. Removes harcoded values -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21765|0 |1 is obsolete| | --- Comment #36 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21766&action=edit [SIGNED-OFF] Bug 10419: Patrons with fines should not be deleted Test plan: - add a fine for a patron - verify the script does not delete this patron. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, script do not delete a patron with fines. No koha-qa errors with all patches applied Test 1) Added a fine to a patron 2) run script 3) reports condition Trying to delete patron 5... Failed to delete patron 5: patron has 10.00 in fines 4) Patron is not deleted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21766|0 |1 is obsolete| | CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20297|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #37 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- sorry, made a mistake, re-uploading patches -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20297|0 |1 is obsolete| | --- Comment #38 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21773&action=edit [SIGNED-OFF] Bug 10419: FIX hardcoded records and pod Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Missing a sign. Removes harcoded values -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21658|0 |1 is obsolete| | --- Comment #39 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 21774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21774&action=edit [SIGNED-OFF] Bug 10419: Patrons with fines should not be deleted Test plan: - add a fine for a patron - verify the script does not delete this patron. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, script do not delete a patron with fines. No koha-qa errors with all patches applied Test 1) Added a fine to a patron 2) run script 3) reports condition Trying to delete patron 5... Failed to delete patron 5: patron has 10.00 in fines 4) Patron is not deleted -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20133|0 |1 is obsolete| | Attachment #20134|0 |1 is obsolete| | Attachment #20135|0 |1 is obsolete| | Attachment #20294|0 |1 is obsolete| | Attachment #20295|0 |1 is obsolete| | Attachment #20296|0 |1 is obsolete| | Attachment #21773|0 |1 is obsolete| | Attachment #21774|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21780&action=edit [PASSED QA] Bug 10419: new cronjob for deleting patrons This patch provides a cronjob script for deleting patrons. It takes 3 options: --not_borrowed_since --expired_date --category_code See the perldoc misc/cronjobs/delete_patrons.pl. Use the -v flag for a verbose mode. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. http://bugs.koha-community.org/show_bug.cgi?id=10219 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21781&action=edit [PASSED QA] Bug 10419: (followup) - tidy up cronjob for deleting patrons This followup adds: - execute flag (+x) for the cronjob script. - replaces --dry-run with --confirm (according with existing scripts). - changes output text (remove 'first person' style). - updates the doc and simplifies the dates parameters. - changes flags PrintError and RaiseError for the dbh in order to catch something if an error occurs... Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21782&action=edit [PASSED QA] Bug 10419: add branchcode parameter to patron deletion script Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21783&action=edit [PASSED QA] Bug 10419: (followup) fix license statement Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21784&action=edit [PASSED QA] Bug 10419: (follow-up) tidy names of command-line switches [1] Use --library instead of --branchcode to be consistent with other scripts and user-facing Koha terminology. [2] Use --not_borrowed_since instead of --not_borrowered_since; no need to expose typos in the API to the user. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21785&action=edit [PASSED QA] Bug 10419: (follow-up) functional improvements [1] Patron deletion now happens atomically; if one part of the process fails, the record isn't left in a partially deleted state. [2] The routine for handling lists properly during patron deletion is now invoked. [3] The script now prints an indication if it's run without --confirm; otherwise, one might think that patron records were actually being deleted. [4] --verbose now actually does something. Without --verbose, the script will print the dry-run warning (if applicable), the number of patrons to be deleted, and error messages. With --verbose, the script will also print a line with the borrowernumber of each patron to be deleted. To test: [1] Run the script with and without --verbose and compare the, well, verbosity. [2] Run the script without --confirm and note that the script prints a message saying that it's running in dry-run mode. [3] Use the script to try to delete one or more patrons that have loans. Confirm that error messages are printed reporting foreign constraints preventing the deletion. Also confirm that no new rows are added to deletedborrowers for those patrons that could not be completely deleted. [4] Use the script to delete a patron that has a public list. Verify that after the deletion, the public list still exists but now has a null owner. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21786&action=edit [PASSED QA] Bug 10419: FIX hardcoded records and pod Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Missing a sign. Removes harcoded values Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21787&action=edit [PASSED QA] Bug 10419: Patrons with fines should not be deleted Test plan: - add a fine for a patron - verify the script does not delete this patron. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, script do not delete a patron with fines. No koha-qa errors with all patches applied Test 1) Added a fine to a patron 2) run script 3) reports condition Trying to delete patron 5... Failed to delete patron 5: patron has 10.00 in fines 4) Patron is not deleted Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested various combinations of options: ./delete_patrons.pl Gives a helpful message about the use of the script. ./delete_patrons.pl -h Outputs useful information about the use of the script and its various options. ./delete_patrons.pl --category_code ST --library CPL Gives the correct results in numbers and deletion was done properly. Also tested: --expired_before --not_borrowed_since -v Testing various conditions where a delete should not occur: - Patron has checkouts Patron is not in list of patrons to delete (x patrons to delete) - Patron has fines Patron is still in list of patrons to delete (x patrons to delete) Checked deleted patrons had been moved to deletedborrowers. Notes about possible enhancements: - only print the success message 'x patrons deleted' when confirm flag was set - patrons with current checkouts are silently excluded from the number of patrons to be deleted. Printing the number with current checkouts might be helpful. Changes made: Fixed a small error in the documentation: expired_date is expired_before. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10419 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #48 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org