https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42617 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42617 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 199196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199196&action=edit Bug 42617: (41512 follow-up) Remove ownPagination and fix recordsFiltered propagation ownPagination set recordsFiltered on json.data instead of json, causing DataTables to display "NaN total entries". Remove the artificial 5000 mechanism, propagate real counts from plugins that provide them, and fall back to actual result counts for those that don't. Also removes a dead drawCallback overwritten before it could fire. Test plan: 1) Install this test version of the unpaywall plugin: https://github.com/openfifth/koha-plugin-ill-avail-unpaywall/releases/tag/te... 2) Enable ILLModule and ILLCheckAvailability 3) Configure the plugin and add any emaill address 4) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 5) Enter '42' for cardnumber, any library, and any DOI e.g. '123'. 6) Verify that pagination works as expected Before patch, pagination controls dont show and the following label is shown: No entries to show (filtered from NaN total entries) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42617 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42617 --- Comment #3 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 201838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201838&action=edit Bug 42617: (41512 follow-up) Remove ownPagination and fix recordsFiltered propagation ownPagination set recordsFiltered on json.data instead of json, causing DataTables to display "NaN total entries". Remove the artificial 5000 mechanism, propagate real counts from plugins that provide them, and fall back to actual result counts for those that don't. Also removes a dead drawCallback overwritten before it could fire. Test plan: 1) Install this test version of the unpaywall plugin: https://github.com/openfifth/koha-plugin-ill-avail-unpaywall/releases/tag/te... 2) Enable ILLModule and ILLCheckAvailability 3) Configure the plugin and add any emaill address 4) Create a new ILL request: <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 5) Enter '42' for cardnumber, any library, and any DOI e.g. '123'. 6) Verify that pagination works as expected Before patch, pagination controls dont show and the following label is shown: No entries to show (filtered from NaN total entries) Signed-off-by: Edith Speller <Edith.Speller@ukhsa.gov.uk> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42617 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.