[Bug 5565] New: Default OAI UNIMARC to Dublin Core XSL adds superfluous blanks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Summary: Default OAI UNIMARC to Dublin Core XSL adds superfluous blanks Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Z39.50 / SRU / OpenSearch Servers AssignedTo: gmcharlt@gmail.com ReportedBy: frederic@tamil.fr QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 DC <dc:creator> contains blanks between forename and surname. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |frederic@tamil.fr -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #1 from Frédéric Demians <frederic@tamil.fr> 2010-12-31 06:31:52 UTC --- http://lists.koha-community.org/pipermail/koha-patches/2010-December/013485.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 --- Comment #2 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-01-04 10:25:39 UTC --- This bug is mentioned in: Bug 5565 UNIMARC to DC XSL tidy up http://lists.koha-community.org/pipermail/koha-patches/2010-December/013486.... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Needs Signoff |Does not apply --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-27 15:47:48 UTC --- the patch pointed by MJ & Frederic does not apply : 17:45 ~/koha.dev/koha-community (BZ5565 $%)$ git am -3 BZ5565.eml Applying: Bug 5565 UNIMARC to DC XSL tidy up fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2OAIDC.xsl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 5565 UNIMARC to DC XSL tidy up When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 --- Comment #4 from Frédéric Demians <frederic@tamil.fr> 2011-09-27 16:08:44 UTC --- Created attachment 5608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5608 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> 2011-09-27 16:09:07 UTC --- Created attachment 5609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5609 Proposed patch 2 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 --- Comment #6 from Frédéric Demians <frederic@tamil.fr> 2011-09-27 16:10:20 UTC ---
the patch pointed by MJ & Frederic does not apply :
I rebase it to HEAD. It should work better. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |Rel_3_8 --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:18 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:55 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-15 00:18:10 UTC --- Frederic, both patches need to be applied? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 --- Comment #10 from Frédéric Demians <frederic@tamil.fr> 2011-12-15 06:04:23 UTC --- (In reply to comment #9)
Frederic, both patches need to be applied?
Both patch still apply on HEAD. The first one fix the superfluous blanks issue and the second tidy up the UNIMARC to DC XSL file (better indentation for readability). To test: 1. On an UNIMARC Koha, activate the OAI server 2. Get the first batch of records from the OAI server: /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc 3. Ask your browser to show you the source XML file 4. You will see that there is a new line in the <dc:creator> 5. Apply the patch and repeat 2-3 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5608|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-19 08:04:38 UTC --- Created attachment 6862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6862 Bug 5565 Default OAI UNIMARC to Dublin Core XSL adds superfluous blanks Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-19 08:07:33 UTC --- Signed off on the first patch But the second one deletes the leader as well as changing the indentation - <xsl:variable name="leader" select="marc:leader"/> - <xsl:variable name="leader6" select="substring($leader,7,1)"/> - <xsl:variable name="leader7" select="substring($leader,8,1)"/> - <xsl:variable name="controlField008" select="marc:controlfield[@tag=008]"/> Should this be happening? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 --- Comment #13 from Frédéric Demians <frederic@tamil.fr> 2011-12-19 08:21:18 UTC --- (In reply to comment #12)
Signed off on the first patch
But the second one deletes the leader as well as changing the indentation
- <xsl:variable name="leader" select="marc:leader"/> - <xsl:variable name="leader6" select="substring($leader,7,1)"/> - <xsl:variable name="leader7" select="substring($leader,8,1)"/> - <xsl:variable name="controlField008" select="marc:controlfield[@tag=008]"/>
Should this be happening?
Yes. Thanks for your watchfulness. 'leader' is used by MARC21 to DC XSL to display document type. It doesn't work this way for UNIMARC. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-19 08:23:33 UTC --- Cool, It all looks good then, signing off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5609|0 |1 is obsolete| | --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-19 08:23:54 UTC --- Created attachment 6863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6863 Bug 5565 UNIMARC to DC XSL tidy up Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #16 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-21 22:44:40 UTC --- XSLT and whitespace clean up only. Easy to read, marking Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Passed QA |Patch Pushed --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-27 17:34:20 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5565 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org