[Bug 36862] New: Cart window becomes unresponsive if checkboxes are manipulated in a certain order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 Bug ID: 36862 Summary: Cart window becomes unresponsive if checkboxes are manipulated in a certain order Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: jrobb@sekls.org QA Contact: testopia@bugs.koha-community.org The cart window in both the Staff Client and the OPAC becomes unresponsive as does the originating window if you check and uncheck boxes in the cart in a certain sequence. To replicate: - Search the catalog in the staff client and/or OPAC - Add 3 or more titles to the cart - Open the cart via the button in the top menu - Click "Select all" - Uncheck the first checkbox - Click "Clear all" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- I believe this is happening when the change event is triggered in cart.js. I don't understand why change() is being used here and I don't think it is necessary. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166788&action=edit Bug 36862: Remove jQuery change() event To test: 1 - Search the catalog in the staff client and/or OPAC 2 - Add 3 or more titles to the cart 3 - Open the cart via the button in the top menu 4 - Click "Select all" 5 - Uncheck the first checkbox 6 - Click "Clear all" 7 - APPLY PATCH, clear browser cache 8 - Try again, the browser should not crash. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- For me, the change works fine in the staff interface, but not in the OPAC. That is, still experience the described issue. Tested in Firefox Developer Edition and Chromium. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #3)
For me, the change works fine in the staff interface, but not in the OPAC. That is, still experience the described issue.
Tested in Firefox Developer Edition and Chromium.
Thanks David, I didn't do the OPAC. But I have a patch incoming. On the OPAC, when using #CheckAll or #CheckNone there is also a call to selRecord(). I don't see why we need to do so if all we are doing is checking/unchecking the checkboxes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 166840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166840&action=edit Bug 36862: Remove call to selRecord() on the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 --- Comment #6 from David Nind <david@davidnind.com> --- Thanks Lucas! Just to confirm that it now works as expected for the staff interface and OPAC. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Seems that we need the selRecord calls to update the list of items to be sent. I can now deselect items and still receive them with Send. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #7)
Seems that we need the selRecord calls to update the list of items to be sent. I can now deselect items and still receive them with Send.
Ah yes, I think this problem is actually coming from delRecord() which is called from within selRecord() -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #9 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I can replicate this problem in version 23.11 but not in 24.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 --- Comment #10 from David Nind <david@davidnind.com> --- Can confirm that this is still happening in the staff interface and OPAC on main. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org