[Bug 28976] New: In MARC21slimUtils.xsl param 'punctuation' is missing in 'chopPunctuation'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 Bug ID: 28976 Summary: In MARC21slimUtils.xsl param 'punctuation' is missing in 'chopPunctuation' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org In MARC21 XSLT files for display, many call on 'chopPunctuation' use param 'punctuation'. But this param is not used in MARC21slimUtils.xsl in 'chopPunctuation'. Strangely this param exists in MARC21slimUtils2.xsl. For example this removes ending dot in display of field 100 while 'punctuation' param contains ':,;/ ' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10265 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21303 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- This may be close to Bug 21303 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- See :
git grep '<xsl:with-param name="punctuation">' koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3-1.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS3.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2MODS32.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslimUtils.xsl:<xsl:with-param name="punctuation"> koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl: <xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslimUtils.xsl:<xsl:with-param name="punctuation"> koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl: <xsl:with-param name="punctuation">
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #3 from marion.durand@biblibre.com --- Created attachment 129524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129524&action=edit Bug 28976 : MARC21 Dots from field 100 are omitted in the OPAC and staff client When there is some dot in field 100 (for example when the name have an initials at the end) the dot is omitted in the OPAC ans the staff interface. To test: 1- Find or create a record with a dot in field 100 2a- From the staff interface, search the catalog for your record. Observe that the dot is omitted 2b- From the staff interface, go to the detail page of your record. Observe that the dot is omitted 2c- Repeat step 2a and 2b from the OPAC 3- Apply the patch 4- Repeat step 2. Observe that the dot is now display on all the pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #4 from marion.durand@biblibre.com --- Created attachment 129525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129525&action=edit retab MARC21slimUtils.xsl files replace tab with 4 spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 marion.durand@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |marion.durand@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30029 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- *** Bug 30029 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- This works as intended with the test plan. However, now when I view search results ( OPAC or staff client ) there is often two periods. I am using koha testing docker sample data. An example is this in the 100: Dina, Anca (ed.). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130529&action=edit example -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- @Lucas, thanks for testing. We need a MARC21 user here, could you continue on this patch ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32723 CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Anyone still working on this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28976 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Martin Renvoize from comment #9)
Anyone still working on this?
You can take if you want -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org