[Bug 25139] New: POS explodes in error when trying to display older transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 Bug ID: 25139 Summary: POS explodes in error when trying to display older transactions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Fines and fees Assignee: martin.renvoize@ptfs-europe.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When trying to display older transactions in the POS module, there is an error: Template process failed: undef error - The given date (12.04.2020) does not match the date format (iso) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 168. at /home/vagrant/kohaclone/C4/Templates.pm line 122 URL: http://localhost:8081/cgi-bin/koha/pos/register.pl?trange_f=07.04.2020&trange_t=12.04.2020®isterid=1 It looks like the dateformat is not handled correctly here. Dateformat is set to DD.MM.YYYY -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 102913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102913&action=edit Bug 25139: Corrections to date picker handling It would appear one has to format the dates in the controller rather than in the template for input fields.. I wasn't aware of this caveat until now. Test plan 1/ Prior to applying patch attempt to look at previous transactions ensuring you enter a 'to' date. 2/ Note a catastrophic failure 3/ Apply patch 4/ Look at the same date range and note you no longer get a failure but are instead faced with the requested transactions. 5/ Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102913|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 102924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102924&action=edit Bug 25139: Corrections to date picker handling It would appear one has to format the dates in the controller rather than in the template for input fields. I wasn't aware of this caveat until now. Test plan 0/ Enable cash register and POS system, add a register, items and some transactions. 1/ Prior to applying patch attempt to look at previous transactions ensuring you enter a 'to' date. 2/ Note a catastrophic failure 3/ Apply patch 4/ Look at the same date range and note you no longer get a failure but are instead faced with the requested transactions. 5/ Signoff Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102924|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102949&action=edit Bug 25139: Corrections to date picker handling It would appear one has to format the dates in the controller rather than in the template for input fields.. I wasn't aware of this caveat until now. Test plan 1/ Prior to applying patch attempt to look at previous transactions ensuring you enter a 'to' date. 2/ Note a catastrophic failure 3/ Apply patch 4/ Look at the same date range and note you no longer get a failure but are instead faced with the requested transactions. 5/ Signoff Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- does not apply to 19.11.x - not backported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25139 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org