[Bug 37409] New: Edit button for items in course reserves list doesn't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Bug ID: 37409 Summary: Edit button for items in course reserves list doesn't work Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: maxeinergl@gcc.edu QA Contact: testopia@bugs.koha-community.org In a course reserve list in the staff interface, the edit button on individual items in the list doesn't actually offer the ability to edit the item's reserve information. Instead, it goes back to the typical "Add Items" screen where the user can enter a barcode or biblionumber. Through clicks here you can get to a place to edit, but it is the same as if you click "Add reserves" on the course details and enter a barcode/biblionumber already on the list. I don't believe this is the expected behavior when clicking the Edit button. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |samalau@gmail.com Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 --- Comment #1 from Sam Lau <samalau@gmail.com> --- Created attachment 169791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169791&action=edit Bug 37409: Fix 'Edit' button for items in course reserves list To test: 1) Set the 'UseCourseReserves' sys pref to 'Use' 2) Go to the Course reserves page 3) Create a new course, fill in the required info and make sure the 'Enabled?' is checked 4) Add a reserve to this course 5) From the course details page, select edit on the reserve you just made. 6) Note it brings you back to the add reserves page, and you are required to enter the barcode/biblionumber again to edit 7) Apply patch, restart_all 8) Press the edit button again 9) Now you are directed towards the correct page for editing 10) Make some changes and press save 11) You should be redirected back to the details page and your changes have been made -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169791|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169792&action=edit Bug 37409: Fix 'Edit' button for items in course reserves list To test: 1) Set the 'UseCourseReserves' sys pref to 'Use' 2) Go to the Course reserves page 3) Create a new course, fill in the required info and make sure the 'Enabled?' is checked 4) Add a reserve to this course 5) From the course details page, select edit on the reserve you just made. 6) Note it brings you back to the add reserves page, and you are required to enter the barcode/biblionumber again to edit 7) Apply patch, restart_all 8) Press the edit button again 9) Now you are directed towards the correct page for editing 10) Make some changes and press save 11) You should be redirected back to the details page and your changes have been made Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169792|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 169990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169990&action=edit Bug 37409: Fix 'Edit' button for items in course reserves list To test: 1) Set the 'UseCourseReserves' sys pref to 'Use' 2) Go to the Course reserves page 3) Create a new course, fill in the required info and make sure the 'Enabled?' is checked 4) Add a reserve to this course 5) From the course details page, select edit on the reserve you just made. 6) Note it brings you back to the add reserves page, and you are required to enter the barcode/biblionumber again to edit 7) Apply patch, restart_all 8) Press the edit button again 9) Now you are directed towards the correct page for editing 10) Make some changes and press save 11) You should be redirected back to the details page and your changes have been made Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Seems that changing action to lookup should be enough? You also change itemnumber to barcode. But should work too (normally).. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4)
Seems that changing action to lookup should be enough? You also change itemnumber to barcode. But should work too (normally)..
Sorry read op=lookup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #5)
(In reply to Marcel de Rooy from comment #4)
Seems that changing action to lookup should be enough? You also change itemnumber to barcode. But should work too (normally)..
Sorry read op=lookup
Hm, this could cause a regression if a barcode was to be removed from an item in a course reserve. Any reason to not keep the itemnumber? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 --- Comment #7 from Sam Lau <samalau@gmail.com> --- Good point, my bad -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169990|0 |1 is obsolete| | --- Comment #8 from Sam Lau <samalau@gmail.com> --- Created attachment 170007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170007&action=edit Bug 37409: Fix 'Edit' button for items in course reserves list To test: 1) Set the 'UseCourseReserves' sys pref to 'Use' 2) Go to the Course reserves page 3) Create a new course, fill in the required info and make sure the 'Enabled?' is checked 4) Add a reserve to this course 5) From the course details page, select edit on the reserve you just made. 6) Note it brings you back to the add reserves page, and you are required to enter the barcode/biblionumber again to edit 7) Apply patch, restart_all 8) Press the edit button again 9) Now you are directed towards the correct page for editing 10) Make some changes and press save 11) You should be redirected back to the details page and your changes have been made -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170007|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 170025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170025&action=edit Bug 37409: Fix 'Edit' button for items in course reserves list To test: 1) Set the 'UseCourseReserves' sys pref to 'Use' 2) Go to the Course reserves page 3) Create a new course, fill in the required info and make sure the 'Enabled?' is checked 4) Add a reserve to this course 5) From the course details page, select edit on the reserve you just made. 6) Note it brings you back to the add reserves page, and you are required to enter the barcode/biblionumber again to edit 7) Apply patch, restart_all 8) Press the edit button again 9) Now you are directed towards the correct page for editing 10) Make some changes and press save 11) You should be redirected back to the details page and your changes have been made Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Depends on| |36192 Text to go in the| |This fixes editing existing release notes| |reserves for a course (when | |using course reserves). | |Editing a reserve was | |opening the add reserve | |form, instead of letting | |you edit the exist reserve. | |(This is related to the | |CSRF changes added in Koha | |24.05 to improve form | |security.) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 [Bug 36192] [OMNIBUS] CSRF Protection for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes editing existing |This fixes editing existing release notes|reserves for a course (when |reserves for a course (when |using course reserves). |using course reserves). |Editing a reserve was |Editing a reserve was |opening the add reserve |opening the add reserve |form, instead of letting |form, instead of letting |you edit the exist reserve. |you edit the existing |(This is related to the |reserve. (This is related |CSRF changes added in Koha |to the CSRF changes added |24.05 to improve form |in Koha 24.05 to improve |security.) |form security.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170025|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 170435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170435&action=edit Bug 37409: Fix 'Edit' button for items in course reserves list To test: 1) Set the 'UseCourseReserves' sys pref to 'Use' 2) Go to the Course reserves page 3) Create a new course, fill in the required info and make sure the 'Enabled?' is checked 4) Add a reserve to this course 5) From the course details page, select edit on the reserve you just made. 6) Note it brings you back to the add reserves page, and you are required to enter the barcode/biblionumber again to edit 7) Apply patch, restart_all 8) Press the edit button again 9) Now you are directed towards the correct page for editing 10) Make some changes and press save 11) You should be redirected back to the details page and your changes have been made Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.04 released in| | CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not for 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from David Nind <david@davidnind.com> --- Fixes something not working - no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37409 Bug 37409 depends on bug 36192, which changed state. Bug 36192 Summary: [OMNIBUS] CSRF Protection for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36192 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org