[Bug 36996] New: Add a system preference to determine Z3950 availability
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Bug ID: 36996 Summary: Add a system preference to determine Z3950 availability Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Some libraries would like to use additional item fields for determining if an item is available when showing z3950 results. This bug is to add a new system preference to determine availability (yes|no) via a YAML system preference - similar to OPacHiddenItems -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 167285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167285&action=edit Bug 36996: Add z3950Status system preference This bug adds a new system preference 'z3950Status' which takes a yaml block and marks any items matching the conditions as unavailable via z3950 results It obeys the existing z3950 extra fields, adding item ststus to field $k To test: 0 - Apply patch, update database 1 - Setup your koha to use itself as a z39 source in Administration/Z3950/SRU servers: host: localhost port 2100 database: biblios syntax: MARC21 (or UNIMARC if applicable) 2 - Uncomment the config line in /etc/koha/sites/kohadev/z3950/config.xml Also make sure to remove the backslashes escaping the hyphens 3 - Restart all 4 - Cataloging - New from Z3950 5 - Search your records, view the marc to confirm status subfield $k is included 6 - Add items to a record with various statuses (lost,damaged,withdrawn) and itemtypes 7 - Edit syspref AdditionalFieldsInZ3950ResultSearch o add 952$k 8 - Search for record above - confirm statuses show as expected 9 - Edit new syspref Z3950Status itype: [BK] ccode: [REF] 10 - Search z39 again and confirm items and collection codes are marked 'SYSPREF' in $k 11 - Edit Authorized values - add category Z3950_STATUS 12 - Add authorized vlaue: SYSPREF with Description: System preferenced 13 - Restart all 14 - Search z39 again and confirm statuses show new description TODO: Unit tests Fix documentation/link in sysprefs - edit wiki page to include both prefs? Should this be in the manual? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- OpacHiddenItems gives me nightmares. Are we sure that we want to add more things like it? Shouldn't OpacHiddenItems already cover off this scenario? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #2)
OpacHiddenItems gives me nightmares. Are we sure that we want to add more things like it?
Shouldn't OpacHiddenItems already cover off this scenario?
I think this is a different thing. They don't want to hide the items, they want a simplified version of availability and Nick just meant "a yaml preference". Koha uses several fields and attributes to determine availability (damaged, restricted, notforloan...) and not all systems are happy to deal with that. But I wonder about the functionality that was built into the z39.50 responder - didn't that have a similar goal? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #3)
(In reply to David Cook from comment #2) I think this is a different thing. They don't want to hide the items, they want a simplified version of availability and Nick just meant "a yaml preference".
Exactly, I just meant using the same structure for defining the rules
Koha uses several fields and attributes to determine availability (damaged, restricted, notforloan...) and not all systems are happy to deal with that.
But I wonder about the functionality that was built into the z39.50 responder - didn't that have a similar goal?
This extends that functionality - currently it checks the various statuses - if none are found then the item is available. This adds a new check, based on a system preference, that will add a status of 'SYSPREF' to the list If no statuses are found, then we pass a single 'AVAILABLE' status If other statuses are found, they can either be sent as a single field, with all statuses concatenated, or multiple fields, one per status -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- *** Bug 28981 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a system preference to |Add a system preference to |determine Z3950 |mark items unavailable in |availability |z9350 responder -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167285|0 |1 is obsolete| | --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 167864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167864&action=edit Bug 36996: Add z3950Status system preference This bug adds a new system preference 'z3950Status' which takes a yaml block and marks any items matching the conditions as unavailable via z3950 results It obeys the existing z3950 extra fields, adding item ststus to field $k To test: 0 - Apply patch, update database 1 - Setup your koha to use itself as a z39 source in Administration/Z3950/SRU servers: host: localhost port 2100 database: biblios syntax: MARC21 (or UNIMARC if applicable) 2 - Uncomment the config line in /etc/koha/sites/kohadev/z3950/config.xml Also make sure to remove the backslashes escaping the hyphens 3 - Restart all 4 - Cataloging - New from Z3950 5 - Search your records, view the marc to confirm status subfield $k is included 6 - Add items to a record with various statuses (lost,damaged,withdrawn) and itemtypes 7 - Edit syspref AdditionalFieldsInZ3950ResultSearch o add 952$k 8 - Search for record above - confirm statuses show as expected 9 - Edit new syspref z3950Status - confirm the language of the pref makes sense itype: [BK] ccode: [REF] 10 - Search z39 again and confirm items and collection codes are marked 'SYSPREF' in $k 11 - Edit Authorized values - add category Z3950_STATUS 12 - Add authorized vlaue: SYSPREF with Description: System preferenced 13 - Restart all 14 - Search z39 again and confirm statuses show new description Sponsored by: Northeast Kansas Library System <https://www.nekls.org> Sponsored by: South East Kansas Library System <https://www.sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167864|0 |1 is obsolete| | --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 167943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167943&action=edit Bug 36996: Add z3950Status system preference This bug adds a new system preference 'z3950Status' which takes a yaml block and marks any items matching the conditions as unavailable via z3950 results It obeys the existing z3950 extra fields, adding item ststus to field $k To test: 0 - Apply patch, update database 1 - Setup your koha to use itself as a z39 source in Administration/Z3950/SRU servers: host: localhost port 2100 database: biblios syntax: MARC21 (or UNIMARC if applicable) 2 - Uncomment the config line in /etc/koha/sites/kohadev/z3950/config.xml Also make sure to remove the backslashes escaping the hyphens 3 - Restart all 4 - Cataloging - New from Z3950 5 - Search your records, view the marc to confirm status subfield $k is included 6 - Add items to a record with various statuses (lost,damaged,withdrawn) and itemtypes 7 - Edit syspref AdditionalFieldsInZ3950ResultSearch o add 952$k 8 - Search for record above - confirm statuses show as expected 9 - Edit new syspref z3950Status - confirm the language of the pref makes sense itype: [BK] ccode: [REF] 10 - Search z39 again and confirm items and collection codes are marked 'SYSPREF' in $k 11 - Edit Authorized values - add category Z3950_STATUS 12 - Add authorized vlaue: SYSPREF with Description: System preferenced 13 - Restart all 14 - Search z39 again and confirm statuses show new description Sponsored by: Northeast Kansas Library System <https://www.nekls.org> Sponsored by: South East Kansas Library System <https://www.sekls.org> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 --- Comment #8 from Phil Ringnalda <phil@chetcolibrary.org> --- Though were I doing QA, I would probably object to how overly general the AV name "SYSPREF" is, and I'd want to scope-creep like crazy, wanting to set multiple statuses and to have them in a ranked order where the highest one wins, so if itype REF sets "Available for local use" and loc REPAIR sets "In repair" the net result is "In repair" rather than the untrue "Available for local use", "In repair". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 --- Comment #9 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- (In reply to Phil Ringnalda from comment #8)
Though were I doing QA, I would probably object to how overly general the AV name "SYSPREF" is, and I'd want to scope-creep like crazy, wanting to set multiple statuses and to have them in a ranked order where the highest one wins, so if itype REF sets "Available for local use" and loc REPAIR sets "In repair" the net result is "In repair" rather than the untrue "Available for local use", "In repair".
I do like this idea, I think it is a great extension of the feature and will file a bug for it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37230 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37230 [Bug 37230] Add ability to define arbitrary statuses for items in Z3950 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167943|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169193&action=edit Bug 36996: Add z3950Status system preference This bug adds a new system preference 'z3950Status' which takes a yaml block and marks any items matching the conditions as unavailable via z3950 results It obeys the existing z3950 extra fields, adding item ststus to field $k To test: 0 - Apply patch, update database 1 - Setup your koha to use itself as a z39 source in Administration/Z3950/SRU servers: host: localhost port 2100 database: biblios syntax: MARC21 (or UNIMARC if applicable) 2 - Uncomment the config line in /etc/koha/sites/kohadev/z3950/config.xml Also make sure to remove the backslashes escaping the hyphens 3 - Restart all 4 - Cataloging - New from Z3950 5 - Search your records, view the marc to confirm status subfield $k is included 6 - Add items to a record with various statuses (lost,damaged,withdrawn) and itemtypes 7 - Edit syspref AdditionalFieldsInZ3950ResultSearch o add 952$k 8 - Search for record above - confirm statuses show as expected 9 - Edit new syspref z3950Status - confirm the language of the pref makes sense itype: [BK] ccode: [REF] 10 - Search z39 again and confirm items and collection codes are marked 'SYSPREF' in $k 11 - Edit Authorized values - add category Z3950_STATUS 12 - Add authorized vlaue: SYSPREF with Description: System preferenced 13 - Restart all 14 - Search z39 again and confirm statuses show new description Sponsored by: Northeast Kansas Library System <https://www.nekls.org> Sponsored by: South East Kansas Library System <https://www.sekls.org> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 169194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169194&action=edit Bug 36996: (QA follow-up) Fix number of unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Needs documenting --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be included in 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Summary|Add a system preference to |Add a system preference to |mark items unavailable in |mark items unavailable in |z9350 responder |Z39.50 responder Text to go in the| |This adds a new system release notes| |preference `z3950Status` | |which takes a YAML block | |and marks any items | |matching the conditions as | |unavailable in Z39.50 | |results | |It obeys the | |existing | |`AdditionalFieldsInZ3950Res | |ultSearch` system | |preference settings, adding | |item status to field 952 | |$k. --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- @Kyle, @Nick: Please verify my release notes are correct! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation|Aude Charillon | contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36996 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1108 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org