[Bug 32622] New: Auth.t failing on D8
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Bug ID: 32622 Summary: Auth.t failing on D8 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Caught by Jenkins 15:08:08 koha_1 | # Failed test 'While still logged in, relogin with another user' 15:08:08 koha_1 | # at t/db_dependent/Auth.t line 219. 15:08:08 koha_1 | # Looks like you planned 7 tests but ran 6. 15:08:08 koha_1 | # Looks like you failed 1 test of 6 run. 15:08:08 koha_1 | 15:08:08 koha_1 | # Failed test 'checkauth() tests' 15:08:08 koha_1 | # at t/db_dependent/Auth.t line 331. 15:08:08 koha_1 | Can't locate object method "mock" via package "0" (perhaps you forgot to load "0"?) at t/db_dependent/Auth.t line 176. The code is: t/db_dependent/Auth.t 175 my $mock2 = Test::MockModule->new('CGI') ->mock( 'request_method', 'POST' ) 176 ->mock( 'cookie', sub { return $sessionID; } ); # oversimplified.. It's caused by a version mismatch of Test::MockModule with D8, which does not have this commit: https://github.com/geofffranks/test-mockmodule/commit/fef9e742e45e2437e3449e... We could remove the chaining, or... deactivate D8 builds, which should have been already done actually :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Auth.t failing on D8 |Auth.t failing on D10 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hey, it's D10, sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31908 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145262&action=edit Bug 32622: Fix Auth.t on D10 It's caused by a version mismatch of Test::MockModule with D10, which does not have this commit: https://github.com/geofffranks/test-mockmodule/commit/fef9e742e45e2437e3449e... We should remove the chaining here. Test plan: Confirm that Auth.t still pass, and is fixed on D10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work Joubu! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145262|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145270&action=edit Bug 32622: Fix Auth.t on D10 It's caused by a version mismatch of Test::MockModule with D10, which does not have this commit: https://github.com/geofffranks/test-mockmodule/commit/fef9e742e45e2437e3449e... We should remove the chaining here. Test plan: Confirm that Auth.t still pass, and is fixed on D10 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works perfectly, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable Version(s)| |22.11.02 released in| | CC| |jacob.omara@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm a Muppet.. I forgot to update bugzilla that this is in master too... 😀 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.02 |23.05.00, 22.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|23.05.00, 22.11.02 |23.05.00, 22.11.02, released in| |22.05.09 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00, 22.11.02, |23.05.00, 22.11.02, released in|22.05.09 |22.05.09, 21.11.16 CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- pushed to 21.11.x for 21.11.16 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32622 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org