[Bug 8283] New: Replace usage of YUI Cookie utility with jQuery Cookie plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Priority: P5 - low Change sponsored?: --- Bug ID: 8283 Assignee: oleonard@myacpl.org Summary: Replace usage of YUI Cookie utility with jQuery Cookie plugin Severity: enhancement Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: NEW Version: master Component: Templates Product: Koha Since we're eliminating usage of YUI, we should convert JavaScript which uses the YUI Cookie utility for reading and setting cookies. We already use a jQuery Cookie plugin elsewhere in Koha (although it is independent of jQueryUI), so it seems logical to unify cookie management under it. The only affected script is js/pages/batchMod.js -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 10439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10439&action=edit Bug 8283 - Replace usage of YUI Cookie utility with jQuery Cookie plugin Switching from YUI Cookie utility to jQuery Cookie plugin. The jQuery Cookie plugin is already used elsewhere in Koha, so no new dependencies are added. The YUI Cookie files are removed. To test, go to batch item deletion and/or batch item modification and submit a set of barcodes. On the confirmation screen select or deselect columns to show. Start over and submit your barcodes again. The confirmation screen should remember which columns you previously selected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10439|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 10583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10583&action=edit Bug 8283 - Replace usage of YUI Cookie utility with jQuery Cookie plugin Switching from YUI Cookie utility to jQuery Cookie plugin. The jQuery Cookie plugin is already used elsewhere in Koha, so no new dependencies are added. The YUI Cookie files are removed. To test, go to batch item deletion and/or batch item modification and submit a set of barcodes. On the confirmation screen select or deselect columns to show. Start over and submit your barcodes again. The confirmation screen should remember which columns you previously selected. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Works fine -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Qa comments: I love this kind of patch : 12 insertions(+), 998 deletions(-) for the same job ! :) Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: There are still references to cookie-min.js in: koha-tmpl/intranet-tmpl/prog/en/lib/yui/utilities/utilities.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/yuiloader/yuiloader.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/yuiloader/yuiloader-debug.js I think it's normal, as it's related to yui, but before pushing, owen could you confirm please ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #5)
QA comment: There are still references to cookie-min.js
I saw that too. The yuiloader files are unused by Koha, so those references are irrelevant. utilities.js is used by Koha, but the reference to cookie-min.js comes in a sequence which references many YUI files which Koha doesn't use, so it looks safe to me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed now. Please report any problem. I'll add this topic to my monthly Newsletter -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org