[Bug 26172] New: Add a cashup summary view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Bug ID: 26172 Summary: Add a cashup summary view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 24820 Blocks: 13985 Bug 23355 adds a process for recording cash register cashups; however it does not expose the captured cashup data, leaving that to the end user via reports. This bug serves as a request for enhancement to add a way to display a quick summary of the transactions that have make up a cashup set. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820 [Bug 24820] The cashup workflow should use the static 'date' field rather than the transient 'timestamp' field in accountlines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24820 |24492 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492 [Bug 24492] Add a 'library cashup' workflow to the point of sale system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24820 [Bug 24820] The cashup workflow should use the static 'date' field rather than the transient 'timestamp' field in accountlines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108093&action=edit Bug 26172: Add cashup summary view modal This patch adds a cashup summary modal to the register details page. Test plan 1/ Enable Cash Registers and Point of Sale 2/ Enable some debit_types as 'Sale items' 3/ Perform a series of transactions 4/ Perform a 'Cashup' on the register 5/ Note the new '(Summary)' link next to the last cashup on the register page. 6/ Click the link and confirm the modal contains the pertinent information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Initial proof of concept patch attached.. it would be good to get some early feedback whilst I write tests for the existing code and refine the finer details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108093|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108095&action=edit Bug 26172: Add cashup summary view modal This patch adds a cashup summary modal to the register details page. Test plan 1/ Enable Cash Registers and Point of Sale 2/ Enable some debit_types as 'Sale items' 3/ Perform a series of transactions 4/ Perform a 'Cashup' on the register 5/ Note the new '(Summary)' link next to the last cashup on the register page. 6/ Click the link and confirm the modal contains the pertinent information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #4 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Hi Martin, thanks for writing this! When I confirmed the cashup: cgi-bin/koha/pos/register.pl?op=cashup I received the following error: Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): 'koha_testing1.debit_type_code.description' isn't in GROUP BY at /kohadevbox/koha/Koha/Objects.pm line 413 at /kohadevbox/koha/C4/Templates.pm line 122 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108095|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108523&action=edit Bug 26172: Add cashup summary view modal This patch adds a cashup summary modal to the register details page. Test plan 1/ Enable Cash Registers and Point of Sale 2/ Enable some debit_types as 'Sale items' 3/ Perform a series of transactions 4/ Perform a 'Cashup' on the register 5/ Note the new '(Summary)' link next to the last cashup on the register page. 6/ Click the link and confirm the modal contains the pertinent information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've fixed the issue you highlighted now Sally, thanks for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #7 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Martin Renvoize from comment #2)
Initial proof of concept patch attached.. it would be good to get some early feedback whilst I write tests for the existing code and refine the finer details.
This looks great, Martin - really really useful. It's in a really logical location to retrieve, and it's great that the summary contains both the register name and cashing up period. The table is really clear, and the split between the 'Total' takings and the 'Bankable' physical cash is really useful. Having had a test with it, there's two things that would be useful: 1) Could a button be added to send the contents of the modal to the printer? Highlighting it and then choosing Print Selection achieves this (obviously), but it would be great to make that easier for those librarians who are less confident with computers. 2) From the Total and the Bankable, it's possible to calculate the payments which has already been reconciled (Banked?) - but could this total also be displayed to save any math errors by the librarians? I know Martin knows our system very well but to explain for others reading this, we currently have a custom cash module and all transactions processed through the till are listed under 'Total'. This is then split into payment types - e.g. Cash, Card, Cheque. This is because we submit these differently to our accounting department, so the cash up summary looks like this: Total: 57.00 Card: 37.00 Cash: 11.00 Cheque: 9.00 With the current modal, it would be useful if we could see the payment breakdown (like above), or an 'Banked' total listed, e.g. Total: 57.00 Banked: 37.00 Bankable: 20.00 So Total is all takings, Banked is credit/debit card payments that have already been reconciled, Bankable is cash/cheque which needs to be taken from the till and deposited in the bank. But yeah, it works brilliantly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108523|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108817&action=edit Bug 26172: Add cashup summary view modal This patch adds a cashup summary modal to the register details page. Test plan 1/ Enable Cash Registers and Point of Sale 2/ Enable some debit_types as 'Sale items' 3/ Perform a series of transactions 4/ Perform a 'Cashup' on the register 5/ Note the new '(Summary)' link next to the last cashup on the register page. 6/ Click the link and confirm the modal contains the pertinent information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108818&action=edit Bug 26172: (follow-up) Summary by payment_type This patch alters the modal so that the totals are broken down by payment type's available on the system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Sally from comment #7)
1) Could a button be added to send the contents of the modal to the printer? Highlighting it and then choosing Print Selection achieves this (obviously), but it would be great to make that easier for those librarians who are less confident with computers.
I'm still working on this one.
2) From the Total and the Bankable, it's possible to calculate the payments which has already been reconciled (Banked?) - but could this total also be displayed to save any math errors by the librarians?
I know Martin knows our system very well but to explain for others reading this, we currently have a custom cash module and all transactions processed through the till are listed under 'Total'. This is then split into payment types - e.g. Cash, Card, Cheque. This is because we submit these differently to our accounting department, so the cash up summary looks like this:
Total: 57.00 Card: 37.00 Cash: 11.00 Cheque: 9.00
With the current modal, it would be useful if we could see the payment breakdown (like above), or an 'Banked' total listed, e.g.
Total: 57.00 Banked: 37.00 Bankable: 20.00
So Total is all takings, Banked is credit/debit card payments that have already been reconciled, Bankable is cash/cheque which needs to be taken from the till and deposited in the bank.
But yeah, it works brilliantly.
Thanks for the feedback Sally :) I can easily implement the former approach, summarising totals by their payment types, and have attached a followup patch to achieve this. The latter format of Banked/Bankable is proving more allusive as it would require some additional handling within the definition of payments types such that we could easily identify types that are 'automatically banked' vs those that require the librarian to collect from the till at the end of the day. It seems obvious on first look, but I wonder for example in the cases where libraries take foodbank donations in lue of payments for example if that would be 'automatically banked' in so much as it immediately gets moved into a shared pile of foodbank goods vs being kept under the till to be checked at the end of the day. As such I think the later approach lends itself to requiring the payment_types authorized value being merged with credit_types first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108822&action=edit Bug 26172: (follow-up) Add print option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26272 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 [Bug 26272] Allow cashup summaries to be displayed from the library summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26274 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26274 [Bug 26274] Expose cash register cashup summaries via an API route. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26272 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 [Bug 26272] Allow cashup summaries to be displayed from the library summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108817|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108825&action=edit Bug 26172: Add cashup summary view modal This patch adds a cashup summary modal to the register details page. Test plan 1/ Enable Cash Registers and Point of Sale 2/ Enable some debit_types as 'Sale items' 3/ Perform a series of transactions 4/ Perform a 'Cashup' on the register 5/ Note the new '(Summary)' link next to the last cashup on the register page. 6/ Click the link and confirm the modal contains the pertinent information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108818|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108826&action=edit Bug 26172: (follow-up) Summary by payment_type This patch alters the modal so that the totals are broken down by payment type's available on the system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108822|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 108827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108827&action=edit Bug 26172: (follow-up) Add print option -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tech@salinapublic.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Added Eric as a CC here as they expressed interest in the 'End of Day' functionality which this enhances. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108825|0 |1 is obsolete| | --- Comment #16 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 111162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111162&action=edit Bug 26172: Add cashup summary view modal This patch adds a cashup summary modal to the register details page. Test plan 1/ Enable Cash Registers and Point of Sale 2/ Enable some debit_types as 'Sale items' 3/ Perform a series of transactions 4/ Perform a 'Cashup' on the register 5/ Note the new '(Summary)' link next to the last cashup on the register page. 6/ Click the link and confirm the modal contains the pertinent information Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108826|0 |1 is obsolete| | --- Comment #17 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 111163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111163&action=edit Bug 26172: (follow-up) Summary by payment_type This patch alters the modal so that the totals are broken down by payment type's available on the system. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108827|0 |1 is obsolete| | --- Comment #18 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 111164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111164&action=edit Bug 26172: (follow-up) Add print option Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #19 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Martin Renvoize from comment #10)
I can easily implement the former approach, summarising totals by their payment types, and have attached a followup patch to achieve this.
Fantastic, that definitely meets our requirements. :) I added a couple of payment types and had a test, and all worked well. Thanks for implementing the print button, that's really useful. It'd be great if it could just send the contents of the modal to the printer (currently it sends the rest of the page as well) - but I don't feel it's a blocker, so I've signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for testing Sally, I'm really happy it's working for you. On the print front, can I ask what browser you tested with and whether you ran the CSS build option on the sandbox? The code is intended to hide the background and only print the modal content so if you weren't seeing that I may still have a bug there. I'll investigate and can work through it with whoever picks this up for QA if it's not working as expected. Thanks again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #21 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- (In reply to Martin Renvoize from comment #20)
Thanks for testing Sally, I'm really happy it's working for you.
On the print front, can I ask what browser you tested with and whether you ran the CSS build option on the sandbox? The code is intended to hide the background and only print the modal content so if you weren't seeing that I may still have a bug there. I'll investigate and can work through it with whoever picks this up for QA if it's not working as expected.
Thanks again
Argh, my mistake - I didn't run build CSS. I shouldn't have been rushing to get it tested on Friday! I've re-tested, and can confirm that it works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111162|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111598&action=edit Bug 26172: Add cashup summary view modal This patch adds a cashup summary modal to the register details page. Test plan 1/ Enable Cash Registers and Point of Sale 2/ Enable some debit_types as 'Sale items' 3/ Perform a series of transactions 4/ Perform a 'Cashup' on the register 5/ Note the new '(Summary)' link next to the last cashup on the register page. 6/ Click the link and confirm the modal contains the pertinent information Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111163|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111599&action=edit Bug 26172: (follow-up) Summary by payment_type This patch alters the modal so that the totals are broken down by payment type's available on the system. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111164|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111600&action=edit Bug 26172: (follow-up) Add print option Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111601&action=edit Bug 26172: (QA follow-up) Add missing filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, failing this for the missing unit tests, but already adding my QA stamp on the other patches. 2 things: - When doing the cash-up action from the tools page, after the cash-up the summary link for printing doesn't display. It only displays on the 'register details'. I will file a separate bug for this as a later improvement. - I think it would be pretty great to have a way to see the 'recorded' cashups with summary links for each to allow libraries to get more of an overview of cashups, the amounts taken - this would be helpful when something has gone wrong but also to see if processes could be improved. I'll link both to this one as see alsos. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26676 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a cashup summary view |Add a cashup summary view | |(with option to print) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26677 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26677 [Bug 26677] Make summary view and print option for cashups visible on more pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26677 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26677 [Bug 26677] Make summary view and print option for cashups visible on more pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111598|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111629&action=edit Bug 26172: Add cashup summary view modal This patch adds a cashup summary modal to the register details page. Test plan 1/ Enable Cash Registers and Point of Sale 2/ Enable some debit_types as 'Sale items' 3/ Perform a series of transactions 4/ Perform a 'Cashup' on the register 5/ Note the new '(Summary)' link next to the last cashup on the register page. 6/ Click the link and confirm the modal contains the pertinent information Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111599|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111630&action=edit Bug 26172: (follow-up) Summary by payment_type This patch alters the modal so that the totals are broken down by payment type's available on the system. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111600|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111631&action=edit Bug 26172: (follow-up) Add print option Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111601|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111632&action=edit Bug 26172: (QA follow-up) Add missing filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111633&action=edit Bug 26172: (QA follow-up) Fix order of summary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111634&action=edit Bug 26172: (QA follow-up) Add Unit Test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Unit tests added, leaving to Katrin for the final QA Stamp :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111634|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111668&action=edit Bug 26172: (QA follow-up) Add Unit Test Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The new tests pass, but the QA script fails: FAIL t/db_dependent/Koha/Cash/Register/Action.t OK critic FAIL file permissions File must have the exec flag FAIL forbidden patterns forbidden pattern: Do not use compare float with precision (bug 24408). Ignore this if you know what you are doing. (line 197) forbidden pattern: Do not use compare float with precision (bug 24408). Ignore this if you know what you are doing. (line 207) Can you assure me you know what you are doing or make it go away? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111668|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111683&action=edit Bug 26172: (QA follow-up) Add Unit Test Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Grr, How did I forget to run the QA script against this! I've corrected the file permission issue. As for the float comparison I will defer to Jonathan.. really I should be doing the +0 trick somewhere, but as this is within an 'is_deeply' comparison, I'm not actually sure where I can place it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111691&action=edit Bug 26172: Fix return value for ->register There is a ON CASCADE DELETE clause on this FK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #38)
Created attachment 111691 [details] [review] Bug 26172: Fix return value for ->register
There is a ON DELETE CASCADE clause on this FK
Martin, there is the same problem for ->manager (not coming from this patchset). It must be fixed separately. Actually I think the code is code, but the ON DELETE CASCADE should be SET NULL instead for this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111691|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 111692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111692&action=edit Bug 26172: Fix return value for ->register There is a ON DELETE CASCADE clause on this FK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. Tests must cover the "$previous" case (that is never set). 2. Then the code may call something like my ($timestamp) = ->search->get_column('timestamp'); to avoid the single and _result calls. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111731&action=edit Bug 26175: (QA follow-up) Add tests for previous cashups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111732&action=edit Bug 26172: (QA follow-up) Add tests for previous cashups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111731|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26690 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26690 [Bug 26690] Constraints for cash management tables need reconsidering -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 112907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112907&action=edit Bug 26172: Replace calls to _result[set] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112907|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 112908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112908&action=edit Bug 26172: Replace _result[set] calls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112908|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 112909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112909&action=edit Bug 26172: Replace _result[set] calls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #46)
Created attachment 112909 [details] [review] Bug 26172: Replace _result[set] calls
Martin, do you agree with this change? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Seems reasonable to me.. I'm going to run the test with dbic_trace enabled to double check the db calls we make.. it feels like we might have introduced a couple of extra one's this way. Having said that.. I'm not sure how a correlate subquery performs compared to a pair of independent queries anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So.. I've tested my hypothesis and your version does indeed result in 2 additional DB calls (the subselect being executed independently).. However, it does not change performance in any meaningful way (I benchamarked it).. So.. for consistency and to be more Koha::Object like, not having to reach inside dbic guts to much I would take your approach. Thanks for the followup :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 [Bug 26938] Prevent flash of unstyled content on sales table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26172 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #51 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org