[Bug 23218] New: Batch patron modification empty attribute causes improper handling of values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Bug ID: 23218 Summary: Batch patron modification empty attribute causes improper handling of values Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 introduced an empty option for Attribute in the Batch Patron Modification. If you leave "Attribute" empty and click "New", you'll get a new row where you can choose an attribute and specify a value. When you hit save, the value won't be recorded against the attribute though, because the indexes in the patron_attributes and patron_attributes_value arrays will be out of sync. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19673 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19673 [Bug 19673] Patron batch modification tool cannot use authorised value "0" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 91130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91130&action=edit Bug 23218: Fix shift in patron's attributes in batch patron modification When the "new" button is clicked without selecting a patron's attribute, the update will have unexpected behaviors. There is indeed a difference in the number of patron's attributes and the number of values. Test plan: Go to the batch patron modification Enter a cardnumber At the bottom of the page, click "new" without selecting an attribute On the second line select one, and a value (different than an empty string) Save => The attribute will be updated with an empty string -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|18.11 |unspecified Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I'll be looking at signing off this one when I'm back at the office as well. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91130|0 |1 is obsolete| | --- Comment #3 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 91373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91373&action=edit Bug 23218: Fix shift in patron's attributes in batch patron modification When the "new" button is clicked without selecting a patron's attribute, the update will have unexpected behaviors. There is indeed a difference in the number of patron's attributes and the number of values. Test plan: Go to the batch patron modification Enter a cardnumber At the bottom of the page, click "new" without selecting an attribute On the second line select one, and a value (different than an empty string) Save => The attribute will be updated with an empty string Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- value="poeut" ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #4)
value="poeut" ?
That does look pretty weird... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91373|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91629&action=edit Bug 23218: Fix shift in patron's attributes in batch patron modification When the "new" button is clicked without selecting a patron's attribute, the update will have unexpected behaviors. There is indeed a difference in the number of patron's attributes and the number of values. Test plan: Go to the batch patron modification Enter a cardnumber At the bottom of the page, click "new" without selecting an attribute On the second line select one, and a value (different than an empty string) Save => The attribute will be updated with an empty string Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91630&action=edit Bug 23218: (QA follow-up) Remove dummy value Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Cook from comment #5)
(In reply to Katrin Fischer from comment #4)
value="poeut" ?
That does look pretty weird...
It works with out this, so removed the extra value - it wasn't added if the dropdown was changed so I assume leftover testing code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #8)
(In reply to David Cook from comment #5)
(In reply to Katrin Fischer from comment #4)
value="poeut" ?
That does look pretty weird...
It works with out this, so removed the extra value - it wasn't added if the dropdown was changed so I assume leftover testing code
Thanks, sorry for that. poeut is weird indeed, it's a typo for pouet ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23218 Abdivasiyev Sunnatillo <abdivasiyevsunnatillo2008@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abdivasiyevsunnatillo2008@g | |mail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org