https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Summary|OPACSuggestionAutoFill must |Invalid check fo |be 1 or 0 |OPACSuggestionAutoFill on | |opac-suggestions.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cjf@wmu.se, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

SELECT value FROM systempreferences WHERE variable='OPACSuggestionAutoFill'; => FAIL: It is either 'yes' or 'no' depending on what you choose.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138476|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 138488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138488&action=edit Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere The YAML preference definition defines it as a string ('yes' or 'no' the possible values). And the opac-suggestions.tt template has one occurence of the variable being compared to a string. This patch does: - fix the template - fixes opac.pref for 0|1 - adds an atomicupdate that takes care of moving 'yes' and 'no' to their respective boolean values. To test: 1. Change the syspref value to enable/disable 2. Check on the DB that the value is wrong: $ koha-mysql kohadev 3. Apply this patch 4. Run: $ updatedatabase 5. Repeat 2 => SUCCESS: Values are now 0 or 1 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

SELECT value FROM systempreferences WHERE variable='OPACSuggestionAutoFill'; => FAIL: It is either 'yes' or 'no' depending on what you choose.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138488|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138492&action=edit Bug 31274: Make sure OPACSuggestionAutoFill is handled as a boolean everywhere The YAML preference definition defines it as a string ('yes' or 'no' the possible values). And the opac-suggestions.tt template has one occurence of the variable being compared to a string. This patch does: - fix the template - fixes opac.pref for 0|1 - adds an atomicupdate that takes care of moving 'yes' and 'no' to their respective boolean values. To test: 1. Change the syspref value to enable/disable 2. Check on the DB that the value is wrong: $ koha-mysql kohadev 3. Apply this patch 4. Run: $ updatedatabase 5. Repeat 2 => SUCCESS: Values are now 0 or 1 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31274 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Bug14242 not being present in 21.11.x, there is no reason to backport that one. Won't backport unless specifically asked to. -- You are receiving this mail because: You are watching all bug changes.