[Bug 20555] New: usage() function in cleanup_database.pl needs refactoring
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20555 Bug ID: 20555 Summary: usage() function in cleanup_database.pl needs refactoring Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Developer documentation Assignee: koha-bugs@lists.koha-community.org Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org 1) '-m --mail DAYS' is misleading -- this cleans up the message queue, which covers a lot more than mail. 2) usage() should be implemented using pod2usage -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20555 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20555 Lee Jamison <ldjamison@marywood.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ldjamison@marywood.edu Keywords| |Manual --- Comment #1 from Lee Jamison <ldjamison@marywood.edu> --- Barton, have a suggestion on how it should be re-written? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20555 --- Comment #2 from Barton Chittenden <barton@bywatersolutions.com> --- (In reply to Lee Jamison from comment #1)
Barton, have a suggestion on how it should be re-written?
In terms of documenting the '-m' option: I would change the GetOptions call from 'm|mail:i' => \$mail, to 'm|messageque:i' => \$mail, 'mail:i' => sub { $mail = shift; warn "Option '--mail' is deprecated. " . "use --messagequeue instead"; }, There may be better ways of handling the deprecated options, I welcome feedback from QA. Then the actual message should be something like this: '-m --messagequeue DAYS: Delete rows from message queue after DAYS days.' '--mail DAYS: (Deprecated) Delete rows from message_queue after DAYS days. This option is deprecated and will issue a warning if used. Use --messagequeue DAYS instead.' In terms of re-writing the usage() function to use pod2usage, take a look at misc/cronjobs/longoverdue.pl, it covers several common ways to call pod2usage. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20555 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Still valid ? We should just fix with "-m|--mail DAYS" ? Same for -h and -v -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20555 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40785 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org