[Bug 6302] New: Failing to send email notices - to_address not set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Bug #: 6302 Summary: Failing to send email notices - to_address not set Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Notices AssignedTo: henridamien@koha-fr.org ReportedBy: vanoudt@gmail.com QAContact: koha-bugs@lists.koha-community.org Created attachment 4037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4037 Simple patch to fix the issue Have just tracked down that email notices to clients (for overdues) were not being sent because the "to_address" was not set. The simple patch attached fixes it for us... We're running 3.2.2 - but th fix will apply to the latest git. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-05 06:00:30 UTC --- We are using 3.2.2 with overdue notices in production. One of our libraries started with fines and overdue notices at the beginning of this week. They told me overdue notices were successfully sent out, one to the librarian for testing even, and I saw nothing wrong in the database. I am wondering if this problem might be related to configuration? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |magnus@enger.priv.no Patch Status|--- |Needs Signoff --- Comment #2 from Magnus Enger <magnus@enger.priv.no> 2011-10-26 07:56:34 UTC --- Changing the status to "PATCH-Sent" and "Needs Signoff". -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-26 08:07:27 UTC --- I am still wondering about this. If the to_address is no set - afaik - the address will be taken from the patron account before the notice is sent out. We have a lot of libraries using notices with 3.2.2 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-04 21:25:04 UTC --- There was some discussion on the mailing list about this. One hint is to check the setting for AutoEmailPrimaryAddress. The to_address will be populated once the process_message_queue process was run. http://lists.katipo.co.nz/pipermail/koha/2011-November/031064.html I tend to mark this INVALID - ok? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 --- Comment #5 from Nicholas van Oudtshoorn <vanoudt@gmail.com> 2011-11-08 01:45:41 UTC --- Have tested, and it does work as noted in Comment 4 when the AutoEmailPrimaryAddress is set to "first valid". A few suggestions though: 1) That the system preference "AutoEmailPrimaryAddress" be made distinct from the "AutoEmailOpacUser" prefernce. I don't want to send an email to newly created patrons with their account details, but I *do* want to send them overdue notices. (Under 3.4.2 the preferences seem to be joined together?) 2) That process_message_queue should update the "to_address" field in the "message_queue" table upon sending the email. That way, there's a historical record of which email address the notice was actually sent to (even if the email address for a user is changed in the future) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 - low CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |--- --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-01 18:58:55 UTC --- I agree with Comment 5, I will switch this from patch sent, and hopefully we will get a patch to do both 1 and 2 in comment 5 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-02 06:56:04 UTC --- Created attachment 6508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6508 Bug 6302: Separate AutoEmailPrimaryAdress and AutoEmailOpacUser AutoEmailPrimaryAddress is not only used for the patron account mails, but also for overdues and other email notices to patrons. This patch separates the system preferences in the system preference editor. To test: - Check Patrons tab shows both system preferences separated - Check you can still change the settings -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6508|0 |1 is obsolete| | --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-12-06 16:14:33 UTC --- Created attachment 6605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6605 [SIGNED-OFF] Bug 6302: Separate AutoEmailPrimaryAdress and AutoEmailOpacUser AutoEmailPrimaryAddress is not only used for the patron account mails, but also for overdues and other email notices to patrons. This patch separates the system preferences in the system preference editor. To test: - Check Patrons tab shows both system preferences separated - Check you can still change the settings Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master Patch Status|Signed Off |Failed QA AssignedTo|henridamien@koha-fr.org |katrin.fischer@bsz-bw.de QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-07 13:08:12 UTC --- If I am not mistaken, this patch only resolves the first point of Comment 5 and is actually just a cosmetic change. The second point refers to updating the to_address in sub _send_message_by_email in Letters.pm. I would propose to put this report into hold until we can also consider the patch solving the second point. The first patch is OK, but setting the status to Failed QA in order to reflect the on hold status. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-07 13:10:05 UTC --- Hi Marcel, is there a reason the 'cosmetic' change can not go in now? It would make it easier for people to get their configuration right and send out mails. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-07 13:12:42 UTC --- (In reply to comment #10)
Hi Marcel, is there a reason the 'cosmetic' change can not go in now? It would make it easier for people to get their configuration right and send out mails.
Hi Katrin, It may speed up receiving the second patch ;) But if it would really help, I do not oppose pushing it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-07 14:41:31 UTC --- I don't think I will have time to work on the second part of the patch. :( -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-07 16:08:05 UTC --- (In reply to comment #12)
I don't think I will have time to work on the second part of the patch. :(
Will take a look. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-14 16:08:33 UTC --- Created attachment 6789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6789 Follow up for updating queue -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-14 16:09:37 UTC --- Second patch needs signoff ! Please test.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|m.de.rooy@rijksmuseum.nl |ian.walls@bywatersolutions. | |com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4037|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Koustubha Kale <kmkale@anantcorp.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6605|0 |1 is obsolete| | --- Comment #16 from Koustubha Kale <kmkale@anantcorp.com> 2011-12-15 09:42:31 UTC --- Created attachment 6806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6806 [SIGNED-OFF] Bug 6302: Separate AutoEmailPrimaryAdress and AutoEmailOpacUser AutoEmailPrimaryAddress is not only used for the patron account mails, but also for overdues and other email notices to patrons. This patch separates the system preferences in the system preference editor. To test: - Check Patrons tab shows both system preferences separated - Check you can still change the settings Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Koustubha Kale <kmkale@anantcorp.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Koustubha Kale <kmkale@anantcorp.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6789|0 |1 is obsolete| | --- Comment #17 from Koustubha Kale <kmkale@anantcorp.com> 2011-12-15 09:45:38 UTC --- Created attachment 6807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6807 [SIGNED-OFF] 6302 follow up Updates to_address in message queue when sending an email (when needed). Signed-off-by: Koustubha Kale <kmkale@anantcorp.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Koustubha Kale <kmkale@anantcorp.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kmkale@anantcorp.com --- Comment #18 from Koustubha Kale <kmkale@anantcorp.com> 2011-12-15 09:49:12 UTC --- (In reply to comment #16)
Created attachment 6806 [details] [SIGNED-OFF] Bug 6302: Separate AutoEmailPrimaryAdress and AutoEmailOpacUser
AutoEmailPrimaryAddress is not only used for the patron account mails, but also for overdues and other email notices to patrons.
This patch separates the system preferences in the system preference editor.
To test: - Check Patrons tab shows both system preferences separated - Check you can still change the settings
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed-off-by: Koustubha Kale <kmkale@anantcorp.com>
1) Verified that prior to applying patch one the System preferences AutoEmailOpacUser and AutoEmailPrimaryAddress were combined. 2) after applying first patch, verified that there were two separate system preferences for AutoEmailOpacUser and AutoEmailPrimaryAddress -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 --- Comment #19 from Koustubha Kale <kmkale@anantcorp.com> 2011-12-15 09:50:30 UTC --- (In reply to comment #17)
Created attachment 6807 [details] [SIGNED-OFF] 6302 follow up
Updates to_address in message queue when sending an email (when needed).
Signed-off-by: Koustubha Kale <kmkale@anantcorp.com>
3) Verified that before applying patch two, after running process_message_queue.pl, the to_address field in table message_queue had null for Item Overdue notice. 4) Verified that after applying patch two , after running process_message_queue.pl, the to_address field in table message_queue had patrons email address in it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Koustubha Kale <kmkale@anantcorp.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #20 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-16 17:11:23 UTC --- QA comment: both patches are small, good code, no specific comment no change in perlcritic (19 warnings before, 19 after applying the patch) test plan: see comment 5 to understand what those patches are doing passed QA patches pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2657 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6302 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org