[Bug 27182] New: Add ability to rename a MARC modification template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Bug ID: 27182 Summary: Add ability to rename a MARC modification template Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.johnson@bedfordtx.gov QA Contact: testopia@bugs.koha-community.org It would be helpful to add the ability to rename a MARC modification template. There are times when the name originally assigned isn't as descriptive as desired. While it is currently possible to use the 'New template' button to duplicate the template and give it a new name that's not very obvious. And then the old template would need to be deleted. This takes time and it would be more efficient to have a button or action from the main MARC modification template screen for renaming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- +1, this is a stilly functionality to leave out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 --- Comment #2 from Miranda Nero <mnero@oslri.net> --- Came here to file a bug about this myself. This would be extremely useful! A use case for me: I created a bunch of templates based on the specific MARC tags they were updating and they were all next to each other, but as we've created more templates, the original ones I created are now spread out. It would be helpful if I could rename them to include something at the beginning of each one so they would be sorted next to each other permanently. Another use case: fixing typos! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | Status|NEW |ASSIGNED CC| |samalau@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 --- Comment #3 from Sam Lau <samalau@gmail.com> --- Created attachment 168041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168041&action=edit Bug 27182: Unit tests To test: prove t/db_dependent/MarcModificationTemplates.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 --- Comment #4 from Sam Lau <samalau@gmail.com> --- Created attachment 168042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168042&action=edit Bug 27182: Add ability to rename a MARC modification template This patch adds a new 'Rename template' button on the MARC modifications templates page. To test: 1) Go to Cataloging -> MARC modification templates 2) Click the button at the top 'New template'. Name your template and press submit. 3) You should now be on the actions page for that template. Notice there isn't any options to rename your template. 4) Apply patch and restart_all 5) Notice that there is now a "Rename template' button. 6) Click this and rename your template and press submit. 7) Notice that the template name changed correctly. 8) Go back to the general MARC modifications templates page. Note the name of your template is correctly displayed in the table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 --- Comment #5 from Sam Lau <samalau@gmail.com> --- Created attachment 168045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168045&action=edit Bug 27182: (follow-up) Fix tidy warning -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Looks great, Sam. I notice 1 typo in C4/MarcModificationTemplates.pm: RenameModificatoinTemplate( $template_name, $template_id ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 --- Comment #7 from Sam Lau <samalau@gmail.com> --- Created attachment 168077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168077&action=edit Bug 27182: (follow-up) Fix typo in pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168077|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 168079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168079&action=edit Bug 27182: (follow-up) Fix typo in pm Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 --- Comment #9 from Heather <heather_hernandez@nps.gov> --- Worked great! Just a wee thing here, "4) Apply patch and restart_all 5) Notice that there is now a "Rename template' button," probably for the documentation, that one needs to: Select the 'Edit actions' button. Then 'Rename template' will appear at the top; choose 'Rename template' I've forgotten if I should change the Status on this bug to "Signed off," or if someone does then when it gets a second signoff? Cheerio!! h2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168041|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168080&action=edit Bug 27182: Unit tests To test: prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168042|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168081&action=edit Bug 27182: Add ability to rename a MARC modification template This patch adds a new 'Rename template' button on the MARC modifications templates page. To test: 1) Go to Cataloging -> MARC modification templates 2) Click the button at the top 'New template'. Name your template and press submit. 3) You should now be on the actions page for that template. Notice there isn't any options to rename your template. 4) Apply patch and restart_all 5) Notice that there is now a "Rename template' button. 6) Click this and rename your template and press submit. 7) Notice that the template name changed correctly. 8) Go back to the general MARC modifications templates page. Note the name of your template is correctly displayed in the table. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168045|0 |1 is obsolete| | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168082&action=edit Bug 27182: (follow-up) Fix tidy warning Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168079|0 |1 is obsolete| | --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168083&action=edit Bug 27182: (follow-up) Fix typo in pm Signed-off-by: Heather Hernandez <heather_hernandez@nps.gov> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |julian.maurice@biblibre.com --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- When I click "Rename template" nothing happens. There is no errors in the browser console. Also RenameModificationTemplate needs to be rewritten because of https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL16:_Hashrefs_shou... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171294&action=edit Bug 27182: Account for Bootstrap 5 changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171295&action=edit Bug 27182: Rework RenameModificationTemplate to not pass hashref as argument -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- The POD for RenameModificationTemplate needs to be updated. Failing QA for that. The QA script complains about tidiness in C4/MarcModificationTemplates.pm and t/db_dependent/MarcModificationTemplates.t but otherwise it looks good and works well I suggest to pre-fill the form with the current name, so that users don't have to retype (or copy/paste) the whole name only to fix a typo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos@dataly.gr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org --- Comment #18 from Angela Berrett <angela.berrett@familysearch.org> --- This one got lost after failing QA. The topic came up at our library again this week. Hoping this is an easy fix so it can be released soon. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 --- Comment #19 from Eric Phetteplace <ephetteplace@cca.edu> --- The changes needed are very small. Load the previous name into the renaming input. koha-tmpl/intranet-tmpl/prog/en/modules/tools/marc_modification_templates.tt: - <input name="template_name" id="template_name" type="text" size="30" required="required" class="required" /> + <input name="template_name" id="template_name" type="text" size="30" required="required" class="required" value="[% template_name | html %]" /> Fix the POD comment for RenameModificationTemplate. C4/MarcModificationTemplates.pm - RenameModificationTemplate( { template_name => $template_name, template_id => $template_id } ); + RenameModificationTemplate( { template_name => $template_name, template_id => $template_id } ); but I am struggling to get the patches to apply and may need to start over. There are also other tidy issues and conflicts, but some patches just don't apply at all, it's not merely merge conflicts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27182 --- Comment #20 from Eric Phetteplace <ephetteplace@cca.edu> --- Sorry that's this for the POD comment: - RenameModificationTemplate( $template_name, $template_id ); + RenameModificationTemplate( { template_name => $template_name, template_id => $template_id } ); -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org