[Bug 25146] New: Reconcile Balances Cron - should we remove?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25146 Bug ID: 25146 Summary: Reconcile Balances Cron - should we remove? Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz The reconcile balance cron was introduced to handle the patrons accounting where debits and credits were out of line. After this cron was introduced, a system preference, AccountAutoReconcile, was created to allow libraries to reconcile patron balances automatically as they happened. I would argue that this cron can be eliminated as the system preference can do the same thing and it gives control to the library through the staff client vs a cron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25146 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Depends on| |21915 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure if the cron would still be useful for people updating from earlier versions - allowing a 'clean-up' of data created before the pref was added. We could discuss moving it into a different directory then maybe - (maintenance?) Adding Tomas as the original author and linking to the original bug. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21915 [Bug 21915] Add a way to automatically reconcile balance for patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25146 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I agree this shouldn't be a cronjob anymore. This should belong to the maintenance scripts collection (even if AutoReconcile is on, there is no other tool that traverses all patrons and calls the reconcile_balance method on their behalf). For that reason, I would keep it, not as a cronjob, but keep it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25146 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Reconcile Balances Cron - |Move reconcile_balances.pl |should we remove? |script into maintenance | |directory -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25146 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have tried to patch this, but running the script, I get a fatal error: SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: SQL::Abstract before v1.75 used to generate incorrect SQL when the -IN operator was given an undef-containing list: !!!AUDIT YOUR CODE AND DATA!!! (the upcoming Data::Query-based version of SQL::Abstract will emit the logically correct SQL instead of raising this exception) at /home/vagrant/kohaclone/Koha/Objects.pm line 210 Tomas, can you help? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25146 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25146 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102954&action=edit Bug 25146: Move reconcile_balances.pl script into maintenance directory This moves the reconcile_balances.pl script from the cronjobs to the maintenance directory. It's still useful if you want to start using AccountAutoReconcile to clean your data up at the beginning, but is not supposed to run regularly in cron. To test: - Verify the file has been moved - Run the script and verify it still works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25146 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102954|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102955&action=edit Bug 25146: Move reconcile_balances.pl script into maintenance directory This moves the reconcile_balances.pl script from the cronjobs to the maintenance directory. It's still useful if you want to start using AccountAutoReconcile to clean your data up at the beginning, but is not supposed to run regularly in cron. To test: - Verify the file has been moved - Run the script and verify it still works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25146 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25148 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25148 [Bug 25148] reconcile_balances.pl dies with error -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25146 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25146 Bug 25146 depends on bug 25148, which changed state. Bug 25148 Summary: reconcile_balances.pl dies with error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25148 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org