[Bug 11735] New: Use new DataTables include in calendar template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 Bug ID: 11735 Summary: Use new DataTables include in calendar template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/holidays.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 11720 The calendar template should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25180&action=edit Bug 11735 - Use new DataTables include in calendar template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the calendar template and corrects some table sorting configuration errors. To test you should have multiple calendar entries in various categories of holiday: Unique holidays, repeating yearly holidays, repeating weekly holidays, and exceptions. Sorting of date columns should work regardless of your dateformat system preference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by merlissia <manuelimel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25180|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 25189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25189&action=edit Bug 11735 - Use new DataTables include in calendar template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the calendar template and corrects some table sorting configuration errors. To test you should have multiple calendar entries in various categories of holiday: Unique holidays, repeating yearly holidays, repeating weekly holidays, and exceptions. Sorting of date columns should work regardless of your dateformat system preference. Signed-off-by: merlissia <manuelimel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25189|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25190&action=edit Bug 11735 - Use new DataTables include in calendar template Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to the calendar template and corrects some table sorting configuration errors. To test you should have multiple calendar entries in various categories of holiday: Unique holidays, repeating yearly holidays, repeating weekly holidays, and exceptions. Sorting of date columns should work regardless of your dateformat system preference. Signed-off-by: merlissia <manuelimel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Note: Day of week is not correctly sorted: Sundays, Mondays, Thursdays. But it is not a regression. It is caused by the ugly way to display weekdays (document.write). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11735 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.07. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org