[Bug 8896] New: Delete serials no more missing from missinglist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Priority: P5 - low Change sponsored?: --- Bug ID: 8896 CC: colin.campbell@ptfs-europe.com Assignee: koha-bugs@lists.koha-community.org Summary: Delete serials no more missing from missinglist Severity: normal Classification: Unclassified OS: All Reporter: koha@univ-lyon3.fr Hardware: All Status: NEW Version: master Component: Serials Product: Koha Created attachment 12754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12754&action=edit Delete serials no more missing from missinglist With manual history disabled in subscription history section; that is when you have choosen to automatically record missing issues in the missinglist box, a serial prevously marked as missing was not deleted if received at the end or if its status was changed to 'claimed or 'late'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Could you please explain how to test this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Test Plan : Choose a serial to search in serial module click on title link click on Modify subscription and uncheck if necessary the 'manual history' checkbox in Subscription history part. ( => manualhistory=0 in sql subscription table) Save and go to Edit serial. Say you think that you will never receive the number X and out of despair set the status to 'missing'. If you come back to Modify subscription, Subscription history section, you can now see that the number N had been added to Missing field and as this supplies the corresponding zone on the OPAC, you'll also find it in the detail record of catalogue. Now imagine that you unexpectedly receive this serial the day after. You go to Edit serial and set it as 'arrived'. But number N remains in subscription Missing field and opac. Then, apply the patch and redo the same manouvers. You will see at the end, that the number N had been deleted from missing zone -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Liz Rea (CatalystIT) <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #3 from Liz Rea (CatalystIT) <liz@catalyst.net.nz> --- I stepped through your test plan -
From start to finish, with the patch on, I don't see the missing issue in the history, but I don't see it in the arrived list either - am I supposed to?
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12754|0 |1 is obsolete| | --- Comment #4 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 14657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14657&action=edit Bug 8896: Delete no more missing serials from missinglist Well,I used a smartmatch in my code that didn't match (I think it works only from perl 5.10 and on). I replace it by a grep and it's ok now. Test Plan : Choose a serial to search in serial module click on title link click on Modify subscription and uncheck if necessary the 'manual history' checkbox in Subscription history part. ( => manualhistory must be equal to 0 in sql subscription table) Save and go to Edit serial. Say you think that you will never receive the number N and out of despair set the status to 'missing'. If you come back to Modify subscription, Subscription history section, you can now see that the number N had been added to Missing field and as this supplies the corresponding zone on the OPAC, you'll also find it in the detail record of catalogue. Now imagine that you unexpectedly receive this serial the day after. You go to Edit serial and set it as 'arrived'. But number N remains in subscription Missing field and opac. Then, apply the patch and redo the same manouvers. You will see at the end, that the number N had been deleted from missing zone -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 15436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15436&action=edit Bug 8896: Delete serials no more missing from missinglist When manual history is disabled in subscription history section if a serial has been previously set as missing and is received, it will be deleted from missinglist. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14657|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Assignee|koha-bugs@lists.koha-commun |koha@univ-lyon3.fr |ity.org | QA Contact| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- What about this: I marked it back as Expected instead of Arrived, perhaps because Missing was just a wrong click. Now I see that it is still missing. So do you agree that we are still missing something :) or do I overlook something? Please clarify. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The option to change status back to expected is new in master as of the hackfest in Marseille last week, so maybe this patch needs to be amended a bit :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15436|0 |1 is obsolete| | --- Comment #8 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Created attachment 17275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17275&action=edit Bug 8896: Delete serials no more missing from missinglist I take into account in this new patch, the new possibility of reverting to expected status for Test plan see Comment 2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Working on this now.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17275|0 |1 is obsolete| | --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17362&action=edit Bug 8896 QA Followup for regex Making sure that the regex does not kill more than it should. Here are my test results when removing serialseq 3 :) 3 => 3 => 3; => 1;3 => 1 1; 3 => 1 1; 3; => 1 3;1 => 1 3; 1 => 1 3 ;1 => 1 3 ; 1 => 1 1;3;31 => 1;31 1;3 ;31 => 1;31 1;3; 31 => 1;31 1; 3;31 => 1;31 2;3;31;; ;,, ;;,, ,;,;,;4 => 2;31;4 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17363&action=edit Bug 8896: Delete serials no more missing from missinglist When manual history is disabled in subscription history section if a serial has been previously set as missing and is received or set as expected, late or claimed, it will be deleted from missinglist Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Regex needs a followup. More comments on Bugzilla. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17364&action=edit Bug 8896 QA Followup for regex Making sure that the regex does not kill more than it should. Here are my test results when removing serialseq 3 :) 3 => 3 => 3; => 1;3 => 1 1; 3 => 1 1; 3; => 1 3;1 => 1 3; 1 => 1 3 ;1 => 1 3 ; 1 => 1 1;3;31 => 1;31 1;3 ;31 => 1;31 1;3; 31 => 1;31 1; 3;31 => 1;31 2;3;31;; ;,, ;;,, ,;,;,;4 => 2;31;4 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17362|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Thanks for adjusting. I unfortunately still had some issues: 1) Your regex removes $serialseq from the missing list. Say that it is 1. This will remove also all other ;1\d+ from the list like 10 or 11 etc. I had some fun with regexes and sent a QA followup for them. 2) Could you send a followup for marking Not available and back? Please test. Had some funny effects with it: Like Missing issues:5; not issued 5 Delete 5 now: 5 is removed from missinglist, but "; not issued 5" remains there. Point 2 does not block this patch however. No problems with qa tools. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Please wait: still found something else.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17365&action=edit Bug 8896: Delete serials no more missing from missinglist When manual history is disabled in subscription history section if a serial has been previously set as missing and is received or set as expected, late or claimed, it will be deleted from missinglist Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Regex needs a followup. More comments on Bugzilla. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17366&action=edit Bug 8896 QA Followup for regex Making sure that the regex does not kill more than it should. Here are my test results when removing serialseq 3 :) 3 => 3 => 3; => 1;3 => 1 1; 3 => 1 1; 3; => 1 3;1 => 1 3; 1 => 1 3 ;1 => 1 3 ; 1 => 1 1;3;31 => 1;31 1;3 ;31 => 1;31 1;3; 31 => 1;31 1; 3;31;3A => 1;31;3A 2;3;31;; ;,, ;;,, ,;,;,;4 => 2;31;4 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #14)
Please wait: still found something else.. Replaced \D in the adjusted regex by a better [,;\s]
Back to Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- With this patch, the missing list ends up screwed up: Vol;1;No;4;Vol;1;No;9 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10092 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17366|0 |1 is obsolete| | --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17577&action=edit Bug 8896 QA Followup for regex Making sure that the regex does not kill more than it should. Amended: does now only look at separating colons(;) not commas(,). Amended: two index expressions in direct context replaced by same regex for consistency. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #18)
With this patch, the missing list ends up screwed up: Vol;1;No;4;Vol;1;No;9
And call it QA followup :) Good catch! I sobered (English?) the followup; it just looks at the ; (colons) and does not touch the commas anymore. Could not resist however to touch two index expressions. Replaced by the same regex for consistency. There is even more in this code. But I started a new report to get even more consistency. Bug 10092 handles updating the receivedlist similarly. The new report still needs a sign-off. Could anyone of you take care of that? I am setting the status of this report back to Signed off. But propose that somebody else passes QA now. Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: The patches works as expected. But it does not change the data in the DB, so the issue still exists until user change status for a missing serial. It's too bad not to deal with existing data. I pass QA this patch until it fixes a bug but it would be great to have a followup. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17365|0 |1 is obsolete| | Attachment #17577|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17927&action=edit Bug 8896: Delete serials no more missing from missinglist When manual history is disabled in subscription history section if a serial has been previously set as missing and is received or set as expected, late or claimed, it will be deleted from missinglist Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Regex needs a followup. More comments on Bugzilla. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17928&action=edit Bug 8896 QA Followup for regex Making sure that the regex does not kill more than it should. Amended: does now only look at separating colons(;) not commas(,). Amended: two index expressions in direct context replaced by same regex for consistency. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. I was unable to test this, because between the revised serials history patches and previously applying these patches the Serials module in my test installation is wholly unusable. I will revert from 3.12.x at the first complaint, but I did not want to bump it to 3.14 if that isn't necessary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org