[Bug 36378] New: Cannot stay logged in if AutoLocation is enabled but branch ip is not set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Bug ID: 36378 Summary: Cannot stay logged in if AutoLocation is enabled but branch ip is not set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org We can get into a scenario what a user cannot stay logged in for more than a single page load. If AutoLocation is enabled without branch IP addresses being set, you will be logged out with every page load. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot stay logged in if |Cannot stay logged in if |AutoLocation is enabled but |AutoLocation is enabled but |branch ip is not set |branch ip is not set | |correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- It looks like branchip has to contain a space to trigger the issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 163576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163576&action=edit Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly We can get into a scenario what a user cannot stay logged in for more than a single page load. If AutoLocation is enabled with branch IP addresses being set to a space, you will be logged out with every page load. Test Plan: 1) Set your branch ip to a space 2) Enable AutoLocation 3) Restart all the things! 4) Log out 5) Log in 6) Browse to another page 7) You are logged out 8) Apply patch 9) Repeat 1-6 10) You are not logged out! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- I think maybe a future enhancement would be to validate the branch ip when it is saved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163576|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 163716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163716&action=edit Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly We can get into a scenario what a user cannot stay logged in for more than a single page load. If AutoLocation is enabled with branch IP addresses being set to a space, you will be logged out with every page load. Test Plan: 1) Set your branch ip to a space 2) Enable AutoLocation 3) Restart all the things! 4) Log out 5) Log in 6) Browse to another page 7) You are logged out 8) Apply patch 9) Repeat 1-6 10) You are not logged out! Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36427 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36427 [Bug 36427] Library branch ip addresses should be validated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163716|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166625&action=edit Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly We can get into a scenario what a user cannot stay logged in for more than a single page load. If AutoLocation is enabled with branch IP addresses being set to a space, you will be logged out with every page load. Test Plan: 1) Set your branch ip to a space 2) Enable AutoLocation 3) Restart all the things! 4) Log out 5) Log in 6) Browse to another page 7) You are logged out 8) Apply patch 9) Repeat 1-6 10) You are not logged out! Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I agree.. it would be great to validate this field at a later date and I'm glad to see there's a bug report for that now too. For now, however, this catches the case and resolves the misconfiguration issue. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot stay logged in if |Cannot stay logged in if |AutoLocation is enabled but |AutoLocation is enabled but |branch ip is not set |library's IP address is not |correctly |set correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,24.05.12 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36378 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |david@davidnind.com --- Comment #11 from David Nind <david@davidnind.com> --- No updates to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org