[Bug 22927] New: Item improperly marked returned when changing damaged or withdrawn status
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Bug ID: 22927 Summary: Item improperly marked returned when changing damaged or withdrawn status Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- This is a matter of how MarkLostItemsAsReturned works on moredetail.pl. To replicate: - Set MarkLostItemsAsReturned to "from the items tab of the catalog module." - Check an item out to a patron - Use additem.pl to set that item to a lost status without returning it - go to moredetail.pl for that item - mark item as either damaged or withdrawn without interacting with the lost dropdown - note that item has been returned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Andrew <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 --- Comment #1 from Andrew <andrew@bywatersolutions.com> --- Confirmed this behavior in 18.05 and 18.11 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90443&action=edit Bug 22927: Do not check an already lost item when marked as withdrawn or damaged Due to how moredetail.pl was written it was hard to know which action was triggered. Test plan: - Set MarkLostItemsAsReturned to "from the items tab of the catalog module." - Check an item out to a patron - Use additem.pl to set that item to a lost status without returning it - go to moredetail.pl for that item - mark item as either damaged or withdrawn without interacting with the lost dropdown - note that item has not been returned Note for QA: Maybe we could have just tested if exists $item_changes->{'itemlost'} to call LostItem -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Claudie <claudie.tregouet@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90443|0 |1 is obsolete| | --- Comment #3 from Claudie <claudie.tregouet@biblibre.com> --- Created attachment 93355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93355&action=edit Bug 22927: Do not check an already lost item when marked as withdrawn or damaged Due to how moredetail.pl was written it was hard to know which action was triggered. Test plan: - Set MarkLostItemsAsReturned to "from the items tab of the catalog module." - Check an item out to a patron - Use additem.pl to set that item to a lost status without returning it - go to moredetail.pl for that item - mark item as either damaged or withdrawn without interacting with the lost dropdown - note that item has not been returned Note for QA: Maybe we could have just tested if exists $item_changes->{'itemlost'} to call LostItem Signed-off-by: Claudie Trégouët <claudie.tregouet@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Claudie <claudie.tregouet@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |claudie.tregouet@biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93355|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 93896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93896&action=edit Bug 22927: Do not check an already lost item when marked as withdrawn or damaged Due to how moredetail.pl was written it was hard to know which action was triggered. Test plan: - Set MarkLostItemsAsReturned to "from the items tab of the catalog module." - Check an item out to a patron - Use additem.pl to set that item to a lost status without returning it - go to moredetail.pl for that item - mark item as either damaged or withdrawn without interacting with the lost dropdown - note that item has not been returned Note for QA: Maybe we could have just tested if exists $item_changes->{'itemlost'} to call LostItem Signed-off-by: Claudie Trégouët <claudie.tregouet@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22927 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org