https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I'm not sure if this is ready for testing or not, but in it's current state it doesn't work for me: "my" variable $flags masks earlier declaration in same scope at /home/vagrant/kohaclone/circ/circulation.pl line 464. Can't call method "flags" on an undefined value at /home/vagrant/kohaclone/circ/circulation.pl line 179. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 --- Comment #3 from Zoe Bennett <zoebennett1308@gmail.com> --- Created attachment 70662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70662&action=edit Bug 17765: Changed variable $flags to $userflags to eliminate the issue of masking declaration in the same scope. Hides 'Holds' link on the 'Details' and 'Checkout' pages when the user does not have the permission to 'reserveforothers'. Test Plan: 1) With a user who has the permission to 'reserveforothers' check that the 'Holds' link is on the 'Details' and 'Check out' pages 2) Then with a user who does not have the permission to 'reserveforothers' check that on the 'Details' and 'Check out' pages there is no longer the 'Holds' link next to the 'Checkouts' and 'Fines & Charges' tabs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hide 'Holds' link in patron |Hide 'Holds' link in staff |account in staff |results list --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- The 'Holds(In reply to Katrin Fischer from comment #5)

I feel like the patches proposed here don't do the right thing. A staff patron without place_holds should still be able to see information about existing holds on the circ desk. If people disagree, we should discuss how to achieve this without causing a disruption for libraries, maybe using a new separate pref? Marking 'In discussion' for now.

I agree with this. We must have misunderstood the original bug. However, the original bug still stands. I'd like to change this bug description back to the original and have a 2019 academy student write the correct fix for that, because the current patch isn't desired behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 Jack <jke0429@stacmail.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jke0429@stacmail.net |ity.org | CC| |jke0429@stacmail.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17765 --- Comment #7 from Jack <jke0429@stacmail.net> --- Created attachment 84165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84165&action=edit Screenshot of results page In master, when I log in with a user that does not have reserveforothers permissions, the place hold button no longer appears, and the holds text is no longer a link, so I think this may have been fixed in a different patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.