[Bug 25005] New: Admin Rights issue for Suggestion to Purchase
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Bug ID: 25005 Summary: Admin Rights issue for Suggestion to Purchase Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: christofer.zorn@ajaxlibrary.ca QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Hello All! I hope everyone staying safe during this time! Yesterday I was trying to give a staff member permission to view and approve the "Suggestions Pending Approval". I had given that user full rights to the 'Suggestion Management' permission, however the option did not appear until I also provided the user with 'Moderate patron comments' under tools. However, to continue testing this I removed the 'Suggestion Management' option and it did remove it. I think there is something wrong with the check of the suggestion management piece that is preventing it from showing unless moderate comments option is also selected. Thanks for looking into this. Christofer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Version|19.05 |master Depends on| |22868 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- One occurrence missing on commit ae53caa6818939274352fde85454c24112e6f984 Bug 22868: Move suggestions_manage subperm out of acquisition perm Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22868 [Bug 22868] Circulation staff with suggestions_manage can have access to acquisition data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102510&action=edit Bug 25005: (bug 22868 follow-up) Fix suggestions pending on main page There is a "Suggestions pending approval" link on the main page that is displayed if there are new suggestions and the logged in user has the permission to manage them. On bug bug 22868 the permission changed from acquisition.suggestions_manage to suggestions.suggestions_manage But in the template, one occurrence has not been replaced correctly (certainly because it was already wrong actually). Test plan: Create a suggestion at the OPAC Create a patron with the suggestions permission Use this patron to login at the staff interface => Without this patch the link does not appear on the main page => With this patch applied the link appears -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102510|0 |1 is obsolete| | --- Comment #3 from David Roberts <david.roberts@ptfs-europe.com> --- Created attachment 102526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102526&action=edit Bug 25005: (bug 22868 follow-up) Fix suggestions pending on main page There is a "Suggestions pending approval" link on the main page that is displayed if there are new suggestions and the logged in user has the permission to manage them. On bug bug 22868 the permission changed from acquisition.suggestions_manage to suggestions.suggestions_manage But in the template, one occurrence has not been replaced correctly (certainly because it was already wrong actually). Test plan: Create a suggestion at the OPAC Create a patron with the suggestions permission Use this patron to login at the staff interface => Without this patch the link does not appear on the main page => With this patch applied the link appears Signed-off-by: David Roberts <david@koha-ptfs.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david.roberts@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102526|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 102694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102694&action=edit Bug 25005: (bug 22868 follow-up) Fix suggestions pending on main page There is a "Suggestions pending approval" link on the main page that is displayed if there are new suggestions and the logged in user has the permission to manage them. On bug bug 22868 the permission changed from acquisition.suggestions_manage to suggestions.suggestions_manage But in the template, one occurrence has not been replaced correctly (certainly because it was already wrong actually). Test plan: Create a suggestion at the OPAC Create a patron with the suggestions permission Use this patron to login at the staff interface => Without this patch the link does not appear on the main page => With this patch applied the link appears Signed-off-by: David Roberts <david@koha-ptfs.co.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- does not apply to 19.11.x cleanly. please rebase if needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 104350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104350&action=edit [19.11.x version] Bug 25005: (bug 22868 follow-up) Fix suggestions pending on main page There is a "Suggestions pending approval" link on the main page that is displayed if there are new suggestions and the logged in user has the permission to manage them. On bug bug 22868 the permission changed from acquisition.suggestions_manage to suggestions.suggestions_manage But in the template, one occurrence has not been replaced correctly (certainly because it was already wrong actually). Test plan: Create a suggestion at the OPAC Create a patron with the suggestions permission Use this patron to login at the staff interface => Without this patch the link does not appear on the main page => With this patch applied the link appears Signed-off-by: David Roberts <david@koha-ptfs.co.uk> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Christopher Davis <cgdavis@uintah.utah.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cgdavis@uintah.utah.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- Can this be ported to 19.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00 |20.05.00, 19.11.10 released in| | --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25005 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org