http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 --- Comment #2 from Rafal Kopaczka <rkopaczka@afm.edu.pl> --- (In reply to Owen Leonard from comment #1)

This sounds like Bug 11817 which I thought was fixed. Are you testing in master?

Yes, today's master. It's maybe similar but removing (unnecessary) href from delete link in cat-toolbar.inc fixes problem. I'll attach patch for a while. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 --- Comment #3 from Rafal Kopaczka <rkopaczka@afm.edu.pl> --- Created attachment 33568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33568&action=edit Bug 13254 - Delete record don't wait for confirmation In some cases (eg. when Staf Client Search is active), when user choose Edit->Delete record on record tool bar, browser don't wait for confirmation and goes immediately to delete record. To reproduce: 1. Search for some biblio records and choose one without items attached. 2. Note that there, must be "Return to search results" box on left side, bug works in that case, when in normal view everything work fine. 3. Click Edit->Delete record, watch that confirmation box shows, but don't wait for OK and runs immediately. If you are fast enough to click OK, then you get error as below, because record was deleted earlier. To test: 1. Apply patch. 2. Follow reproduce steps. 3. Check if waits for confirmation in all cases. 4. Check if deletes record after confirm. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33568|0 |1 is obsolete| | --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 33581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33581&action=edit Bug 13254 - Delete record don't wait for confirmation In some cases (eg. when Staf Client Search is active), when user choose Edit->Delete record on record tool bar, browser don't wait for confirmation and goes immediately to delete record. To reproduce: 1. Search for some biblio records and choose one without items attached. 2. Note that there, must be "Return to search results" box on left side, bug works in that case, when in normal view everything work fine. 3. Click Edit->Delete record, watch that confirmation box shows, but don't wait for OK and runs immediately. If you are fast enough to click OK, then you get error as below, because record was deleted earlier. To test: 1. Apply patch. 2. Follow reproduce steps. 3. Check if waits for confirmation in all cases. 4. Check if deletes record after confirm. Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33586&action=edit [PASSED QA] Bug 13254 - Delete record don't wait for confirmation In some cases (eg. when Staf Client Search is active), when user choose Edit->Delete record on record tool bar, browser don't wait for confirmation and goes immediately to delete record. To reproduce: 1. Search for some biblio records and choose one without items attached. 2. Note that there, must be "Return to search results" box on left side, bug works in that case, when in normal view everything work fine. 3. Click Edit->Delete record, watch that confirmation box shows, but don't wait for OK and runs immediately. If you are fast enough to click OK, then you get error as below, because record was deleted earlier. To test: 1. Apply patch. 2. Follow reproduce steps. 3. Check if waits for confirmation in all cases. 4. Check if deletes record after confirm. Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Confirmed the problem and that the patch fixes it. Good catch! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33581|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- This bug shows that the behavior of the browser is sometimes dangerous : $('a[href*="biblionumber="]').click(function (ev) { ev.preventDefault(); window.location = $(this).attr('href') + '&searchid=' + me.searchid; }); In my opinion the selector 'a[href*="biblionumber="]' is too large. It may impact future code. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please see also bug 13644 - this piece of code can also break links under some circumstances. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #11 from Mason James <mtj@kohaaloha.com> --- (In reply to Fridolin SOMERS from comment #8)

Dirty bug indeed. Can this be backported to 3.16.x ?

Pushed to 3.16.x, will be in 3.16.9 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #13 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14, will be in 3.14.15. -- You are receiving this mail because: You are watching all bug changes.