https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43886 Bug ID: 43886 Summary: Renewal messaging is confusing when renewal override settings conflict Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Target Milestone: --- We currently have three system preferences that control whether staff can or cannot override various types of renewal blockers: AllowFineOverrideRenewing AllowRenewalLimitOverride AllowRenewalOnHoldOverride However, the checkouts table only displays one relevant status about whether an item is renewable, even if there are multiple statuses that affect the item's renewability. If a checkout has multiple statuses that block renewal, including a mix of statuses that can be overridden and statuses that cannot be overridden, the messaging and behavior of that checkout can be confusing. Example scenario: 1. Set the following system preference values: AllowRenewalLimitOverride - allow AllowRenewalOnHoldOverride - don't allow 2. Find a biblio record with only one item and check that item out to Patron A 3. Create or edit an appropriate circulation rule to set "Renewals allowed (count)" to 0 4. Place a hold for Patron B on that biblio record 5. Go to Patron A's details page, and click the "Override renewal restrictions" checkbox at the bottom of their checkouts list --> Notice that a renewal checkbox appears next to the checkout, and the renewal status says "Not renewable (0 of 0 renewals remaining)", making no mention of Patron B's hold which should block renewal 6. Check the checkbox and try to renew it anyway --> The item's renewal column now says the renewal failed due to it being on hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.