[Bug 22661] New: TinyMCE/WYSIWYG editor doesn't translate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Bug ID: 22661 Summary: TinyMCE/WYSIWYG editor doesn't translate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Target Milestone: --- The WYSIWYG editor used by Koha doesn't translate. This includes the tool tips for the various buttons, the format list (Paragraph, Heading) and the text in the HTML pop-up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #1 from Magnus Enger <magnus@libriotech.no> --- (In reply to Katrin Fischer from comment #0)
The WYSIWYG editor used by Koha doesn't translate. This includes the tool tips for the various buttons, the format list (Paragraph, Heading) and the text in the HTML pop-up.
Does it not translate at all, or are there just some things that do not translate? It does seem to have its own translation system: https://www.tiny.cloud/get-tiny/language-packages/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For me it didn't translate at all, especially mouse-overs of the icons etc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- We do have a "langs" dir here: http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=koha-tmpl/intranet... but it only has a file called en.js. Maybe we need to add more files there, and figure out a way to tell TinyMCE to use them, based on the active language? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I think we might need to do our own translations: Create an include file like we have with datatables.inc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- This is ready for testing, bug Bugzilla rejects the patches because of the size. I've posted the branch here: https://gitlab.com/koha-dev/koha-dev/commits/bug-22661-tinymce-upgrade I have also put a downloadable patch here in case that helps: https://zivotdesign.com/download/bug-22661.patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 93885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93885&action=edit Screenshot of the new TinyMCE editor interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #5)
This is ready for testing
Cancel that, need to add some things! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Updated the remote branch and downloadable patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #9 from Michal Denar <black23@gmail.com> --- Any test plan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Michal Denar from comment #9)
Any test plan?
Yes, in the commit message: This patch updates the TinyMCE editor to the latest version (5.0.16) and adds a translatable include file which will allow the TinyMCE interface to show the same translation as Koha. The configuration of the editor has been updated according to the new version's requirements, keeping all the tools available we had before and adding emoji support. To test, apply the patch and enable the UseWYSIWYGinSystemPreferences system preference. TESTING THE UPGRADED EDITOR - Go to Administration -> System preferences -> OPAC. - Multiple instances of the TinyMCE editor should appear on the page: opaccredits, OpacCustomSearch, OpacLoginInstructions, etc. - Test adding and editing content to one or more of these editors. Confirm that the various editor tools work correctly. - Verify that changing the contents of any editor (including via paste) enables the corresponding "Save all X preferences" button. - Test the news editor under Tools -> News. - Test the library "OPAC info" editor in libraries administration: Administration -> Libraries -> Edit library -> OPAC info. TESTING TRANSLATABILITY - Update a translation:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for the staff client, e.g. misc/translator/po/fr-FR-staff-prog.po - Locate strings pulled from includes/str/tinymce_i18n.inc for translation, e.g.: #. SCRIPT #: intranet-tmpl/prog/en/includes/str/tinymce_i18n.inc:1 #, fuzzy msgid "File" msgstr "Fichier :" - Edit the "msgstr" string however you want (it's just for testing) and remove the "fuzzy" line. - Install the updated translation:
perl translate install fr-FR
- Go to Administration -> System preferences -> OPAC. - In each instance of the TinyMCE editor, the first menu item should have as its label the translation "msgstr" string you edited. - Check that the "About" page shows updated information about the TinyMCE version, 5.0.16. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Everything works as expected, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Wanted to test this, but the git link gives me an error - hope the branch was not lost? https://gitlab.com/koha-dev/koha-dev/commits/bug-22661-tinymce-upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Sorry, that was a mistake! It's back:
https://gitlab.com/koha-dev/koha-dev/commits/bug-22661-tinymce-upgrade
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really love the handling of the newer editor and fixing the translatability bug is almost just icing on the cake. Much more modern and I think I discovered some features that weren't there before (or that I always missed). Also tested the news editor. Thx Owen! PQA! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25485 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25862 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25862 [Bug 25862] TinyMCE editor mangles local url links (relative_urls is true) in tools/koha-new.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37965 [Bug 37965] Restore Bug 12032 - TinyMCE rewrites urls in a very annoying and unexpected way -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org