[Bug 7308] New: new column in admin/aqbudgets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Bug #: 7308 Summary: new column in admin/aqbudgets Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions AssignedTo: claire.hernandez@biblibre.com ReportedBy: claire.hernandez@biblibre.com QAContact: ian.walls@bywatersolutions.com Blocks: 7163 display a column in admin/aqbudgets "Base level ordered" (BibLibre MT5835) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 9167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9167&action=edit Show ordered amount in aqbudgets.pl This patch add a column in admin/aqbudgets.pl to display the ordered amount -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|claire.hernandez@biblibre.c |julian.maurice@biblibre.com |om | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Marijana Glavica <mglavica@ffzg.hr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mglavica@ffzg.hr --- Comment #2 from Marijana Glavica <mglavica@ffzg.hr> --- I tested the patch. "Base level ordered" column is now visible. But there are few more things which maybe should be changed in this table: 1. Amount shown in "Base-level remaining" column should be same as "Avail" column in acqui/acqui-home.pl, i.e. remaining = allocated - ordered - spent. 2. We should have the same wording for this two columns for consistency reasons (available or remaining) 3. "Base-level remaining" column should also have sorting feature (Claire noticed that) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- I'm not sure what to do for 1.: In acqui/acqui-home.pl: Avail = allocated - (ordered + spent) (ordered and spent do not include child funds) In admin/aqbudgets.pl: Remaining = allocated - spent (here, spent include child funds, but column indicate "Base-level remaining") What should we have in these columns? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Switching to 'in discussion' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #5 from Marijana Glavica <mglavica@ffzg.hr> --- Sorry Maurice for me not being clear. I took another look to admin/aqbudgets.pl and I found more confusing stuff, so I will try to make it clear what I think this table should look like to be really useful. I am looking at my production data. admin/aqbudgets.pl should have the following columns: Base-level allocated (or just Allocated) Base-level ordered Total sub-levels ordered Base-level spent Total sub-levels spent Base-level available Total sub-levels available Base-level is always calculated for one level, without children. Total sub-levels should include child funds. Available is calculated as "allocated - (ordered + spent)". So, this means that: - "Total allocated" should be removed because currently it shows the same data as "Base-level alloceted". - three new columns should be added: "Base-level ordered", "Total sub-levels ordered" and "Total sub-levels available"; - wording should be changed from "remaining" to "available" (consistency with acqui/acqui-home.pl) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- This sounds ok(In reply to comment #5)
Sorry Maurice for me not being clear. I prefer my firstname: Julian ;-)
I took another look to admin/aqbudgets.pl and I found more confusing stuff, so I will try to make it clear what I think this table should look like to be really useful. I am looking at my production data.
admin/aqbudgets.pl should have the following columns:
Base-level allocated (or just Allocated) Base-level ordered Total sub-levels ordered Base-level spent Total sub-levels spent Base-level available Total sub-levels available
Base-level is always calculated for one level, without children. Total sub-levels should include child funds. Available is calculated as "allocated - (ordered + spent)".
So, this means that: - "Total allocated" should be removed because currently it shows the same data as "Base-level alloceted". - three new columns should be added: "Base-level ordered", "Total sub-levels ordered" and "Total sub-levels available"; - wording should be changed from "remaining" to "available" (consistency with acqui/acqui-home.pl)
This sounds ok for me. Can anyone else confirm that this is what we want in these tables? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- I'll start working on it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12769&action=edit Bug 7308: rework aqbudgets.pl table admin/aqbudgets.pl should have the following columns: Base-level allocated (or just Allocated) Base-level ordered Total sub-levels ordered Base-level spent Total sub-levels spent Base-level available Total sub-levels available Base-level is always calculated for one level, without children. Total sub-levels should include child funds. Available is calculated as "allocated - (ordered + spent)". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |bgkriegel@gmail.com --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Patch doesn't apply Applying: Bug 7308: Show ordered amount in aqbudgets.pl Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt Auto-merging admin/aqbudgets.pl CONFLICT (content): Merge conflict in admin/aqbudgets.pl Auto-merging C4/Budgets.pm Failed to merge in the changes. Patch failed at 0001 Bug 7308: Show ordered amount in aqbudgets.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9167|0 |1 is obsolete| | --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16011&action=edit Bug 7308: Show ordered amount in aqbudgets.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12769|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 16012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16012&action=edit Bug 7308: rework aqbudgets.pl table admin/aqbudgets.pl should have the following columns: Base-level allocated (or just Allocated) Base-level ordered Total sub-levels ordered Base-level spent Total sub-levels spent Base-level available Total sub-levels available Base-level is always calculated for one level, without children. Total sub-levels should include child funds. Available is calculated as "allocated - (ordered + spent)". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased on master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16381&action=edit Bug 7308: rework aqbudgets.pl table admin/aqbudgets.pl should have the following columns: Base-level allocated (or just Allocated) Base-level ordered Total sub-levels ordered Base-level spent Total sub-levels spent Base-level available Total sub-levels available Base-level is always calculated for one level, without children. Total sub-levels should include child funds. Available is calculated as "allocated - (ordered + spent)". Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16012|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16011|0 |1 is obsolete| | --- Comment #15 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16394&action=edit Bug 7308: Show ordered amount in aqbudgets.pl Patch signed-off (pb with sandbox) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #16 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 16395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16395&action=edit Bug 7308: rework aqbudgets.pl table -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16381|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- syntax error at /usr/share/koha/testclone/admin/aqbudgets.pl line 323, near "/) " syntax error at /usr/share/koha/testclone/admin/aqbudgets.pl line 327, near "$_}" Global symbol "@loop" requires explicit package name at /usr/share/koha/testclone/admin/aqbudgets.pl line 352. Unmatched right curly bracket at /usr/share/koha/testclone/admin/aqbudgets.pl line 357, at end of line syntax error at /usr/share/koha/testclone/admin/aqbudgets.pl line 357, near "}" Unmatched right curly bracket at /usr/share/koha/testclone/admin/aqbudgets.pl line 376, at end of line syntax error at /usr/share/koha/testclone/admin/aqbudgets.pl line 376, near "}" Execution of /usr/share/koha/testclone/admin/aqbudgets.pl aborted due to compilation errors. Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- I do not reproduce these errors. Here's what I've done: $ git checkout -b bug/7308 && git fetch origin && git reset --hard origin/master $ git bz apply 7308 Bug 7308 - new column in admin/aqbudgets Bug 7308: Show ordered amount in aqbudgets.pl Apply? [yn] y Applying: Bug 7308: Show ordered amount in aqbudgets.pl Bug 7308: rework aqbudgets.pl table Apply? [yn] y Applying: Bug 7308: rework aqbudgets.pl table $ perl -cw admin/aqbudgets.pl admin/aqbudgets.pl syntax OK $ git log --oneline -3 ebd30fe Bug 7308: rework aqbudgets.pl table 72e2c0a Bug 7308: Show ordered amount in aqbudgets.pl acd4b21 Bug 10311 - Holds queue ignores item-level holds where only one items exists $ perl -v | head -n2 This is perl, v5.10.1 (*) built for x86_64-linux-gnu-thread-multi Looking at the source file, the code looks good too. Could you retry please? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- I confirm I don't get any error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Reset to Signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19824&action=edit [PASSED QA] Bug 7308: Show ordered amount in aqbudgets.pl Signed-off-by: Cédric Vita <cedric.vita@dracenie.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19825&action=edit [PASSED QA] Bug 7308: rework aqbudgets.pl table admin/aqbudgets.pl should have the following columns: Base-level allocated (or just Allocated) Base-level ordered Total sub-levels ordered Base-level spent Total sub-levels spent Base-level available Total sub-levels available Base-level is always calculated for one level, without children. Total sub-levels should include child funds. Available is calculated as "allocated - (ordered + spent)". Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Seems to work alright for me. Passes QA script and tests, after I fixed 2 tabs in admin/aqbudgets.pl. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16394|0 |1 is obsolete| | Attachment #16395|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19826&action=edit Bug 7308 - Follow up: removing line breaks for better translatability Because of the lines breaks in the table headings the strings were separated in translation. Example: Base-level allocated - Base-level - allocated If you look at a smaller screen the table headings will still break without the additional <br />. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #24 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 19859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19859&action=edit potential source of confusion if parent and child funds both have orders Overall, I think the patch looks good, but there's a case where I think it leads to a confusing display. In the screenshot, fund abc has $10.45 ordered against it, but it also has a child fund, def, that has $14.97 ordered against it. The base-level ordered and total-ordered make sense, individually, but when you look at the whole picture, a librarian could be excused for asking why the total of the "total ordered" column is $33.97, not $48.94 (= $25.42 + 14.97 + $8.55). Does anybody have any suggestions on how this could be made more clear? Setting to in discussion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #25 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to Galen Charlton from comment #24)
Does anybody have any suggestions on how this could be made more clear? Setting to in discussion.
Pushed or in discussion ? status mistaken ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- Galen, I don't see a good solution here. Maybe can we change the color for child cells? I think there is a deep ergonomic issue on this page and should be partially rewrite (always use DT and insert a way to always see funds as a tree). I will submit a followup in order to revive this bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22462&action=edit Bug 7308: change color style for fund child -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- Switch to "needs QA", waiting for a QAer point of view. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, it looks like Jonathan and me can't do QA here - could someone else take this on please? :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19826|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24936&action=edit [PASSED QA] Bug 7308 - Follow up: removing line breaks for better translatability Because of the lines breaks in the table headings the strings were separated in translation. Example: Base-level allocated - Base-level - allocated If you look at a smaller screen the table headings will still break without the additional <br />. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22462|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 24937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24937&action=edit [PASSED QA] Bug 7308: change color style for fund child Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #32 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up that introduces a descriptive CSS class (child_fund_amount) and uses italics rather than a subtle font color difference to indicate that child fund amounts do not participate in the totals. Thanks, Julian and Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fcapovilla@live.ca --- Comment #33 from simith.doliveira@inlibro.com --- *** Bug 11823 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #34 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.11 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org