[Bug 21360] New: IssueSlip.t is failing if run at 23:59
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21360 Bug ID: 21360 Summary: IssueSlip.t is failing if run at 23:59 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 15029 Not sure what happened on bug 15029 (Make the IssueSlip tests pass even if launched after 23:00) but we should have tested with 23:59, not 23:50... koha_1 | # Looks like you planned 3 tests but ran 2. koha_1 | koha_1 | # Failed test 'Issue slip' koha_1 | # at t/db_dependent/Members/IssueSlip.t line 294. koha_1 | Label not found for "last SKIP" at /usr/share/perl5/Test/More.pm line 1370. koha_1 | # Looks like your test exited with 255 just after 1. koha_1 | [23:59:10] t/db_dependent/Members/IssueSlip.t ...................................... koha_1 | Dubious, test returned 255 (wstat 65280, 0xff00) koha_1 | Failed 3/3 subtests Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15029 [Bug 15029] Tests fail if launched after 23:00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21360 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21360 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 78937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78937&action=edit Bug 21360: Prevent IssueSlip.t to fail when run at 23:59 Not sure what happened on bug 15029 (Make the IssueSlip tests pass even if launched after 23:00) but we should have tested with 23:59, not 23:50... koha_1 | # Looks like you planned 3 tests but ran 2. koha_1 | koha_1 | # Failed test 'Issue slip' koha_1 | # at t/db_dependent/Members/IssueSlip.t line 294. koha_1 | Label not found for "last SKIP" at /usr/share/perl5/Test/More.pm line 1370. koha_1 | # Looks like your test exited with 255 just after 1. koha_1 | [23:59:10] t/db_dependent/Members/IssueSlip.t koha_1 | Dubious, test returned 255 (wstat 65280, 0xff00) koha_1 | Failed 3/3 subtests Test plan: 0/ Don't apply this patch 1/ sudo date -s "2018-09-15 23:59:00";prove t/db_dependent/Members/IssueSlip.t => You should get the error 2/ Apply this patch and repeat 1. => Tests should pass now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21360 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Needs Signoff |Signed Off --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Tested, works as expected, minor patch, skipping QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21360 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21360 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Thanks Jonathan Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21360 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21360 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org