[Bug 6908] New: increase DEBUG level for *NOISY* Dates.pm init() messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6908 Bug #: 6908 Summary: increase DEBUG level for *NOISY* Dates.pm init() messages Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt@gmail.com ReportedBy: mtj@kohaaloha.com QAContact: koha-bugs@lists.koha-community.org with $DEBUG set to 1, C4:Date:init() is *very* noisy, and often writes many messages for a single page load when debugging, these messages are often distracting and irritating ------------------------------------------------------------------------------ mainpage.pl: (during init) @$self->{'dmy_arrayref'}: 58 25 05 29 9 107 -1 -1 1, mainpage.pl: (during init) @$self->{'dmy_arrayref'}: 45 34 05 29 9 107 -1 -1 1, ------------------------------------------------------------------------------ these messages should only be displayed with a $DEBUG value of 2, or higher -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6908 --- Comment #1 from Mason James <mtj@kohaaloha.com> 2011-09-22 09:43:06 UTC --- Created attachment 5535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5535 patch appiled to MASTER commit 147ae6c665cd25a07471d90afcab3e38ce36d9e0 Merge: d43aa87 9d3a8d9 Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Fri Sep 16 13:53:40 2011 +1200 Merge remote-tracking branch 'kc/new/enh/bug_4877' into kcmaster -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6908 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5535|0 |1 is obsolete| | --- Comment #2 from Mason James <mtj@kohaaloha.com> 2011-09-22 09:50:23 UTC --- Created attachment 5536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5536 corrected patch :) oops, a litle typo there folks... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6908 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent AssignedTo|gmcharlt@gmail.com |mtj@kohaaloha.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6908 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6908 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5536|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-02 08:43:08 UTC --- Created attachment 6514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6514 Bug 6908 - increase DEBUG level for *NOISY* Dates.pm init() messages Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6908 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6908 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Patch Pushed --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-06 19:39:02 UTC --- QA comment: one line patch, usefull, nothing to say patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6908 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2011-12-20 21:20:24 UTC --- This results in the following error types in the log: [Thu Dec 15 16:20:43 2011] [error] [client 10.8.5.33] [Thu Dec 15 16:20:43 2011] opac-detail.pl: Use of uninitialized value $C4::Dates::debug in numeric gt (>) at /usr/share/kohatest36/lib/C4/Dates.pm line 170., referer: http://kohatest36/cgi-bin/koha/opac-search.pl?q=school+census Looks like $debug isn't getting universally set to a numeric value. In the cases where it's not numeric, we get the above error -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6908 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-26 16:29:24 UTC --- mason, a follow-up patch with something like if ($debug && $debug > 1) { warn "(during init) \@\$self->{'dmy_arrayref'}: " . join( ' ', @{ $self->{'dmy_arrayref'} } ) . "\n"; } instead of if ($debug > 1) { warn "(during init) \@\$self->{'dmy_arrayref'}: " . join( ' ', @{ $self->{'dmy_arrayref'} } ) . "\n"; } welcomed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6908 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in 3.6 prior to 3.6.5. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org