[Bug 29868] New: Add Koha::Old::Hold->anonymize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Bug ID: 29868 Summary: Add Koha::Old::Hold->anonymize Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Found the need to anonymize from Koha::Hold->cancel, and in this case using an iterator would be overkill as I already have the Koha::Old::Hold object in place as the return value from $self->_move_to_old... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |Needs Signoff Blocks| |29525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129359&action=edit Bug 29868: Add Koha::Old::Hold->anonymize Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129359|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129360&action=edit Bug 29868: Add Koha::Old::Hold->anonymize This patch introduces a new method in Koha::Old::Hold. The method is fully covered by tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 [Bug 29869] Add Koha::Hold->fill -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129360|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129410&action=edit Bug 29868: Add Koha::Old::Hold->anonymize This patch introduces a new method in Koha::Old::Hold. The method is fully covered by tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Resubmitted and made it dependent on bug 29869 as they both add tests to Koha/Hold.t and the count is always gonna be a problem :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129410|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 129423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129423&action=edit Bug 29868: Add Koha::Old::Hold->anonymize This patch introduces a new method in Koha::Old::Hold. The method is fully covered by tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129423|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 129541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129541&action=edit Bug 29868: Add Koha::Old::Hold->anonymize This patch introduces a new method in Koha::Old::Hold. The method is fully covered by tests. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Hold.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tests passing, QA script happy.. Code all makes sense. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Bug 29868 depends on bug 29869, which changed state. Bug 29869 Summary: Add Koha::Hold->fill https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Bug 29868 depends on bug 29869, which changed state. Bug 29869 Summary: Add Koha::Hold->fill https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 Bug 29868 depends on bug 29869, which changed state. Bug 29869 Summary: Add Koha::Hold->fill https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org