[Bug 10361] New: Add Option to cleanup_database.pl to purge search_history entries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Bug ID: 10361 Summary: Add Option to cleanup_database.pl to purge search_history entries Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: mirko@abunchofthings.net Reporter: mirko@abunchofthings.net Add an option to cleanup_database.pl to purge the search_history entries older than X days. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 --- Comment #1 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 18424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18424&action=edit Bug 10361 - Add Option to cleanup_database.pl to purge search_history entries Add an option to cleanup_database.pl to purge the search_history entries older than X days. Test plan: - Apply patch - Check that your test DB has some entries a little older than 30 days and a few ones even older than that in search_history: SELECT * FROM search_history WHERE time < DATE_SUB( NOW(), INTERVAL 30 DAY ); If not, modify some existing entries. - Run cleanup_database with a fixed number of days (replace XX with something higher than 30) /misc/cronjobs/cleanup_database.pl --searchhistory XX - check that entries older than XX days got deleted from search_history - run without the day parameter /misc/cronjobs/cleanup_database.pl --searchhistory - check that entries older than 30 days got deleted from search_history - Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- "DELETE FROM search_history" query should go to C4::Search.pm, preferrably with a test (but not a show stopper) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- Actually I was thinking it should go into some kind of privacy section in the future. There is more personal data that may have to be deleted on a regular basis to meet privacy/data protection requirements. I see the relation to Search.pm but it is not the place I would have been looking for this kind of feature. And Search.pm is bloated as it is. I'd welcome more comments on this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> ---
From IRC:
[06:54:14] <drojf> @later tell gmcharlt could you have a look at the comments on bug 10361 please? do you agree i should move the query to Search.pm? ... [07:16:14] <gmcharlt> to answer your question, if you don't want to spend too much effort at it, I agree with Srdjan that it should go into C4::Search -- that's where AddSearchHistory and GetSearchHistory live at the moment [07:17:05] <gmcharlt> if you want to take a little more time and refactor, maybe put it in a new module called Koha::Search::History on thel ike -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18424|0 |1 is obsolete| | --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 18838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18838&action=edit Bug 10361 Add Option to cleanup_database.pl to purge search_history entries Add an option to cleanup_database.pl to purge the search_history entries older than X days. Revised version, moved DELETE FROM search_history to Search.pm Test plan: - Apply patch - Check that your test DB has some entries a little older than 30 days and a few ones even older than that in search_history: SELECT * FROM search_history WHERE time < DATE_SUB( NOW(), INTERVAL 30 DAY ); If not, modify some existing entries. - Run cleanup_database with a fixed number of days (replace XX with something higher than 30) /misc/cronjobs/cleanup_database.pl --searchhistory XX - check that entries older than XX days got deleted from search_history - run without the day parameter /misc/cronjobs/cleanup_database.pl --searchhistory - check that entries older than 30 days got deleted from search_history - Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18838|0 |1 is obsolete| | --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 18839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18839&action=edit Bug 10361 Add Option to cleanup_database.pl to purge search_history entries Add an option to cleanup_database.pl to purge the search_history entries older than X days. Revised version, moved DELETE FROM search_history to Search.pm Test plan: - Apply patch - Check that your test DB has some entries a little older than 30 days and a few ones even older than that in search_history: SELECT * FROM search_history WHERE time < DATE_SUB( NOW(), INTERVAL 30 DAY ); If not, modify some existing entries. - Run cleanup_database with a fixed number of days (replace XX with something higher than 30) /misc/cronjobs/cleanup_database.pl --searchhistory XX - check that entries older than XX days got deleted from search_history - run without the day parameter /misc/cronjobs/cleanup_database.pl --searchhistory - check that entries older than 30 days got deleted from search_history - Signoff Rebased to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- (also removes a duplicate export of &SimpleSearch from Search.pm) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18839|0 |1 is obsolete| | --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20067&action=edit Bug 10361: (follow-up) add tests for search history functions This adds tests for the new PurgeSearchHistory function and AddSearchHistory. GetSearchHistory is not tested due to its current broken state (see bug 10667). To test: [1] Run prove -v t/db_dependent/Search_SearchHistory.t [2] Verify that all tests pass. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20067|0 |1 is obsolete| | --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20068&action=edit Bug 10361: Add option to cleanup_database.pl to purge OPAC search history Add an option to cleanup_database.pl to purge the search_history entries older than X days. Test plan: - Apply patch - Check that your test DB has some entries a little older than 30 days and a few ones even older than that in search_history: SELECT * FROM search_history WHERE time < DATE_SUB( NOW(), INTERVAL 30 DAY ); If not, modify some existing entries. - Run cleanup_database with a fixed number of days (replace XX with something higher than 30) /misc/cronjobs/cleanup_database.pl --searchhistory XX - Check that entries older than XX days got deleted from search_history - Run without the day parameter /misc/cronjobs/cleanup_database.pl --searchhistory - Check that entries older than 30 days got deleted from search_history Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20069&action=edit Bug 10361: (follow-up) add tests for search history functions This adds tests for the new PurgeSearchHistory function and AddSearchHistory. GetSearchHistory is not tested due to its current broken state (see bug 10667). To test: [1] Run prove -v t/db_dependent/Search_SearchHistory.t [2] Verify that all tests pass. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 --- Comment #11 from Galen Charlton <gmcharlt@gmail.com> --- I've signed off on the patch and added a follow-up that adds some tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20069|0 |1 is obsolete| | --- Comment #12 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 20258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20258&action=edit Bug 10361: (follow-up) add tests for search history functions This adds tests for the new PurgeSearchHistory function and AddSearchHistory. GetSearchHistory is not tested due to its current broken state (see bug 10667). To test: [1] Run prove -v t/db_dependent/Search_SearchHistory.t [2] Verify that all tests pass. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Mirko Tietgen <mirko@abunchofthings.net> --- t/db_dependent/Search_SearchHistory.t .. 1..6 ok 1 - use C4::Search; ok 2 - starting off with nothing in search_history ok 3 - successfully added four search_history rows ok 4 - purged history older than 45 days ok 5 - purged history older than 30 days ok 6 - purged all history ok All tests successful. Thanks Galen for adding the tests! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20068|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20740&action=edit Bug 10361: Add option to cleanup_database.pl to purge OPAC search history Add an option to cleanup_database.pl to purge the search_history entries older than X days. Test plan: - Apply patch - Check that your test DB has some entries a little older than 30 days and a few ones even older than that in search_history: SELECT * FROM search_history WHERE time < DATE_SUB( NOW(), INTERVAL 30 DAY ); If not, modify some existing entries. - Run cleanup_database with a fixed number of days (replace XX with something higher than 30) /misc/cronjobs/cleanup_database.pl --searchhistory XX - Check that entries older than XX days got deleted from search_history - Run without the day parameter /misc/cronjobs/cleanup_database.pl --searchhistory - Check that entries older than 30 days got deleted from search_history Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20258|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20741&action=edit Bug 10361: (follow-up) add tests for search history functions This adds tests for the new PurgeSearchHistory function and AddSearchHistory. GetSearchHistory is not tested due to its current broken state (see bug 10667). To test: [1] Run prove -v t/db_dependent/Search_SearchHistory.t [2] Verify that all tests pass. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mirko! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org