[Bug 35015] New: Regression: Charges table no longer filters on paid transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Bug ID: 35015 Summary: Regression: Charges table no longer filters on paid transactions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Bug 32431 has introduced a blank column to help with responsiveness but this has broken the filtering as it is column index based. The column index needs adjusting to account for this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32341 Severity|enhancement |major Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 [Bug 32341] Some OPAC tables are not displayed well in mobile mode -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 156755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156755&action=edit Bug 35015: Adjust column index in fnFilter This patch fixes the column index in the call to fnFilter following the addition of a new column to the table in bug 32341 Test plan: 1) Add some charges to a patron account 2) Pay some of these charges so that they are no longer outstanding 3) In the OPAC log in as that patron and navigate to the Charges tab in their account 4) Observe that all charges are listed, even if they have been paid and clicking the Show all transactions button has no effect even if clicked multiple times between the different filtering options 5) Apply patch 6) Refresh page and now the settled charges should be filtered out 7) Click the Show all transactions button and it should correctly update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression: Charges table |Regression: Charges table |no longer filters on paid |no longer filters out paid |transactions |transactions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156755|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156756&action=edit Bug 35015: Adjust column index in fnFilter This patch fixes the column index in the call to fnFilter following the addition of a new column to the table in bug 32341 Test plan: 1) Add some charges to a patron account 2) Pay some of these charges so that they are no longer outstanding 3) In the OPAC log in as that patron and navigate to the Charges tab in their account 4) Observe that all charges are listed, even if they have been paid and clicking the Show all transactions button has no effect even if clicked multiple times between the different filtering options 5) Apply patch 6) Refresh page and now the settled charges should be filtered out 7) Click the Show all transactions button and it should correctly update Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156756|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156764&action=edit Bug 35015: Adjust column index in fnFilter This patch fixes the column index in the call to fnFilter following the addition of a new column to the table in bug 32341 Test plan: 1) Add some charges to a patron account 2) Pay some of these charges so that they are no longer outstanding 3) In the OPAC log in as that patron and navigate to the Charges tab in their account 4) Observe that all charges are listed, even if they have been paid and clicking the Show all transactions button has no effect even if clicked multiple times between the different filtering options 5) Apply patch 6) Refresh page and now the settled charges should be filtered out 7) Click the Show all transactions button and it should correctly update Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156764|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156765&action=edit Bug 35015: Adjust column index in fnFilter This patch fixes the column index in the call to fnFilter following the addition of a new column to the table in bug 32341 Test plan: 1) Add some charges to a patron account 2) Pay some of these charges so that they are no longer outstanding 3) In the OPAC log in as that patron and navigate to the Charges tab in their account 4) Observe that all charges are listed, even if they have been paid and clicking the Show all transactions button has no effect even if clicked multiple times between the different filtering options 5) Apply patch 6) Refresh page and now the settled charges should be filtered out 7) Click the Show all transactions button and it should correctly update Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156766&action=edit Bug 35015: (QA follow-up) Fix paid transactions filter in the staff interface Same problem: we added a column without adjusting the filter. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156766|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156784&action=edit Bug 35015: (QA follow-up) Fix paid transactions filter in the staff interface Same problem: we added a column without adjusting the filter. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35015 Bug 35015 depends on bug 32341, which changed state. Bug 32341 Summary: Some OPAC tables are not displayed well in mobile mode https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org