[Bug 21646] New: Clean up Overdrive template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Bug ID: 21646 Summary: Clean up Overdrive template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/overdrive.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 21607 The overdrive administration template has several issues which need to be cleaned up: - Bootstrap grid - Markup corrections Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21607 [Bug 21607] Koha::Account::Line->apply should store credit offsets as negative amounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20654 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20654 [Bug 20654] Omnibus: Update two-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81079&action=edit Bug 21646: Clean up Overdrive template This patch modifies the OverDrive administration page to correct some markup issues: - Switch to Bootstrap grid - Add missing header search box - Add missing DataTable configuration - Remove unnecessary fieldset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Bug 21646 depends on bug 21607, which changed state. Bug 21607 Summary: Koha::Account::Line->apply should store credit offsets as negative amounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21607 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81079|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 86976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86976&action=edit Bug 21646: Clean up Overdrive template This patch modifies the OverDrive administration page to correct some markup issues: - Switch to Bootstrap grid - Add missing header search box - Add missing DataTable configuration - Remove unnecessary fieldset To test you do not need to have OverDrive credentials. Apply the patch and go to System preferences -> Enhanced content -> OverDrive. In the description of the "OverDriveAuthName" preference, follow the link to manage "individual branch authnames." - Confirm that the page looks correct, including the header search box, page title, and breadcrumbs - Confirm that the page adjusts well to various browser window sizes. - Confirm that the DataTable works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86976|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 86982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86982&action=edit Bug 21646: Clean up Overdrive template This patch modifies the OverDrive administration page to correct some markup issues: - Switch to Bootstrap grid - Add missing header search box - Add missing DataTable configuration - Remove unnecessary fieldset To test you do not need to have OverDrive credentials. Apply the patch and go to System preferences -> Enhanced content -> OverDrive. In the description of the "OverDriveAuthName" preference, follow the link to manage "individual branch authnames." - Confirm that the page looks correct, including the header search box, page title, and breadcrumbs - Confirm that the page adjusts well to various browser window sizes. - Confirm that the DataTable works correctly. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- OverDrive library authnames : Not the most appealing form title, I guess? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86982|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 87175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87175&action=edit Bug 21646: Clean up Overdrive template This patch modifies the OverDrive administration page to correct some markup issues: - Switch to Bootstrap grid - Add missing header search box - Add missing DataTable configuration - Remove unnecessary fieldset To test you do not need to have OverDrive credentials. Apply the patch and go to System preferences -> Enhanced content -> OverDrive. In the description of the "OverDriveAuthName" preference, follow the link to manage "individual branch authnames." - Confirm that the page looks correct, including the header search box, page title, and breadcrumbs - Confirm that the page adjusts well to various browser window sizes. - Confirm that the DataTable works correctly. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org