[Bug 25029] New: AllowPatronToControlAutorenewal needs to have a disable setting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Bug ID: 25029 Summary: AllowPatronToControlAutorenewal needs to have a disable setting Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The AllowPatronToControlAutorenewal has a Staff or Stand and Patron setting, but it needs to be a master disable switch as well. With it in the staff only position, staff still see a switch for auto renewal in the patron settings, despite that nothing is set in the circulation rules. It would be ideal if AllowPatronToControlAutorenewal had a Disable setting that: * hid the "Allow auto-renewal of items" choice in the Library Management settings for the patron. * hid the three columns in the circulation rules that deal with Auto Renewal. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Depends on| |24476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 [Bug 24476] Allow patrons to opt-out of auto-renewal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111566&action=edit Bug 25029: Add autorenew_checkouts column to preferences json Bug 24476 added autorenew_checkouts as a borrower column, intending it to be able to be hidden if a library was not using the feature. When the column chooser was added, this column was not included. To test: 1 - Search system preferences for "BorrowerUnwantedFields" 2 - Click the box to change the value 3 - "autorenew_checkouts" is not an option 4 - Confirm that you see the option to opt patron out of autorenewal when editing patron on staff side 5 - Apply patch and restart everythign 6 - Search for the syspref again 7 - Note that now you can select "autorenew_checkouts" 8 - Check the box and save 9 - Confirm the opt out option is no longer visible during patron editing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Bug 25029 depends on bug 24476, which changed state. Bug 24476 Summary: Allow patrons to opt-out of auto-renewal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111566|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 115446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115446&action=edit Bug 25029: Add autorenew_checkouts column to preferences json Bug 24476 added autorenew_checkouts as a borrower column, intending it to be able to be hidden if a library was not using the feature. When the column chooser was added, this column was not included. To test: 1 - Search system preferences for "BorrowerUnwantedFields" 2 - Click the box to change the value 3 - "autorenew_checkouts" is not an option 4 - Confirm that you see the option to opt patron out of autorenewal when editing patron on staff side 5 - Apply patch and restart everythign 6 - Search for the syspref again 7 - Note that now you can select "autorenew_checkouts" 8 - Check the box and save 9 - Confirm the opt out option is no longer visible during patron editing Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Great idea. Works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- What about the three auto renew columns in the Circulation rules? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Christopher Brannon from comment #4)
What about the three auto renew columns in the Circulation rules?
I'd argue that's a separate question/issue - removing an option in the patron record vs entirely hiding an option from your circ rules. Maybe file a separate bug for the option to completely hide auto-renew from the circ rules? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really think this is the way to go, but there is a side effect in the option showing up for all patron preferences where they don't any effect (example: PatronSelfModificationBorrowerUnwantedField). I think there is another patch around adding a limit to the display for another option at the moment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17364 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to PTFS Europe Sandboxes from comment #2)
Created attachment 115446 [details] [review] Bug 25029: Add autorenew_checkouts column to preferences json
Bug 24476 added autorenew_checkouts as a borrower column, intending it to be able to be hidden if a library was not using the feature.
When the column chooser was added, this column was not included.
To test: 1 - Search system preferences for "BorrowerUnwantedFields" 2 - Click the box to change the value 3 - "autorenew_checkouts" is not an option 4 - Confirm that you see the option to opt patron out of autorenewal when editing patron on staff side 5 - Apply patch and restart everythign 6 - Search for the syspref again 7 - Note that now you can select "autorenew_checkouts" 8 - Check the box and save 9 - Confirm the opt out option is no longer visible during patron editing
Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
I don't know that I agree with this approach. This patch provides a way to clean up the mess left behind when a feature is not used. A straight forward approach would be to have an option to turn off this feature and have all related pieces go away. Instead, we have various options to hide it in different places. It doesn't make sense that if a library doesn't want a feature that we have to go to other controls and hide it. It should either be on and in use, or off, and not shown anywhere. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Andrew Fuerste-Henry from comment #5)
(In reply to Christopher Brannon from comment #4)
What about the three auto renew columns in the Circulation rules?
I'd argue that's a separate question/issue - removing an option in the patron record vs entirely hiding an option from your circ rules. Maybe file a separate bug for the option to completely hide auto-renew from the circ rules?
I would counter argue that this is not a separate question/issue. The request of this bug was a master off switch, not a request to independently hide individual parts of a feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Christopher Brannon from comment #8)
(In reply to Andrew Fuerste-Henry from comment #5)
(In reply to Christopher Brannon from comment #4)
What about the three auto renew columns in the Circulation rules?
I'd argue that's a separate question/issue - removing an option in the patron record vs entirely hiding an option from your circ rules. Maybe file a separate bug for the option to completely hide auto-renew from the circ rules?
I would counter argue that this is not a separate question/issue. The request of this bug was a master off switch, not a request to independently hide individual parts of a feature.
I think the title of this bug confused me, I read at as needing a way to disable AllowPatronToControlAutorenewal. What I am hearing from these comments is 'Auto-Renewal features need a master on/off switch' - much like ILLModule The patches here do address a bug and I think are a separate issue, would it be acceptable to move this larger request to a new bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think some granularity is good and should not stop us from having a master switch as well. Some libraries will want to use the auto-renew feature, but not want to have individual settings per user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- (In reply to Christopher Brannon from comment #0)
The AllowPatronToControlAutorenewal has a Staff or Stand and Patron setting, but it needs to be a master disable switch as well. With it in the staff only position, staff still see a switch for auto renewal in the patron settings, despite that nothing is set in the circulation rules.
It would be ideal if AllowPatronToControlAutorenewal had a Disable setting that: * hid the "Allow auto-renewal of items" choice in the Library Management settings for the patron. * hid the three columns in the circulation rules that deal with Auto Renewal.
In my opinion (for what it is worth, probably two cents only!), AllowPatronToControlAutorenewal is ok as it is, because it does what the title of the syspref says it does. I do think we need a master switch for this feature, like the ILLModule syspref. The syspref could be called simply Autorenewal. Enable/Disable the auto-renewal feature. NOTE: This system preference requires the misc/cronjobs/automatic_renewals.pl cronjob. Ask your system administrator to schedule it. NOTE: You must configure the auto-renewal settings in your circulation rules. This system preference would do what Chris said above
* hid[e] the "Allow auto-renewal of items" choice in the Library Management settings for the patron. * hid[e] the three columns in the circulation rules that deal with Auto Renewal.
A note should be added to AllowPatronToControlAutorenewal and OPACFineNoRenewalsBlockAutoRenew NOTE: This system preference has no effect if Autorenewal is set to Disable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 --- Comment #12 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Caroline Cyr La Rose from comment #11)
In my opinion (for what it is worth, probably two cents only!), AllowPatronToControlAutorenewal is ok as it is, because it does what the title of the syspref says it does. I do think we need a master switch for this feature, like the ILLModule syspref.
The syspref could be called simply Autorenewal. Enable/Disable the auto-renewal feature. NOTE: This system preference requires the misc/cronjobs/automatic_renewals.pl cronjob. Ask your system administrator to schedule it. NOTE: You must configure the auto-renewal settings in your circulation rules.
This system preference would do what Chris said above
* hid[e] the "Allow auto-renewal of items" choice in the Library Management settings for the patron. * hid[e] the three columns in the circulation rules that deal with Auto Renewal.
A note should be added to AllowPatronToControlAutorenewal and OPACFineNoRenewalsBlockAutoRenew NOTE: This system preference has no effect if Autorenewal is set to Disable.
Wondering why a completely new switch would be better than a disable option in this one. That would be like having an on/off switch for a light, and a completely separate dimmer to control it. Creating a whole new switch makes more for admins to sift through and one more thing that we have to look at to make something work and an added failure point. Unless I am missing something, it would be ideal to have the disable option in the same pref. Adding a disable option to the pref would not change the nature of the pref, and it would still do what the name of the pref says. Making admins chase down another pref to disable this pref is inefficient. ANYWHERE we can put a disable in a pref rather than having a separate pref is an improvement, in my opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- For me, AllowPatronToControlAutorenewal is a switch to add this option to the OPAC, not to enable/disable the whole feature. Which is why I thought another syspref would be the way to go. But that's just the way I understand it, it may be wrong. I honestly don't care much how it is implemented, I would have been happy with the BorrowerUnwantedFields method. But since we started upgrading clients to 20.05, I've had multiple comments on the yes/no option in the patron file. So I thought I'd comment with my thoughts and experience. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #13)
For me, AllowPatronToControlAutorenewal is a switch to add this option to the OPAC, not to enable/disable the whole feature. Which is why I thought another syspref would be the way to go.
But that's just the way I understand it, it may be wrong.
I honestly don't care much how it is implemented, I would have been happy with the BorrowerUnwantedFields method. But since we started upgrading clients to 20.05, I've had multiple comments on the yes/no option in the patron file. So I thought I'd comment with my thoughts and experience.
I totally agree with you on the master switch, that would be nice to remove complexity from the GUI for libraries not interested in automatic renewals at all. I can also imagine a disable setting for AllowPatronToControlAutoRenewal, as not everyone will probably want this type of granular per person setting. BUT BIG BUT: I don't think it should hide it from circulation rules, but only control the option in he patron record. Having auto-renewals scheduled automatically and the options to intervene for some patrons are different things. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- I jump into the discussion. Template contains : [% UNLESS noautorenew_checkouts %] Surely this column must be added to borrowers.json. Switching the all feature off is in my opinion another problem. PS : I think patch need rebase because of : Bug 11879: (follow up) Some fixes and code cleanup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 --- Comment #16 from Lucy Vaux-Harvey <lucy.vaux-harvey@ptfs-europe.com> --- (In reply to Caroline Cyr La Rose from comment #13)
For me, AllowPatronToControlAutorenewal is a switch to add this option to the OPAC, not to enable/disable the whole feature. Which is why I thought another syspref would be the way to go.
But that's just the way I understand it, it may be wrong.
I honestly don't care much how it is implemented, I would have been happy with the BorrowerUnwantedFields method. But since we started upgrading clients to 20.05, I've had multiple comments on the yes/no option in the patron file. So I thought I'd comment with my thoughts and experience.
Just adding further to Caroline's comment we are also getting frequent queries about this option at upgrades, it is causing confusion. It would be great to have a disable option so that it didn't display. I'd also agree that a master switch for auto renewals is a good idea. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #17 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- I agree that we whould have a way to set the auto-renewal on a "off" mode with the syspref. It really surprising that this option is set to "yes" when you subscribe a new patron. At least, it should be a choice in the patron category setting. Sonia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 128080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128080&action=edit Bug 29591: Add autorenew_checkouts column to preferences json Bug 24476 added autorenew_checkouts as a borrower column, intending it to be able to be hidden if a library was not using the feature. When the column chooser was added, this column was not included. To test: 1 - Search system preferences for "BorrowerUnwantedFields" 2 - Click the box to change the value 3 - "autorenew_checkouts" is not an option 4 - Confirm that you see the option to opt patron out of autorenewal when editing patron on staff side 5 - Apply patch and restart everythign 6 - Search for the syspref again 7 - Note that now you can select "autorenew_checkouts" 8 - Check the box and save 9 - Confirm the opt out option is no longer visible during patron editing Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29591 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115446|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Patch moved to 29591 - discussion here should not prevent adding of the column to controls -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 pierre.genty@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30226 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org