[Bug 19374] New: CircSidebar overlapping transferred items table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Bug ID: 19374 Summary: CircSidebar overlapping transferred items table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@jns.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 67395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67395&action=edit CircSidebar overlapping transferred items table When CircSidebar is activated, "Transferred items" table at Circulation -> Transfers goes under the sidebar. See attachment. To reproduce: 1. Activate CircSidebar system preference 2. Go to cgi-bin/koha/circ/branchtransfers.pl 3. Enter a barcode and click submit 4. Observe transferred items table under the circulation side bar -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16530 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 [Bug 16530] Add a circ sidebar navigation menu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 --- Comment #1 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 67396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67396&action=edit Bug 19374: CircSidebar overlapping transferred items table When CircSidebar is activated, "Transferred items" table at Circulation -> Transfers goes under the sidebar. This patch fixes the issue. To test: 1. Enable CircSidebar system preference 2. Go to cgi-bin/koha/circ/branchtransfers.pl 3. Enter a barcode and click submit 4. Observe transferred items table under the circulation side bar 5. Apply patch 6. Enter a barcode and click submit 7. Observe transferred items is now correctly displayed 8. Also test with CircSidebar system preference deactivated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67396|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67397&action=edit Bug 19374: CircSidebar overlapping transferred items table When CircSidebar is activated, "Transferred items" table at Circulation -> Transfers goes under the sidebar. This patch fixes the issue. To test: 1. Enable CircSidebar system preference 2. Go to cgi-bin/koha/circ/branchtransfers.pl 3. Enter a barcode and click submit 4. Observe transferred items table under the circulation side bar 5. Apply patch 6. Enter a barcode and click submit 7. Observe transferred items is now correctly displayed 8. Also test with CircSidebar system preference deactivated Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@jns.fi |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 --- Comment #3 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 67399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67399&action=edit Bug 19374: (follow-up) Remove stray closing div tag To test: 1. Apply first patch and validate the document e.g. here https://validator.w3.org/#validate_by_input 2. Observe "Stray end tag div." error 3. Apply this patch and validate again 4. Observe no errors 5. Go through test plan from first patch to make sure things still look nice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67397|0 |1 is obsolete| | Attachment #67399|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67401&action=edit Bug 19374: CircSidebar overlapping transferred items table When CircSidebar is activated, "Transferred items" table at Circulation -> Transfers goes under the sidebar. This patch fixes the issue. To test: 1. Enable CircSidebar system preference 2. Go to cgi-bin/koha/circ/branchtransfers.pl 3. Enter a barcode and click submit 4. Observe transferred items table under the circulation side bar 5. Apply patch 6. Enter a barcode and click submit 7. Observe transferred items is now correctly displayed 8. Also test with CircSidebar system preference deactivated Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Bug 19374: (follow-up) Remove stray closing div tag To test: 1. Apply first patch and validate the document e.g. here https://validator.w3.org/#validate_by_input 2. Observe "Stray end tag div." error 3. Apply this patch and validate again 4. Observe no errors 5. Go through test plan from first patch to make sure things still look nice Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches squashed for readability. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Upping severity, it impacts 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67401|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 67681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67681&action=edit Bug 19374: CircSidebar overlapping transferred items table When CircSidebar is activated, "Transferred items" table at Circulation -> Transfers goes under the sidebar. This patch fixes the issue. To test: 1. Enable CircSidebar system preference 2. Go to cgi-bin/koha/circ/branchtransfers.pl 3. Enter a barcode and click submit 4. Observe transferred items table under the circulation side bar 5. Apply patch 6. Enter a barcode and click submit 7. Observe transferred items is now correctly displayed 8. Also test with CircSidebar system preference deactivated Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Bug 19374: (follow-up) Remove stray closing div tag To test: 1. Apply first patch and validate the document e.g. here https://validator.w3.org/#validate_by_input 2. Observe "Stray end tag div." error 3. Apply this patch and validate again 4. Observe no errors 5. Go through test plan from first patch to make sure things still look nice Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.06. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Depend on bug 16530 which is not part of 16.11.x, skipping. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19374 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org