[Bug 39967] New: When LoadSearchHistoryToTheFirstLoggedUser is enabled, search history is added at every page load
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39967 Bug ID: 39967 Summary: When LoadSearchHistoryToTheFirstLoggedUser is enabled, search history is added at every page load Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Steps to reproduce: 1. Enable LoadSearchHistoryToTheFirstLoggedUser and EnableOpacSearchHistory 2. Go to OPAC. If logged in, log out. 3. Go to search history and remove all searches if any. 4. Perform a search, make sure it appears in your search history 5. Log in and go to your search history. See that your unauthenticated search history has been added to your account's search history 6. Reload the page multiple times. See that the unauthenticated search history is re-added after each page reload, making your search history grow every time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39967 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 182724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182724&action=edit Bug 39967: Reload session after modification Otherwise the existing $session still holds outdated data that is written on the next flush, which overwrites what has been set by C4::Search::History::set_to_session Test plan: 1. Enable LoadSearchHistoryToTheFirstLoggedUser and EnableOpacSearchHistory 2. Go to OPAC. If logged in, log out. 3. Go to search history and remove all searches if any. 4. Perform a search, make sure it appears in your search history 5. Log in and go to your search history. See that your unauthenticated search history has been added to your account's search history 6. Reload the page multiple times. See that the unauthenticated search history is *NOT* re-added after each page reload -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39967 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39967 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39967 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182724|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 182738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182738&action=edit Bug 39967: Reload session after modification Otherwise the existing $session still holds outdated data that is written on the next flush, which overwrites what has been set by C4::Search::History::set_to_session Test plan: 1. Enable LoadSearchHistoryToTheFirstLoggedUser and EnableOpacSearchHistory 2. Go to OPAC. If logged in, log out. 3. Go to search history and remove all searches if any. 4. Perform a search, make sure it appears in your search history 5. Log in and go to your search history. See that your unauthenticated search history has been added to your account's search history 6. Reload the page multiple times. See that the unauthenticated search history is *NOT* re-added after each page reload Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39967 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the search release notes| |history recorded in the | |OPAC. The search | |history--before logging in | |to the OPAC--was duplicated | |every time after you log in | |AND reloaded the search | |history page (Your account | |> Search history). CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. The system preferences are already enabled in KTD. 2. Replicate the problem using the steps in the bug description. 3. Apply the patch, reset_all, and run through the steps in the patch to show that it is fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39967 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi Julian, Two questions: [1] This is a one-liner and I understand that it may be hard to add a test for this tiny change? Could you confirm? [2] I have the idea that we could test before calling get_session if we had searches before. Otherwise it seems unneeded? Changing status for need of feedback or adjustments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39967 Lucy Vaux-Harvey <lucy.vaux-harvey@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@openfifth. | |co.uk --- Comment #5 from Lucy Vaux-Harvey <lucy.vaux-harvey@openfifth.co.uk> --- This continues to be an issue, it would be great to get a fix in place. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org