[Bug 19550] New: Add links to related authorities for UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 Bug ID: 19550 Summary: Add links to related authorities for UNIMARC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Links exist in search results for MARC21 but not for UNIMARC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 68856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68856&action=edit Bug 19550: Add links to related authorities for UNIMARC Links exist in search results for MARC21 but not for UNIMARC. This patch fixes that. Test plan: 1. Create an authority with a field 550 that links to another authority e.g. 550 $a Foo $9 42 2. Reindex this authority 3. Search for this authority 4. See that you now have a link "Foo" to authorities/detail.pl?authid=42 in the summary -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 acovaliov@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acovaliov@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by delaye <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 72871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72871&action=edit Bug 19550: Add links to related authorities for UNIMARC Links exist in search results for MARC21 but not for UNIMARC. This patch fixes that. Test plan: 1. Create an authority with a field 550 that links to another authority e.g. 550 $a Foo $9 42 2. Reindex this authority 3. Search for this authority 4. See that you now have a link "Foo" to authorities/detail.pl?authid=42 in the summary Signed-off-by: delaye <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Failing a bit getting a UNIMARC db up right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72871|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 78089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78089&action=edit Bug 19550: Add links to related authorities for UNIMARC Links exist in search results for MARC21 but not for UNIMARC. This patch fixes that. Test plan: 1. Create an authority with a field 550 that links to another authority e.g. 550 $a Foo $9 42 2. Reindex this authority 3. Search for this authority 4. See that you now have a link "Foo" to authorities/detail.pl?authid=42 in the summary Signed-off-by: delaye <stephane.delaye@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ended up testing on a sandbox, but worked well there :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- I think the template variables need the $raw filter, they are set within the templaet itself so should be safe, but we need filters to keep tests happy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78490&action=edit Bug 19550: (RM follow-up) Add filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- I can't get a UNIMARC db working right now, can you verify the followup works Julian? If so I will push -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 78530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78530&action=edit Bug 19550: (QA follow-up on RM follow-up) Add missing [% USE %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Nick Clemens from comment #9)
I can't get a UNIMARC db working right now, can you verify the followup works Julian? If so I will push
With my additional follow-up, it works ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported t 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19550 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nick, I think the filter should be 'url', not raw -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org