[Bug 27634] New: Turn off patron self-registration if no default category is set
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Bug ID: 27634 Summary: Turn off patron self-registration if no default category is set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 27626 If there is no default category defined in PatronSelfRegistrationDefaultCategory the full feature must be displayed. We already hide the link from the OPAC main page, but the form is still accessible. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27626 [Bug 27626] Patron self-registration breaks if categorycode and password are hidden -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116378&action=edit Bug 27634: Turn off patron self-registration if no default category is set If there is no default category defined in PatronSelfRegistrationDefaultCategory the full feature must be displayed. We already hide the link from the OPAC main page, but the form is still accessible. Test plan (for the whole patch set): 1. Turn on PatronSelfRegistration 2. Don't set PatronSelfRegistrationDefaultCategory 3. Go to the OPAC main page and confirm that the "Register here" link is not displayed 4. Hit opac-memberentry.pl and confirm that you are redirected to the OPAC main page 5. Go to the about page and confirm that you see a warning in the "System information" tab 6. Set PatronSelfRegistrationDefaultCategory to an invalid patron's category 7. Repeat 3, 4, 5 8. Set PatronSelfRegistrationDefaultCategory to a valid patron's category 9. Self-register a patron and confirm it works as expected 10. Edit PatronSelfRegistrationBorrowerUnwantedField and confirm that you cannot remove dateexpiry and categorycode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116379&action=edit Bug 27634: Force include categorycode to PatronSelfRegistrationBorrowerUnwantedField We should always use the category defined in PatronSelfRegistrationDefaultCategory. This could be discussed however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116380&action=edit Bug 27634: Add the ability to exclude fields from "modal" sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116381&action=edit Bug 27634: Force include of dateexpiry Otherwise we see a "Date expiry" entry in the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116382&action=edit Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116383&action=edit Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Sorry Jonathan! For step 7-3, if I set an invalid patron category the registration link is displayed "Don't have an account? Register here.". Everything else works as per the test plan. I don't know hard it is to do, but could making a PatronSelfRegistrationDefaultCategory a drop down list of existing patron category codes remove the problem of invalid patron codes? It may be out of scope for this bug though. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650 [Bug 27650] Wrong variable passed to the template in opac-main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116491&action=edit Bug 27634: Fix Link on the OPAC main page Make sure the pref is filled with a valid patron's category to display the "register" link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to David Nind from comment #7)
Sorry Jonathan!
No worries, thanks for testing, David!
For step 7-3, if I set an invalid patron category the registration link is displayed "Don't have an account? Register here.".
Fixed!
I don't know hard it is to do, but could making a PatronSelfRegistrationDefaultCategory a drop down list of existing patron category codes remove the problem of invalid patron codes? It may be out of scope for this bug though.
That can be done quite easily I think. You should open a new bug report :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> ---
I don't know hard it is to do, but could making a PatronSelfRegistrationDefaultCategory a drop down list of existing patron category codes remove the problem of invalid patron codes? It may be out of scope for this bug though.
That can be done quite easily I think. You should open a new bug report :)
Bug 27652 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from David Nind <david@davidnind.com> --- I was too slow retesting, the patch no longer applies 8-( ... Applying: Bug 27634: Turn off patron self-registration if no default category is set error: sha1 information is lacking or useless (opac/opac-memberentry.pl). error: could not build fake ancestor Patch failed at 0001 Bug 27634: Turn off patron self-registration if no default category is set ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Bug 27634 depends on bug 27650, which changed state. Bug 27650 Summary: Wrong variable passed to the template in opac-main https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have the same issue: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27634: Turn off patron self-registration if no default category is set error: sha1 information is lacking or useless (opac/opac-memberentry.pl). error: could not build fake ancestor Patch failed at 0001 Bug 27634: Turn off patron self-registration if no default category is set hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-27634-Turn-off-patron-self-registration-if-no--ILoEWc.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116378|0 |1 is obsolete| | Attachment #116379|0 |1 is obsolete| | Attachment #116380|0 |1 is obsolete| | Attachment #116381|0 |1 is obsolete| | Attachment #116382|0 |1 is obsolete| | Attachment #116383|0 |1 is obsolete| | Attachment #116491|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145599&action=edit Bug 27634: Turn off patron self-registration if no default category is set If there is no default category defined in PatronSelfRegistrationDefaultCategory the full feature must be displayed. We already hide the link from the OPAC main page, but the form is still accessible. Test plan (for the whole patch set): 1. Turn on PatronSelfRegistration 2. Don't set PatronSelfRegistrationDefaultCategory 3. Go to the OPAC main page and confirm that the "Register here" link is not displayed 4. Hit opac-memberentry.pl and confirm that you are redirected to the OPAC main page 5. Go to the about page and confirm that you see a warning in the "System information" tab 6. Set PatronSelfRegistrationDefaultCategory to an invalid patron's category 7. Repeat 3, 4, 5 8. Set PatronSelfRegistrationDefaultCategory to a valid patron's category 9. Self-register a patron and confirm it works as expected 10. Edit PatronSelfRegistrationBorrowerUnwantedField and confirm that you cannot remove dateexpiry and categorycode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145600&action=edit Bug 27634: Force include categorycode to PatronSelfRegistrationBorrowerUnwantedField We should always use the category defined in PatronSelfRegistrationDefaultCategory. This could be discussed however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145601&action=edit Bug 27634: Add the ability to exclude fields from "modal" sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145602&action=edit Bug 27634: Force include of dateexpiry Otherwise we see a "Date expiry" entry in the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145603&action=edit Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145604&action=edit Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145605&action=edit Bug 27634: Fix Link on the OPAC main page Make sure the pref is filled with a valid patron's category to display the "register" link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from David Nind <david@davidnind.com> --- I had an issue with: - Steps 6 and 7: if there is an invalid patron category, there should be no "Register here" link - Step 10: dateexpiry and categorycode fields Steps 6 and 7 - if there is an invalid patron category, there should be no "Register here" link ============== 1. PatronSelfRegistrationDefaultCategory is now a dropdown list, so I couldn't set an invalid patron category that way. 2. Instead, I updated in the database: update systempreferences set value="InvalidValue" where variable="PatronSelfRegistrationDefaultCategory"; 3. With an invalid patron category, the "Don't have an account? Register here." text still shows when you click on "Log in to your account", although it redirects you to the home page if you click on it. 4. There is a system warning: "System preference 'PatronSelfRegistration' is set but 'PatronSelfRegistrationDefaultCategory' does not contain a valid patron category code. Patron self-registration is disabled." Step 10 - dateexpiry and categorycode fields ============== When I first go into PatronSelfRegistrationBorrowerUnwantedField, the dateexpiry and categorycode fields are selectable. If I select them and save, and then go in again, they are greyed out with a tick and can't be toggled off or on again. Other testing notes (using KTD) =============================== 1. After applying the patch, run updatedatabase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145605|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 145922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145922&action=edit Bug 27634: Hide "Register here" links Make sure the pref is filled with a valid patron's category to display the "register" link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Nind from comment #20)
I had an issue with: - Steps 6 and 7: if there is an invalid patron category, there should be no "Register here" link
I dealt with the main page only. The new page is hiding all "register here" links.
- Step 10: dateexpiry and categorycode fields
I am not sure I understand, what you are describing is the expected behaviour: we want to force categorycode and dateexpiry in PatronSelfRegistrationBorrowerUnwantedField (and so prevent their removal). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 17987 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- We can get this one moving again please? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|aleisha@catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145599|0 |1 is obsolete| | Attachment #145600|0 |1 is obsolete| | Attachment #145601|0 |1 is obsolete| | Attachment #145602|0 |1 is obsolete| | Attachment #145603|0 |1 is obsolete| | Attachment #145604|0 |1 is obsolete| | Attachment #145922|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147531&action=edit Bug 27634: Turn off patron self-registration if no default category is set If there is no default category defined in PatronSelfRegistrationDefaultCategory the full feature must be displayed. We already hide the link from the OPAC main page, but the form is still accessible. Test plan (for the whole patch set): 1. Turn on PatronSelfRegistration 2. Don't set PatronSelfRegistrationDefaultCategory 3. Go to the OPAC main page and confirm that the "Register here" link is not displayed 4. Hit opac-memberentry.pl and confirm that you are redirected to the OPAC main page 5. Go to the about page and confirm that you see a warning in the "System information" tab 6. Set PatronSelfRegistrationDefaultCategory to an invalid patron's category 7. Repeat 3, 4, 5 8. Set PatronSelfRegistrationDefaultCategory to a valid patron's category 9. Self-register a patron and confirm it works as expected 10. Edit PatronSelfRegistrationBorrowerUnwantedField and confirm that you cannot remove dateexpiry and categorycode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147532&action=edit Bug 27634: Force include categorycode to PatronSelfRegistrationBorrowerUnwantedField We should always use the category defined in PatronSelfRegistrationDefaultCategory. This could be discussed however. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147533&action=edit Bug 27634: Add the ability to exclude fields from "modal" sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147534&action=edit Bug 27634: Force include of dateexpiry Otherwise we see a "Date expiry" entry in the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147535&action=edit Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147536&action=edit Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147537&action=edit Bug 27634: Hide "Register here" links Make sure the pref is filled with a valid patron's category to display the "register" link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #32 from David Nind <david@davidnind.com> --- The patches no longer apply 8-(.. git bz apply 27634 Bug 27634 - Turn off patron self-registration if no default category is set 147531 - Bug 27634: Turn off patron self-registration if no default category is set 147532 - Bug 27634: Force include categorycode to PatronSelfRegistrationBorrowerUnwantedField 147533 - Bug 27634: Add the ability to exclude fields from "modal" sysprefs 147534 - Bug 27634: Force include of dateexpiry 147535 - Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set 147536 - Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value 147537 - Bug 27634: Hide "Register here" links Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 27634: Turn off patron self-registration if no default category is set Applying: Bug 27634: Force include categorycode to PatronSelfRegistrationBorrowerUnwantedField Applying: Bug 27634: Add the ability to exclude fields from "modal" sysprefs Applying: Bug 27634: Force include of dateexpiry Applying: Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set Using index info to reconstruct a base tree... M about.pl M koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/about.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/about.tt Auto-merging about.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147535|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149746&action=edit Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147536|0 |1 is obsolete| | --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149747&action=edit Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147537|0 |1 is obsolete| | --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 149748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149748&action=edit Bug 27634: Hide "Register here" links Make sure the pref is filled with a valid patron's category to display the "register" link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147531|0 |1 is obsolete| | --- Comment #36 from David Nind <david@davidnind.com> --- Created attachment 149896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149896&action=edit Bug 27634: Turn off patron self-registration if no default category is set If there is no default category defined in PatronSelfRegistrationDefaultCategory the full feature must be displayed. We already hide the link from the OPAC main page, but the form is still accessible. Test plan (for the whole patch set): 1. Turn on PatronSelfRegistration 2. Don't set PatronSelfRegistrationDefaultCategory 3. Go to the OPAC main page and confirm that the "Register here" link is not displayed 4. Hit opac-memberentry.pl and confirm that you are redirected to the OPAC main page 5. Go to the about page and confirm that you see a warning in the "System information" tab 6. Set PatronSelfRegistrationDefaultCategory to an invalid patron's category 7. Repeat 3, 4, 5 8. Set PatronSelfRegistrationDefaultCategory to a valid patron's category 9. Self-register a patron and confirm it works as expected 10. Edit PatronSelfRegistrationBorrowerUnwantedField and confirm that you cannot remove dateexpiry and categorycode Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147532|0 |1 is obsolete| | --- Comment #37 from David Nind <david@davidnind.com> --- Created attachment 149897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149897&action=edit Bug 27634: Force include categorycode to PatronSelfRegistrationBorrowerUnwantedField We should always use the category defined in PatronSelfRegistrationDefaultCategory. This could be discussed however. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147533|0 |1 is obsolete| | --- Comment #38 from David Nind <david@davidnind.com> --- Created attachment 149898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149898&action=edit Bug 27634: Add the ability to exclude fields from "modal" sysprefs Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147534|0 |1 is obsolete| | --- Comment #39 from David Nind <david@davidnind.com> --- Created attachment 149899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149899&action=edit Bug 27634: Force include of dateexpiry Otherwise we see a "Date expiry" entry in the form. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149746|0 |1 is obsolete| | --- Comment #40 from David Nind <david@davidnind.com> --- Created attachment 149900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149900&action=edit Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149747|0 |1 is obsolete| | --- Comment #41 from David Nind <david@davidnind.com> --- Created attachment 149901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149901&action=edit Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149748|0 |1 is obsolete| | --- Comment #42 from David Nind <david@davidnind.com> --- Created attachment 149902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149902&action=edit Bug 27634: Hide "Register here" links Make sure the pref is filled with a valid patron's category to display the "register" link Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #43 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. For step 7, to set an invalid patron category: 1.1 koha-mysql kohadev 1.2 SQL query: update systempreferences set value = "INVALID" where variable = "PatronSelfRegistrationDefaultCategory"; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149896|0 |1 is obsolete| | --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150083&action=edit Bug 27634: Turn off patron self-registration if no default category is set If there is no default category defined in PatronSelfRegistrationDefaultCategory the full feature must be displayed. We already hide the link from the OPAC main page, but the form is still accessible. Test plan (for the whole patch set): 1. Turn on PatronSelfRegistration 2. Don't set PatronSelfRegistrationDefaultCategory 3. Go to the OPAC main page and confirm that the "Register here" link is not displayed 4. Hit opac-memberentry.pl and confirm that you are redirected to the OPAC main page 5. Go to the about page and confirm that you see a warning in the "System information" tab 6. Set PatronSelfRegistrationDefaultCategory to an invalid patron's category 7. Repeat 3, 4, 5 8. Set PatronSelfRegistrationDefaultCategory to a valid patron's category 9. Self-register a patron and confirm it works as expected 10. Edit PatronSelfRegistrationBorrowerUnwantedField and confirm that you cannot remove dateexpiry and categorycode Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149897|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150084&action=edit Bug 27634: Force include categorycode to PatronSelfRegistrationBorrowerUnwantedField We should always use the category defined in PatronSelfRegistrationDefaultCategory. This could be discussed however. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149898|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150085&action=edit Bug 27634: Add the ability to exclude fields from "modal" sysprefs Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149899|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150086&action=edit Bug 27634: Force include of dateexpiry Otherwise we see a "Date expiry" entry in the form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149900|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150087&action=edit Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149901|0 |1 is obsolete| | --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150088&action=edit Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149902|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150089&action=edit Bug 27634: Hide "Register here" links Make sure the pref is filled with a valid patron's category to display the "register" link Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150090&action=edit Bug 27634: (QA follow-up) Add punctuation to message on About page This just adds some missing commas and turns a pref into preference in the messages displayed on the system information tab. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150087|0 |1 is obsolete| | Attachment #150088|0 |1 is obsolete| | Attachment #150089|0 |1 is obsolete| | Attachment #150090|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151046&action=edit Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #53 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151047&action=edit Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151048&action=edit Bug 27634: Hide "Register here" links Make sure the pref is filled with a valid patron's category to display the "register" link Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #55 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151049&action=edit Bug 27634: (QA follow-up) Add punctuation to message on About page This just adds some missing commas and turns a pref into preference in the messages displayed on the system information tab. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #56 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Trivial rebase (about.tt) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #57 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Can you please rebase ASAP? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150083|0 |1 is obsolete| | Attachment #150084|0 |1 is obsolete| | Attachment #150085|0 |1 is obsolete| | Attachment #150086|0 |1 is obsolete| | Attachment #151046|0 |1 is obsolete| | Attachment #151047|0 |1 is obsolete| | Attachment #151048|0 |1 is obsolete| | Attachment #151049|0 |1 is obsolete| | --- Comment #58 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155863&action=edit Bug 27634: Turn off patron self-registration if no default category is set If there is no default category defined in PatronSelfRegistrationDefaultCategory the full feature must be displayed. We already hide the link from the OPAC main page, but the form is still accessible. Test plan (for the whole patch set): 1. Turn on PatronSelfRegistration 2. Don't set PatronSelfRegistrationDefaultCategory 3. Go to the OPAC main page and confirm that the "Register here" link is not displayed 4. Hit opac-memberentry.pl and confirm that you are redirected to the OPAC main page 5. Go to the about page and confirm that you see a warning in the "System information" tab 6. Set PatronSelfRegistrationDefaultCategory to an invalid patron's category 7. Repeat 3, 4, 5 8. Set PatronSelfRegistrationDefaultCategory to a valid patron's category 9. Self-register a patron and confirm it works as expected 10. Edit PatronSelfRegistrationBorrowerUnwantedField and confirm that you cannot remove dateexpiry and categorycode Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #59 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155864&action=edit Bug 27634: Force include categorycode to PatronSelfRegistrationBorrowerUnwantedField We should always use the category defined in PatronSelfRegistrationDefaultCategory. This could be discussed however. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #60 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155865&action=edit Bug 27634: Add the ability to exclude fields from "modal" sysprefs Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #61 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155866&action=edit Bug 27634: Force include of dateexpiry Otherwise we see a "Date expiry" entry in the form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #62 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155867&action=edit Bug 27634: Add a warning to the about page if PatronSelfRegistrationDefaultCategory not set Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #63 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155868&action=edit Bug 27634: Update PatronSelfRegistrationBorrowerUnwantedField's value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #64 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155869&action=edit Bug 27634: Hide "Register here" links Make sure the pref is filled with a valid patron's category to display the "register" link Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #65 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155870&action=edit Bug 27634: (QA follow-up) Add punctuation to message on About page This just adds some missing commas and turns a pref into preference in the messages displayed on the system information tab. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #66 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 --- Comment #67 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156203&action=edit Bug 27634: Fix self_registration.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_23_11_candidate |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #68 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #69 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 23.05.x Looks like some changes come from Bug 27378 Since it impacts preferences it may be risky for stable branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |When there is no valid release notes| |patron category defined in | |system preference | |PatronSelfRegistrationDefau | |ltCategory the full feature | |is disabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27634 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/906 --- Comment #70 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Added a note in the manual to say that PatronSelfRegistrationDefaultCategory is required for PatronSelfRegistration. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org