[Bug 27498] New: Add a link for the Hold Ratios to Acquisitions home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Bug ID: 27498 Summary: Add a link for the Hold Ratios to Acquisitions home page Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: barbara.johnson@bedfordtx.gov QA Contact: testopia@bugs.koha-community.org In our library viewing the Hold Ratios is more a function of Acquisitions than Circulation. It would be helpful to add a link to the Hold Ratios on the Acquisitions home page so that staff doesn't have to go to the Circulation home page to access. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |Templates Keywords| |Academy Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|20.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- It's always confused me that Holds Ratio is in circ. I'd be in favor of moving it to acq entirely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Margaret Hade <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret@bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116249&action=edit Bug 27498: Add a link for the Hold Ratios to Acquisitions home page This patch adds a link to the hold ratios report in the Acquisitions sidebar menu under the "reports" heading. To test, apply the patch and go to Acquisitions. The link to the hold ratios report should be there and it should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116249|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 116407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116407&action=edit Bug 27498: Add a link for the Hold Ratios to Acquisitions home page This patch adds a link to the hold ratios report in the Acquisitions sidebar menu under the "reports" heading. To test, apply the patch and go to Acquisitions. The link to the hold ratios report should be there and it should work correctly. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I signed off because the link was where it was supposed to be and it correctly went to the holds ratio page. I did want to point out that I placed a bunch of holds that should have triggered results in the holds ratio report but did not in case that's an issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Summary|Add a link for the Hold |Add a link for the hold |Ratios to Acquisitions home |ratios to acquisitions home |page |page --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, I believe the permission check is not quite right. The hold ratios page is asking for circulation_remaining_permissions. Can you please check? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116407|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116616&action=edit Bug 27498: Add a link for the Hold Ratios to Acquisitions home page This patch adds a link to the hold ratios report in the Acquisitions sidebar menu under the "reports" heading. To test, apply the patch and go to Acquisitions. The link to the hold ratios report should be there and it should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 --- Comment #7 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I've tried testing this bug several times in a sandbox and I'm getting an error with the patch applied and even without it applied. The error starts out with the below statement and then lists 56 specific errors. I'm unable to test until something gets fixed. Plack::App::WrapCGI::call(): DBI Exception: DBD::mysql::st execute failed: 'koha_bug27498.reserves.reservedate' isn't in GROUP BY [for Statement "SELECT reservedate . . . . . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #8 from David Nind <david@davidnind.com> --- Can confirm that before the patch is applied on master using koha-testing-docker that there is a system error when clicking on Circulation > Holds ratios. Tested Koha 20.11.x and it works then, so something has broken it. The same error is recorded in Bug 21941 but that was created in 2018! I'm not smart enough to figure out what bug was introduced after 20.11.x that is causing it... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17258 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The GROUP BY type of error is usually related to using scrict MySQL settings. I'll link it to the omnibus. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116616|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 118565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118565&action=edit Bug 27498: Add a link for the Hold Ratios to Acquisitions home page This patch adds a link to the hold ratios report in the Acquisitions sidebar menu under the "reports" heading. To test, apply the patch and go to Acquisitions. The link to the hold ratios report should be there and it should work correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 118566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118566&action=edit Bug 27498: (follow-up) Update to display logic Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- @David and Barbara I think the problem you are seeing is another bug, not related to this patch. Could you check you see the same error when opening the report from the circulation start page please and make a report if you do? @Owen I've taken a look and have a suggestion to change up the logic a bit to avoid repeating the link. Could you have a look if you like it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118566|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 118567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118567&action=edit Bug 27498: (follow-up) Update to display logic Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org --- Comment #14 from koha-US bug tracker <bugzilla@koha-us.org> --- @Katrin I’m still getting the same error I reported in comment #7 when clicking on the link from the circ start page and the new link from acq home page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to koha-US bug tracker from comment #14)
@Katrin I’m still getting the same error I reported in comment #7 when clicking on the link from the circ start page and the new link from acq home page.
Yes, it means the error is unrelaed - this only adds a link in another spot. We need to file a bug for what you reported in comment#7 separately. Btw - I don't see it, but I think that just means that my setup is a little different. I suspect a MySQL/MariaDB issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21941 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I realized there already is a report for it that David pointed out: bug 21941 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Amit Gupta <amitddng135@gmail.com> --- Not able to apply the second patch Bug 27498: (follow-up) Update to display logic Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -------------------------- Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all: a Applying: Bug 27498: (follow-up) Update to display logic fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-menu.inc). error: could not build fake ancestor Patch failed at 0001 Bug 27498: (follow-up) Update to display logic The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Amit, can you make sure your branch is current master? I am not sure why the first woudl apply but the second not. Are you using git bz? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118565|0 |1 is obsolete| | Attachment #118567|0 |1 is obsolete| | --- Comment #19 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 118709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118709&action=edit Bug 27498: Add a link for the Hold Ratios to Acquisitions home page This patch adds a link to the hold ratios report in the Acquisitions sidebar menu under the "reports" heading. To test, apply the patch and go to Acquisitions. The link to the hold ratios report should be there and it should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 --- Comment #20 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 118710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118710&action=edit Bug 27498: (follow-up) Update to display logic Hi Katrin, Sorry applied one patch only. Now applied both the patches and working fine. Now giving signoff. Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |link to the hold ratios | |report in the Acquisitions | |sidebar menu under the | |reports heading. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118709|0 |1 is obsolete| | Attachment #118710|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120707&action=edit Bug 27498: Add a link for the Hold Ratios to Acquisitions home page This patch adds a link to the hold ratios report in the Acquisitions sidebar menu under the "reports" heading. To test, apply the patch and go to Acquisitions. The link to the hold ratios report should be there and it should work correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120708&action=edit Bug 27498: (follow-up) Update to display logic Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Amit Gupta <amitddng135@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.11.00 |21.11.00,21.05.02 released in| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27498 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not impact display on oldstable 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org