http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 33246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33246&action=edit Bug 13204: Plugin housekeeping: Remove labs_theses.pl plugin As it seems, this plugin has been created for UNIMARC field 328 (Dissertation note). It refers to authval category LABTHE. The plugin seems however not to be used: it contains several critical errors. I tried a quick fix but it was not good enough. Since the code can be recovered from git (if needed), a real fix can always follow this patch. What are some problems: [1] The path to the template is wrong. Should be cataloguing/value_builder [2] The plugin parameter $input is not used. A new CGI object is created. [3] Resolving errors 1 and 2 still results in premature end of script headers. [4] Not sure whether the plugin can effectively handle missing LABTHE values. Instead of keeping this in Koha, I opt for removing it for now. As additional argument I would mention that labs_theses does not have Focus or Blur actions, only the Click action that does not work. Test plan: Git grep on labs_theses. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Instead of a signoff, a counterpatch is welcome too :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to Jonathan Druart from comment #3)

Paul, this plugin (labs_theses.pl) comes from BibLibre. It uses the (non-existent) LABTHE authorised values. Any idea if it is still used somewhere?

Look at in2p3 staff interface (one of BibLibre customer), if it's not here, it must be frantiq (which is no more one of our customer, I think it's a Frederic Demian one, adding him) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Frédéric Demians from comment #5)

I haven't any customer using this plugin, and I'm not aware of any library using it. For me, this patch could be signed-off without trouble. I can dot it if necessary.

If you can, thanks. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33246|0 |1 is obsolete| | --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 34031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34031&action=edit Bug 13204: Plugin housekeeping: Remove labs_theses.pl plugin As it seems, this plugin has been created for UNIMARC field 328 (Dissertation note). It refers to authval category LABTHE. The plugin seems however not to be used: it contains several critical errors. I tried a quick fix but it was not good enough. Since the code can be recovered from git (if needed), a real fix can always follow this patch. What are some problems: [1] The path to the template is wrong. Should be cataloguing/value_builder [2] The plugin parameter $input is not used. A new CGI object is created. [3] Resolving errors 1 and 2 still results in premature end of script headers. [4] Not sure whether the plugin can effectively handle missing LABTHE values. Instead of keeping this in Koha, I opt for removing it for now. As additional argument I would mention that labs_theses does not have Focus or Blur actions, only the Click action that does not work. Test plan: Git grep on labs_theses. Signed-off-by: Frederic Demians <f.demians@tamil.fr> This antique plugin deserves to live forever in Git Historical Museum. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)

I have just contacted a library who use this plugin (or at least contain the LABTHE VA). Could you please provide more details on how we can proceed now?

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Please don't push this for the moment. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Plugin housekeeping: Remove |[WAITS_FOR_RESPONSE] Plugin |labs_theses.pl plugin |housekeeping: Remove | |labs_theses.pl plugin -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #13)

The plugin did the same thing as when a field is linked to a list of AV. It's useless and can be removed. Switch back to Passed QA.

Thanks for your attention. -- You are receiving this mail because: You are watching all bug changes.