[Bug 30159] New: Fix display of validation of important fields when biblio cataloguing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Bug ID: 30159 Summary: Fix display of validation of important fields when biblio cataloguing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Created attachment 131029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131029&action=edit Popup box showing HTML dump of validation for important fields Fields that are marked as important in a biblio framework will trigger a confirmation box to the cataloguer if not filled, asking if they would still like to save. Since Bug 28694, the validation for mandatory fields is nice and pretty, but it appears the validation for important fields was not tested. The confirmation pop-up now spits out the HTML markup and is unreadable. This should be fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28694 Status|NEW |Needs Signoff Patch complexity|--- |Small patch Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 [Bug 28694] Check alert in cataloguing should be a static message -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 131030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131030&action=edit Bug 30159: Fix Check() to validate both mandatory and important fields This patch adds a check for both mandatory and important fields when validating bibliographic records during cataloguing. To test: 1. Go to Admin -> Biblio frameworks. View the MARC structure of your default framework. 2. Search for tag 082. Edit the subfields for this tag. 3. Check the 'important' checkbox for subfield a and Save. 4. Go to add or edit a new biblio record under Cataloguing. 5. Ensure the 082$a field is empty and hit Save. 6. Notice the confirmation pop-up is an unreadable display of HTML. 7. Click Cancel on the pop-up box. 8. Apply the patch and refresh the editor page. 9. Ensure the 082$a field is empty and hit Save. 10. Notice the confirmation pop-up is more helpful this time. Click Cancel on the pop-up box. 11. Notice the 082$a field is displayed at the top of the page as an important field that is missing information. Use the 'go to field' link and confirm this works as expected. 12. Leave 082$a empty and hit Save. 13. This time click OK on the confirmation pop-up. Confirm you are able to save your record as normal. Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a check for release notes| |both mandatory and | |important fields when | |validating bibliographic | |records during cataloguing. Assignee|koha-bugs@lists.koha-commun |adam.styles@esa.edu.au |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I've attached this patch on behalf of Adam Styles, who is the assignee. The author line on the patch is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131030|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131034&action=edit Bug 30159: Fix Check() to validate both mandatory and important fields This patch adds a check for both mandatory and important fields when validating bibliographic records during cataloguing. To test: 1. Go to Admin -> Biblio frameworks. View the MARC structure of your default framework. 2. Search for tag 082. Edit the subfields for this tag. 3. Check the 'important' checkbox for subfield a and Save. 4. Go to add or edit a new biblio record under Cataloguing. 5. Ensure the 082$a field is empty and hit Save. 6. Notice the confirmation pop-up is an unreadable display of HTML. 7. Click Cancel on the pop-up box. 8. Apply the patch and refresh the editor page. 9. Ensure the 082$a field is empty and hit Save. 10. Notice the confirmation pop-up is more helpful this time. Click Cancel on the pop-up box. 11. Notice the 082$a field is displayed at the top of the page as an important field that is missing information. Use the 'go to field' link and confirm this works as expected. 12. Leave 082$a empty and hit Save. 13. This time click OK on the confirmation pop-up. Confirm you are able to save your record as normal. Sponsored-by: Education Services Australia SCIS Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 131365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131365&action=edit Bug 30159: (follow-up) Make warning messages consistent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As the follow-up is only a text change, I am resetting to signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131034|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131411&action=edit Bug 30159: Fix Check() to validate both mandatory and important fields This patch adds a check for both mandatory and important fields when validating bibliographic records during cataloguing. To test: 1. Go to Admin -> Biblio frameworks. View the MARC structure of your default framework. 2. Search for tag 082. Edit the subfields for this tag. 3. Check the 'important' checkbox for subfield a and Save. 4. Go to add or edit a new biblio record under Cataloguing. 5. Ensure the 082$a field is empty and hit Save. 6. Notice the confirmation pop-up is an unreadable display of HTML. 7. Click Cancel on the pop-up box. 8. Apply the patch and refresh the editor page. 9. Ensure the 082$a field is empty and hit Save. 10. Notice the confirmation pop-up is more helpful this time. Click Cancel on the pop-up box. 11. Notice the 082$a field is displayed at the top of the page as an important field that is missing information. Use the 'go to field' link and confirm this works as expected. 12. Leave 082$a empty and hit Save. 13. This time click OK on the confirmation pop-up. Confirm you are able to save your record as normal. Sponsored-by: Education Services Australia SCIS Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131365|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131412&action=edit Bug 30159: (follow-up) Make warning messages consistent Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131413&action=edit Bug 30159: (QA follow-up) Fix translatability of alert message Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Adam, thx for your patch! Be careful when working with the JavaScript message. We do need the _("") or __("") in JS files to make strings translatable. I fixed this line in my follow-up: + var r=confirm("Important fields(s) are not filled. Are you sure you want to save?"); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Woohoo! Congrats Adam on your first patch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30482 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30482 [Bug 30482] Fix display of validation of important fields when biblio cataloguing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30159 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |andrew@bywatersolutions.com --- Comment #13 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org