[Bug 39981] New: Patron extended attribute search only available at patrons page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39981 Bug ID: 39981 Summary: Patron extended attribute search only available at patrons page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: mikko.liimatainen@turku.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When you have selected patron attribute to be searchable in staff patron searches, this can only be done in the patrons page. However there are many other pages that have the patron search box available where you can't search with the extended patron attributes. I think patron attribute search should be available always when patron search is available. It would be more consistent with the description of the preference. "Check to make this attribute searchable in staff patron searches. If checked, this attribute will appear in patron search dropdowns." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39981 --- Comment #1 from Mikko Liimatainen <mikko.liimatainen@turku.fi> --- I do think this can be fixed by adding [% USE ExtendedAttributeTypes %] to member-search-box.inc. I did try this fix and it seemed to work but I am not a coder and haven't read through the coding guidelines yet so maybe this isn't the preferred way of doing things. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39981 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | Status|NEW |ASSIGNED CC| |emmi.takkinen@koha-suomi.fi --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- As Mikko suggested, adding [% USE ExtendedAttributeTypes %] to member-search-box.inc should be enough. Patron search from top bar calls patron-search.inc which already has all necessary code needed for patron extended attribute search to work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39981 --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 199284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199284&action=edit Bug 39981: Allow searching with patron extended attribute with top bar Currently searching patrons with patron extended attribute only works from patron search page unless attribute has "Search by default" preference turned on. This patch adds patron attributes as search options for top bar "Search patrons" functionality. To test: 1. Add new patron extended attribute, don't enable "Search by default" preference for it. 2. Add this attribute for a patron. 3. Attempt to search patron with the new attribute from top bar search. => Note that there is no option in Search fields to search with attribute and search returns no results. 4. Apply this patch. 5. Attempt the search again. => Note that attribnute is now search option and search returns results. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39981 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39981 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Sponsorship status|--- |Sponsored Comma delimited| |Koha-Suomi Oy list of Sponsors| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39981 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199284|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39981 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 199304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199304&action=edit Bug 39981: Allow searching with patron extended attribute with top bar Currently searching patrons with patron extended attribute only works from patron search page unless attribute has "Search by default" preference turned on. This patch adds patron attributes as search options for top bar "Search patrons" functionality. To test: 1. Add new patron extended attribute, don't enable "Search by default" preference for it. 2. Add this attribute for a patron. 3. Attempt to search patron with the new attribute from top bar search. => Note that there is no option in Search fields to search with attribute and search returns no results. 4. Apply this patch. 5. Attempt the search again. => Note that attribnute is now search option and search returns results. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39981 OpenFifth Sandboxes <sandboxes@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199304|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39981 --- Comment #5 from OpenFifth Sandboxes <sandboxes@openfifth.co.uk> --- Created attachment 199329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199329&action=edit Bug 39981: Allow searching with patron extended attribute with top bar Currently searching patrons with patron extended attribute only works from patron search page unless attribute has "Search by default" preference turned on. This patch adds patron attributes as search options for top bar "Search patrons" functionality. To test: 1. Add new patron extended attribute, don't enable "Search by default" preference for it. 2. Add this attribute for a patron. 3. Attempt to search patron with the new attribute from top bar search. => Note that there is no option in Search fields to search with attribute and search returns no results. 4. Apply this patch. 5. Attempt the search again. => Note that attribnute is now search option and search returns results. Sponsored-by: Koha-Suomi Oy Signed-off-by: Mikko Liimatainen <mikko.liimatainen@turku.fi> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org