[Bug 25343] New: Use of item in review/comment feature is misleading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25343 Bug ID: 25343 Summary: Use of item in review/comment feature is misleading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When you have reviewson activated, you can add comments to titles in the OPAC. There is this text showing: There are no comments for this item. Post your comments on this item. This can lead to wrong translations as items are usually translated thinking of the physical items (not the same word in some languages like German). I suggest changing it to be more clear. "title" would be my suggestion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25343 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25343 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 104518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104518&action=edit Bug 25343: Use of item in review/comment feature is misleading This patch updates the terminology associated with leaving a comment in the OPAC. the word "item" is replaced with the more specific "title." To test, apply the patch and make sure the reviewson system preference is enabled. - Log in to the OPAC and view a bibliographic record which has no comments. - Under the "comments" tab, verify that the text in the tab says "There are no comments on this title. Post your comments on this title." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104518|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104555&action=edit Bug 25343: Use of item in review/comment feature is misleading This patch updates the terminology associated with leaving a comment in the OPAC. the word "item" is replaced with the more specific "title." To test, apply the patch and make sure the reviewson system preference is enabled. - Log in to the OPAC and view a bibliographic record which has no comments. - Under the "comments" tab, verify that the text in the tab says "There are no comments on this title. Post your comments on this title." Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25343 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Admittedly trying to speed up some last minute string fixes :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25343 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25343 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25343 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- Backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org