[Bug 10586] New: Printing cart from Firefox seems to be missing CSS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Bug ID: 10586 Summary: Printing cart from Firefox seems to be missing CSS Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de To test: - Print a cart from Firefox - Print a cart from Chromium In my tests Chromium printed the table borders nicely formated using a non-serif font for the text, while Firefox printed using a serif font and the table without border lines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 19802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19802&action=edit Bug 10586 - Printing cart from Firefox seems to be missing CSS When printing the Cart from Firefox the styling is off even though it looks correct in preview. I think this may be because the preview is including stylesheets designated for screen. This patch removes special handling of JS and CSS assets for the Cart's print view, letting the page handle print styling like other pages in the OPAC. To test, put items in your Cart in the OPAC. Open your Cart and click the "print" link. Your printout should be correctly styled and match the preview. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19802|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 19813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19813&action=edit Bug 10586 - Printing cart from Firefox seems to be missing CSS When printing the Cart from Firefox the styling is off even though it looks correct in preview. I think this may be because the preview is including stylesheets designated for screen. This patch removes special handling of JS and CSS assets for the Cart's print view, letting the page handle print styling like other pages in the OPAC. To test, put items in your Cart in the OPAC. Open your Cart and click the "print" link. Your printout should be correctly styled and match the preview. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Tested both fail condition and condition with patch - display is much improved. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19813|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19822&action=edit Bug 10586 - Printing cart from Firefox seems to be missing CSS When printing the Cart from Firefox the styling is off even though it looks correct in preview. I think this may be because the preview is including stylesheets designated for screen. This patch removes special handling of JS and CSS assets for the Cart's print view, letting the page handle print styling like other pages in the OPAC. To test, put items in your Cart in the OPAC. Open your Cart and click the "print" link. Your printout should be correctly styled and match the preview. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Tested both fail condition and condition with patch - display is much improved. Thanks, Owen! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10586 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org