[Bug 21163] New: Basket group detail page layout is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Bug ID: 21163 Summary: Basket group detail page layout is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org See this screenshot: https://screenshots.firefox.com/UXubeSlczdiSCxQg/localhost the main part of the page is out of it's position -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77488&action=edit Bug 21163: Basket group detail page layout is broken This patch makes markup changes and improvements to the basket groups template. This fixes a problem with layout of the page when viewing a closed basket group. Fixed: Changed the grid options for basket information when a basket group is closed. Also changed: Removed some unnecessary script and style "type" attributes. Rearranged some list markup in order to avoid validation errors. Removed some id attributes which were causing validation error. Added some minor style changes to improve readability. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should have multiple baskets and basket groups to test with. - Edit an open basket group. The layout should look correct, with basket group information in the form in the left column and ungrouped basket in the right column. Grouping and ungrouping baskets should work correctly. - View a closed basket group. The basket group information should display in a single column that spans the main part of the page. - HTML validation of the page should contain no relevant errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I would have preferred a patch with only the needed changes, this wants does too many things. At least one bug: deliverycomment textarea is not displayed when creating a new basket group. Indentation of last patch of the patch looks weird, it should be 1 input per line (here it is sometimes 1, 2 or 3). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 77489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77489&action=edit Bug 21163: Basket group detail page layout is broken This fixes a problem with layout of the page when viewing a closed basket group. Changed the grid options for basket information when a basket group is closed. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should have multiple baskets and basket groups to test with. - Edit an open basket group. The layout should look correct, with basket group information in the form in the left column and ungrouped basket in the right column. Grouping and ungrouping baskets should work correctly. - View a closed basket group. The basket group information should display in a single column that spans the main part of the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20667 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20667 [Bug 20667] Update two-column templates with Bootstrap grid: Acquisitions part 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77489|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 77492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77492&action=edit Bug 21163: Basket group detail page layout is broken This fixes a problem with layout of the page when viewing a closed basket group. Changed the grid options for basket information when a basket group is closed. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should have multiple baskets and basket groups to test with. - Edit an open basket group. The layout should look correct, with basket group information in the form in the left column and ungrouped basket in the right column. Grouping and ungrouping baskets should work correctly. - View a closed basket group. The basket group information should display in a single column that spans the main part of the page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77492|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 77552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77552&action=edit Bug 21163: Basket group detail page layout is broken This fixes a problem with layout of the page when viewing a closed basket group. Changed the grid options for basket information when a basket group is closed. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. You should have multiple baskets and basket groups to test with. - Edit an open basket group. The layout should look correct, with basket group information in the form in the left column and ungrouped basket in the right column. Grouping and ungrouping baskets should work correctly. - View a closed basket group. The basket group information should display in a single column that spans the main part of the page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21163 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Depends on (and is caused by) but 20667 which is not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org