[Bug 15959] New: Use Font Awesome icons for attach item confirmations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Bug ID: 15959 Summary: Use Font Awesome icons for attach item confirmations Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/moveitem.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 15785 In the catalog, when you use the "Edit -> Attach item" menu option, the confirmation and error dialogs should be styled with Font Awesome icons. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15785 [Bug 15785] Use Font Awesome icons in confirmation dialogs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48551&action=edit Bug 15959 - Use Font Awesome icons for attach item confirmations When attaching an existing item to a record, the confirmation and error dialogs should be styled using Font Awesome icons. This patch revises the buttons and revises the global CSS file. To test, apply the patch and clear your cache if necessary. - Locate a record in the catalog to which you can attach an item. - Select "Attach item" from the "Edit" menu. - Submit a barcode for an exising item. - Verify that the confirmation dialog is correctly styled. - Test the operation of both the "OK" and the "Attach another item" buttons. - Submit an invalid barcode. - Verify that the error dialog is correctly styled. - Test the operation of both the "OK" and the "Try again" buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48551|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 48564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48564&action=edit [SIGNED-OFF]Bug 15959: Use Font Awesome icons for attach item confirmations When attaching an existing item to a record, the confirmation and error dialogs should be styled using Font Awesome icons. This patch revises the buttons and revises the global CSS file. To test, apply the patch and clear your cache if necessary. - Locate a record in the catalog to which you can attach an item. - Select "Attach item" from the "Edit" menu. - Submit a barcode for an exising item. - Verify that the confirmation dialog is correctly styled. - Test the operation of both the "OK" and the "Attach another item" buttons. - Submit an invalid barcode. - Verify that the error dialog is correctly styled. - Test the operation of both the "OK" and the "Try again" buttons. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48564|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48614&action=edit Bug 15959: Use Font Awesome icons for attach item confirmations When attaching an existing item to a record, the confirmation and error dialogs should be styled using Font Awesome icons. This patch revises the buttons and revises the global CSS file. To test, apply the patch and clear your cache if necessary. - Locate a record in the catalog to which you can attach an item. - Select "Attach item" from the "Edit" menu. - Submit a barcode for an exising item. - Verify that the confirmation dialog is correctly styled. - Test the operation of both the "OK" and the "Attach another item" buttons. - Submit an invalid barcode. - Verify that the error dialog is correctly styled. - Test the operation of both the "OK" and the "Try again" buttons. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It would be interesting to use CSS3 variables (https://www.w3.org/TR/css-variables/) to define the different colors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15959 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org