[Bug 28589] New: Move C4 and Koha to lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 Bug ID: 28589 Summary: Move C4 and Koha to lib Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 28519 Git handles that perfectly in both ways: * a patch has been created with a file in /Koha, and is applied later when it's moved to /lib/Koha * a file is modified in /lib/Koha and backported into branches which have the file in /Koha Are we ready for this move? Is it something we really want? Who is willing to spend time on working on this (testing mostly)? We can push it in the next month if there are volunteers. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28519 [Bug 28519] Add a 2nd directory for Perl modules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |julian.maurice@biblibre.com | |, | |kyle@bywatersolutions.com, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- And, most of all, what are the possible side-effects and changes needed in side-projects? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- What is the benefit exactly? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #2)
What is the benefit exactly?
Now that we have it (the lib directory), it makes sense to use if of our lib :) It follows the standard for perl projects. Ideally we also would like to tidy the whole root directory and move the intranet controller scripts to a single directory (see bug 9949). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9949 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
(In reply to Marcel de Rooy from comment #2)
What is the benefit exactly?
Now that we have it (the lib directory), it makes sense to use if of our lib :) It follows the standard for perl projects.
Ideally we also would like to tidy the whole root directory and move the intranet controller scripts to a single directory (see bug 9949).
Haha, yeah thats what I expected :) Note that I asked David for this lib folder on the other report too.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd love to see this.. it would certainly move us towards being a bit more 'normal' in the perl world.. might mean we can start adopting other more widely supported perl solutions for other things too.. not sure what, but there's loads of perl tooling out there that expects to find things in '/lib' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #0)
Are we ready for this move? Is it something we really want? Who is willing to spend time on working on this (testing mostly)?
What better time than now? - It will mean we can keep all our Perl modules together in a place where any (new or old) developer could predict to find them - It will also make it easier to work with multiple namespaces. - It will provide a smaller target for git/dev installs (rather than having "lib" be the entire source tree) - It also provides a mechanism for overriding modules. There are cases where you might want to use a library but want to customize the behaviour of a submodule. It doesn't necessarily make sense to fork an entire library, but you can override a single module, since the Koha "lib" directory is sourced earlier in @INC - It provides a first step to cleaning up the top-level directory - It provides an opportunity to find little hacks where we load modules based on file system location rather than their presence in @INC. I can put some time into this. I imagine most issues would be related to C4 and SIP. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28618 [Bug 28618] Move t/lib modules to lib/Koha/Test -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28619 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28619 [Bug 28619] Move misc/translator/ modules to lib/C4/Translate (?) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122319&action=edit Bug 28589: git mv C4 lib && git mv Koha lib -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122320&action=edit Bug 28589: lib dir adjustements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28589 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What else would be needed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org