https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Good idea. However, I think it should be fixed in all languages, not only in English, e.g.: ./installer/data/mysql/pl-PL/optional/sample_itemtypes.sql ./installer/data/mysql/es-ES/optional/sample_itemtypes.sql ./installer/data/mysql/de-DE/optional/sample_itemtypes.sql (there are more) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67422|0 |1 is obsolete| | --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- Created attachment 67426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67426&action=edit Bug 19377 - Remove $5 charge from sample item types Most of the sample item types come with a rental charge of $5. This is really annoying when you're testing Koha with a fast catalogued book, since you end up having to write off fines and change the item type before you can actually get to the testing you want to do. I left the rental charge on most other items so that you can test rental charges easily by using a item type other than BOOK or REF. _TEST PLAN_ Before applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note a $5 rental charge After applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note no $5 rental charge Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch and looked at the change to the SQL-file. Looks good. That fine on books has surprised me one too many times! :-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- I added a followup to cleanup books across all the files, I noticed though that some samples have charges for some itemtypes, and other have them for none. Maybe we should standardize all of them? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67426|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 68367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68367&action=edit Bug 19377 - Remove $5 charge from sample item types Most of the sample item types come with a rental charge of $5. This is really annoying when you're testing Koha with a fast catalogued book, since you end up having to write off fines and change the item type before you can actually get to the testing you want to do. I left the rental charge on most other items so that you can test rental charges easily by using a item type other than BOOK or REF. _TEST PLAN_ Before applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note a $5 rental charge After applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note no $5 rental charge Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch and looked at the change to the SQL-file. Looks good. That fine on books has surprised me one too many times! :-) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68367|0 |1 is obsolete| | Attachment #68368|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68717&action=edit Bug 19377 - Remove $5 charge from sample item types Most of the sample item types come with a rental charge of $5. This is really annoying when you're testing Koha with a fast catalogued book, since you end up having to write off fines and change the item type before you can actually get to the testing you want to do. I left the rental charge on most other items so that you can test rental charges easily by using a item type other than BOOK or REF. _TEST PLAN_ Before applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note a $5 rental charge After applying 1) drop your test database 2) create your test database 3) install Koha via the web installer and install all sample data 4) do a checkout 5) note no $5 rental charge Signed-off-by: Magnus Enger <magnus@libriotech.no> Applied the patch and looked at the change to the SQL-file. Looks good. That fine on books has surprised me one too many times! :-) Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.